From: Rob Herring <robh@kernel.org>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Benoit Masson <yahoo@perenite.com>
Subject: Re: [RFC PATCH 2/9] dt-bindings: arm: amlogic: add X96-AIR bindings
Date: Tue, 7 Dec 2021 15:21:46 -0600 [thread overview]
Message-ID: <Ya/Qask7Fpb6mTxb@robh.at.kernel.org> (raw)
In-Reply-To: <20211130060523.19161-3-christianshewitt@gmail.com>
On Tue, Nov 30, 2021 at 06:05:16AM +0000, Christian Hewitt wrote:
> Add board bindings for the Amediatech X96-AIR STB which ships with
> model variants distiguished by Ethernet configuration: models using
> internal 10/100 PHY have a -100 suffix, while models using external
> Gigabit PHY have a -1000 suffix.
Isn't the phy described in DT? Why do you need to describe this 1
difference at the top level?
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 36081734f720..e9ab0ffe8be7 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -170,6 +170,8 @@ properties:
> - description: Boards with the Amlogic Meson SM1 S905X3/D3/Y3 SoC
> items:
> - enum:
> + - amediatech,x96-air-100
> + - amediatech,x96-air-1000
> - bananapi,bpi-m5
> - hardkernel,odroid-c4
> - hardkernel,odroid-hc4
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2021-12-07 21:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 6:05 [RFC PATCH 0/9] arm64: dts: meson: add support for aac2xx devices Christian Hewitt
2021-11-30 6:05 ` [RFC PATCH 1/9] arm64: dts: meson: add common SM1 ac2xx dtsi Christian Hewitt
2021-12-06 21:34 ` Martin Blumenstingl
2021-11-30 6:05 ` [RFC PATCH 2/9] dt-bindings: arm: amlogic: add X96-AIR bindings Christian Hewitt
2021-12-07 21:21 ` Rob Herring [this message]
2021-12-08 4:44 ` Christian Hewitt
2021-12-08 8:17 ` Neil Armstrong
2021-11-30 6:05 ` [RFC PATCH 3/9] arm64: dts: meson: add initial device-trees for X96-AIR Christian Hewitt
2021-12-06 21:34 ` Martin Blumenstingl
2021-12-07 8:13 ` Piotr Oniszczuk
2021-11-30 6:05 ` [RFC PATCH 4/9] dt-bindings: vendor-prefixes: add cyx prefix Christian Hewitt
2021-12-07 21:22 ` Rob Herring
2021-11-30 6:05 ` [RFC PATCH 5/9] dt-bindings: arm: amlogic: add A95XF3-AIR bindings Christian Hewitt
2021-11-30 6:05 ` [RFC PATCH 6/9] arm64: dts: meson: add initial device-trees for A95XF3-AIR Christian Hewitt
2022-01-03 15:21 ` Neil Armstrong
2022-01-03 15:26 ` Christian Hewitt
2021-11-30 6:05 ` [RFC PATCH 7/9] dt-bindings: vendor-prefixes: add haochuangyi prefix Christian Hewitt
2021-12-07 21:23 ` Rob Herring
2021-11-30 6:05 ` [RFC PATCH 8/9] dt-bindings: arm: amlogic: add H96-Max bindings Christian Hewitt
2021-12-07 21:23 ` Rob Herring
2021-11-30 6:05 ` [RFC PATCH 9/9] arm64: dts: meson: add initial device-tree for H96-Max Christian Hewitt
2021-11-30 10:40 ` [RFC PATCH 0/9] arm64: dts: meson: add support for aac2xx devices Neil Armstrong
2021-12-06 18:06 ` Kevin Hilman
2021-12-08 8:20 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya/Qask7Fpb6mTxb@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=yahoo@perenite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).