From: Nadav Amit <namit@vmware.com>
To: Logan Gunthorpe <logang@deltatee.com>, Ingo Molnar <mingo@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros
Date: Thu, 15 Nov 2018 01:57:52 +0000 [thread overview]
Message-ID: <521458D7-A27C-4112-81ED-1974EFE96A76@vmware.com> (raw)
In-Reply-To: <db8293cf-9abc-e899-8f43-6e42039006d9@deltatee.com>
From: Logan Gunthorpe
Sent: November 15, 2018 at 1:19:45 AM GMT
> To: Nadav Amit <namit@vmware.com>, Ingo Molnar <mingo@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Michal Marek <michal.lkml@markovi.net>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, H. Peter Anvin <hpa@zytor.com>, X86 ML <x86@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros
>
>
>
>
> On 14/11/18 10:46 AM, Nadav Amit wrote:
>> Actually, we can just figure out whether distcc or icecc are used in the
>> Makefile according to the “version”, similarly to the way clang is detected.
>> This would neither require new Makefile arguments or Kconfig options.
>>
>> What do you say about the following?
>
> That may be a good idea, but I was kind of hoping to be able to add
> support for this to at least a future version of icecc (though I'm not
> committing to that...). So it would be nice to have a way to force it
> one way or the other with an environment variable.
As long as the argument was *required* to get distcc to work at all, you
could expect people would figure out an argument is needed. In this case, I
suspect nobody will ever know about this argument (except you).
Eventually, if you get a fix into icecc, we will need to change the
Makefile, consider the version number and act accordingly.
Anyhow, I’ll add an argument as you asked, and let Ingo (& others) be the
judge(s).
next prev parent reply other threads:[~2018-11-15 1:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 15:02 [PATCH 0/2] x86: Asm macros fixes Nadav Amit
2018-11-12 15:02 ` [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros Nadav Amit
2018-11-13 11:30 ` Ingo Molnar
2018-11-13 17:55 ` Nadav Amit
2018-11-13 18:34 ` Nadav Amit
2018-11-14 7:29 ` Logan Gunthorpe
2018-11-14 17:46 ` Nadav Amit
2018-11-15 1:19 ` Logan Gunthorpe
2018-11-15 1:57 ` Nadav Amit [this message]
2018-11-15 2:00 ` Logan Gunthorpe
2018-11-28 23:09 ` Logan Gunthorpe
2018-11-29 0:38 ` Nadav Amit
2018-11-29 0:49 ` Logan Gunthorpe
2018-11-29 1:31 ` Nadav Amit
2018-11-29 16:43 ` Logan Gunthorpe
2018-12-01 6:29 ` Nadav Amit
2018-11-12 15:02 ` [PATCH 2/2] x86: set a dependency on macros.S Nadav Amit
2018-11-13 11:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521458D7-A27C-4112-81ED-1974EFE96A76@vmware.com \
--to=namit@vmware.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).