From: "Pablo Sebastián Greco" <pgreco@centosproject.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Hans de Goede <hdegoede@redhat.com>,
Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
Date: Mon, 2 Nov 2020 11:21:14 -0300 [thread overview]
Message-ID: <52413556-ec13-e428-7139-01d323697ebc@centosproject.org> (raw)
In-Reply-To: <20201102140715.r72yz7jx3usuhqi7@gilmour.lan>
On 2/11/20 11:07, Maxime Ripard wrote:
> Hi,
>
> On Sat, Oct 31, 2020 at 09:34:15PM -0300, Pablo Greco wrote:
>> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
>> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>>
>> Fix the phy-mode description to correct reflect this so that the
>> implementation doesn't reconfigure the delays incorrectly. This
>> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
>> rx/tx delay config").
>>
>> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
>> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> Thanks for sending those patches.
>
> However, I'm not entirely sure how you sent it but the odd threading you
> used (each other patches being in reply to this one without 0/N in the
> name) seem to confuse the tools we use to apply the patches.
>
> Can you resend it properly?
> Thanks!
> Maxime
I prepared them individually but sent them together in a single
git-send-email, that must have been the problem.
I"ll send them again one by one.
Pablo.
next prev parent reply other threads:[~2020-11-02 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
2020-11-01 7:31 ` Jernej Škrabec
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
2020-11-01 7:29 ` Jernej Škrabec
2020-11-01 7:34 ` [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Jernej Škrabec
2020-11-02 14:07 ` Maxime Ripard
2020-11-02 14:21 ` Pablo Sebastián Greco [this message]
2020-11-02 14:16 Pablo Greco
2020-11-02 17:06 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52413556-ec13-e428-7139-01d323697ebc@centosproject.org \
--to=pgreco@centosproject.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).