* [PATCH RESEND] clocksource: of: respect device tree node status
@ 2013-09-19 10:47 Sebastian Hesselbarth
2013-09-25 15:29 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Hesselbarth @ 2013-09-19 10:47 UTC (permalink / raw)
To: Sebastian Hesselbarth
Cc: Sebastian Hesselbarth, Daniel Lezcano, Thomas Gleixner, linux-kernel
Clocksource devices provided by DT can be disabled (status != "okay").
Instead of registering clocksource drivers for disabled nodes, respect
the device's status by skiping disabled nodes.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
---
drivers/clocksource/clksrc-of.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/clocksource/clksrc-of.c
b/drivers/clocksource/clksrc-of.c
index 37f5325..b9ddd9e 100644
--- a/drivers/clocksource/clksrc-of.c
+++ b/drivers/clocksource/clksrc-of.c
@@ -30,6 +30,9 @@ void __init clocksource_of_init(void)
clocksource_of_init_fn init_func;
for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
+ if (!of_device_is_available(np))
+ continue;
+
init_func = match->data;
init_func(np);
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] clocksource: of: respect device tree node status
2013-09-19 10:47 [PATCH RESEND] clocksource: of: respect device tree node status Sebastian Hesselbarth
@ 2013-09-25 15:29 ` Daniel Lezcano
2013-09-25 15:34 ` Sebastian Hesselbarth
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2013-09-25 15:29 UTC (permalink / raw)
To: Sebastian Hesselbarth; +Cc: Thomas Gleixner, linux-kernel
On 09/19/2013 12:47 PM, Sebastian Hesselbarth wrote:
> Clocksource devices provided by DT can be disabled (status != "okay").
> Instead of registering clocksource drivers for disabled nodes, respect
> the device's status by skiping disabled nodes.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Shall it be applied as a 3.12 fix ?
> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/clocksource/clksrc-of.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/clocksource/clksrc-of.c
> b/drivers/clocksource/clksrc-of.c
> index 37f5325..b9ddd9e 100644
> --- a/drivers/clocksource/clksrc-of.c
> +++ b/drivers/clocksource/clksrc-of.c
> @@ -30,6 +30,9 @@ void __init clocksource_of_init(void)
> clocksource_of_init_fn init_func;
> for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
> + if (!of_device_is_available(np))
> + continue;
> +
> init_func = match->data;
> init_func(np);
> }
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] clocksource: of: respect device tree node status
2013-09-25 15:29 ` Daniel Lezcano
@ 2013-09-25 15:34 ` Sebastian Hesselbarth
2013-09-26 0:10 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Hesselbarth @ 2013-09-25 15:34 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: Thomas Gleixner, linux-kernel
On 09/25/2013 05:29 PM, Daniel Lezcano wrote:
> On 09/19/2013 12:47 PM, Sebastian Hesselbarth wrote:
>> Clocksource devices provided by DT can be disabled (status != "okay").
>> Instead of registering clocksource drivers for disabled nodes, respect
>> the device's status by skiping disabled nodes.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> Shall it be applied as a 3.12 fix ?
Daniel,
difficult to say. Although I am not aware of any mainline mach
depends on it, I consider this a fix. So, if there are no objections
please apply for 3.12.
Sebastian
>> ---
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> drivers/clocksource/clksrc-of.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/clocksource/clksrc-of.c
>> b/drivers/clocksource/clksrc-of.c
>> index 37f5325..b9ddd9e 100644
>> --- a/drivers/clocksource/clksrc-of.c
>> +++ b/drivers/clocksource/clksrc-of.c
>> @@ -30,6 +30,9 @@ void __init clocksource_of_init(void)
>> clocksource_of_init_fn init_func;
>> for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
>> + if (!of_device_is_available(np))
>> + continue;
>> +
>> init_func = match->data;
>> init_func(np);
>> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] clocksource: of: respect device tree node status
2013-09-25 15:34 ` Sebastian Hesselbarth
@ 2013-09-26 0:10 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2013-09-26 0:10 UTC (permalink / raw)
To: Sebastian Hesselbarth; +Cc: Thomas Gleixner, linux-kernel
On 09/25/2013 05:34 PM, Sebastian Hesselbarth wrote:
> On 09/25/2013 05:29 PM, Daniel Lezcano wrote:
>> On 09/19/2013 12:47 PM, Sebastian Hesselbarth wrote:
>>> Clocksource devices provided by DT can be disabled (status != "okay").
>>> Instead of registering clocksource drivers for disabled nodes, respect
>>> the device's status by skiping disabled nodes.
>>>
>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>
>> Shall it be applied as a 3.12 fix ?
>
> Daniel,
>
> difficult to say. Although I am not aware of any mainline mach
> depends on it, I consider this a fix. So, if there are no objections
> please apply for 3.12.
Ok, applied to my tree.
Thanks
-- Daniel
>>> ---
>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: linux-kernel@vger.kernel.org
>>> ---
>>> drivers/clocksource/clksrc-of.c | 3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/clocksource/clksrc-of.c
>>> b/drivers/clocksource/clksrc-of.c
>>> index 37f5325..b9ddd9e 100644
>>> --- a/drivers/clocksource/clksrc-of.c
>>> +++ b/drivers/clocksource/clksrc-of.c
>>> @@ -30,6 +30,9 @@ void __init clocksource_of_init(void)
>>> clocksource_of_init_fn init_func;
>>> for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
>>> + if (!of_device_is_available(np))
>>> + continue;
>>> +
>>> init_func = match->data;
>>> init_func(np);
>>> }
>>
>>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-26 0:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-19 10:47 [PATCH RESEND] clocksource: of: respect device tree node status Sebastian Hesselbarth
2013-09-25 15:29 ` Daniel Lezcano
2013-09-25 15:34 ` Sebastian Hesselbarth
2013-09-26 0:10 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).