From: "Chen, Rong A" <rong.a.chen@intel.com>
To: Miaohe Lin <linmiaohe@huawei.com>,
kernel test robot <lkp@intel.com>, Peter Xu <peterx@redhat.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz,
dhowells@redhat.com, neilb@suse.de, david@redhat.com,
apopple@nvidia.com, surenb@google.com, minchan@kernel.org,
sfr@canb.auug.org.au, rcampbell@nvidia.com,
naoya.horiguchi@nec.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [kbuild-all] Re: [PATCH] mm/swap: Fix lost swap bits in unuse_pte()
Date: Wed, 20 Apr 2022 14:48:15 +0800 [thread overview]
Message-ID: <52536319-962a-864c-d5a7-5b959aa91f22@intel.com> (raw)
In-Reply-To: <c14c0865-867c-ca14-8b2c-7e6e94ee7c85@huawei.com>
On 4/20/2022 2:23 PM, Miaohe Lin wrote:
> On 2022/4/20 13:56, kernel test robot wrote:
>> Hi Peter,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on hnaz-mm/master]
>>
>> url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845
>> base: https://github.com/hnaz/linux-mm master
>> config: s390-randconfig-r023-20220420 (https://download.01.org/0day-ci/archive/20220420/202204201313.QYiDBRbL-lkp@intel.com/config)
>> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # install s390 cross compiling tool for clang build
>> # apt-get install binutils-s390x-linux-gnu
>> # https://github.com/intel-lab-lkp/linux/commit/355ac3eb45402f7aab25b76af029d4390af05238
>> git remote add linux-review https://github.com/intel-lab-lkp/linux
>> git fetch --no-tags linux-review Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845
>> git checkout 355ac3eb45402f7aab25b76af029d4390af05238
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>
> The variable name is newpte. But it's written as new_pte latter. Many thanks for report!
>
> BTW: Since this is not a formal patch (no compile tested). Is Reported-by tag still needed?
Hi Miaohe,
Please ignore the tag, it's only a suggestion, the bot doesn't
know the entire picture.
Best Regards,
Rong Chen
>
> Thanks!
>
>> All errors (new ones prefixed by >>):
>>
>>>> mm/swapfile.c:1824:2: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'?
>> new_pte = pte_mkold(mk_pte(page, vma->vm_page_prot));
>> ^~~~~~~
>> newpte
>> mm/swapfile.c:1786:14: note: 'newpte' declared here
>> pte_t *pte, newpte;
>> ^
>> mm/swapfile.c:1826:26: error: use of undeclared identifier 'new_pte'
>> pte = pte_mksoft_dirty(new_pte);
>> ^
>> mm/swapfile.c:1828:23: error: use of undeclared identifier 'new_pte'
>> pte = pte_mkuffd_wp(new_pte);
>> ^
>> mm/swapfile.c:1829:36: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'?
>> set_pte_at(vma->vm_mm, addr, pte, new_pte);
>> ^~~~~~~
>> newpte
>> mm/swapfile.c:1786:14: note: 'newpte' declared here
>> pte_t *pte, newpte;
>> ^
>> 4 errors generated.
> ...
>> 1839
>>
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
>
next prev parent reply other threads:[~2022-04-20 6:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 3:05 [PATCH v2] mm/swapfile: unuse_pte can map random data if swap read fails Miaohe Lin
2022-04-19 3:51 ` Alistair Popple
2022-04-19 7:29 ` Miaohe Lin
2022-04-19 7:39 ` David Hildenbrand
2022-04-19 8:08 ` Alistair Popple
2022-04-19 11:14 ` David Hildenbrand
2022-04-19 16:16 ` Peter Xu
2022-04-19 11:14 ` Miaohe Lin
2022-04-19 7:53 ` Alistair Popple
2022-04-19 11:26 ` Miaohe Lin
2022-04-20 0:25 ` Alistair Popple
2022-04-20 6:15 ` Miaohe Lin
2022-04-20 7:07 ` David Hildenbrand
2022-04-20 8:37 ` Miaohe Lin
2022-04-19 7:37 ` David Hildenbrand
2022-04-19 11:21 ` Miaohe Lin
2022-04-19 11:46 ` David Hildenbrand
2022-04-19 12:00 ` Miaohe Lin
2022-04-19 12:12 ` David Hildenbrand
2022-04-19 12:45 ` Miaohe Lin
2022-04-19 21:36 ` Peter Xu
2022-04-20 5:56 ` [PATCH] mm/swap: Fix lost swap bits in unuse_pte() kernel test robot
2022-04-20 6:23 ` Miaohe Lin
2022-04-20 6:39 ` [kbuild-all] " Philip Li
2022-04-20 6:52 ` Miaohe Lin
2022-04-20 6:48 ` Chen, Rong A [this message]
2022-04-20 6:56 ` Miaohe Lin
2022-04-20 6:21 ` [PATCH v2] mm/swapfile: unuse_pte can map random data if swap read fails Miaohe Lin
2022-04-20 13:32 ` Peter Xu
2022-04-21 1:50 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52536319-962a-864c-d5a7-5b959aa91f22@intel.com \
--to=rong.a.chen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=minchan@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=neilb@suse.de \
--cc=peterx@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=sfr@canb.auug.org.au \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).