From: Miaohe Lin <linmiaohe@huawei.com>
To: David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>
Cc: <willy@infradead.org>, <vbabka@suse.cz>, <dhowells@redhat.com>,
<neilb@suse.de>, <apopple@nvidia.com>, <surenb@google.com>,
<minchan@kernel.org>, <peterx@redhat.com>, <sfr@canb.auug.org.au>,
<rcampbell@nvidia.com>, <naoya.horiguchi@nec.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm/swapfile: unuse_pte can map random data if swap read fails
Date: Tue, 19 Apr 2022 20:00:32 +0800 [thread overview]
Message-ID: <a6707adc-6d3e-92bb-4bb3-29a6e1f350f1@huawei.com> (raw)
In-Reply-To: <c901938d-efcc-6a94-bbf4-93e7f4c2ea7d@redhat.com>
On 2022/4/19 19:46, David Hildenbrand wrote:
...
>> Do you mean that we should set the pfn to 0 for the hwpoison marker so that we can
>> distinguish swapin error case from real hwpoison case?
>
> I am not sure if we really have to distinguish. However, "0" seems to
> make sense to indicate "this is not an actual problematic PFN, the
> information is simply no longer around due to a hardware issue.
>
IMHO, we have to distinguish. For example, we might need to return VM_FAULT_SIGBUS
instead of VM_FAULT_HWPOISON when user accesses the error page. Or should we simply
return VM_FAULT_HWPOISON to simplify the handling?
Thanks!
next prev parent reply other threads:[~2022-04-19 12:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 3:05 [PATCH v2] mm/swapfile: unuse_pte can map random data if swap read fails Miaohe Lin
2022-04-19 3:51 ` Alistair Popple
2022-04-19 7:29 ` Miaohe Lin
2022-04-19 7:39 ` David Hildenbrand
2022-04-19 8:08 ` Alistair Popple
2022-04-19 11:14 ` David Hildenbrand
2022-04-19 16:16 ` Peter Xu
2022-04-19 11:14 ` Miaohe Lin
2022-04-19 7:53 ` Alistair Popple
2022-04-19 11:26 ` Miaohe Lin
2022-04-20 0:25 ` Alistair Popple
2022-04-20 6:15 ` Miaohe Lin
2022-04-20 7:07 ` David Hildenbrand
2022-04-20 8:37 ` Miaohe Lin
2022-04-19 7:37 ` David Hildenbrand
2022-04-19 11:21 ` Miaohe Lin
2022-04-19 11:46 ` David Hildenbrand
2022-04-19 12:00 ` Miaohe Lin [this message]
2022-04-19 12:12 ` David Hildenbrand
2022-04-19 12:45 ` Miaohe Lin
2022-04-19 21:36 ` Peter Xu
2022-04-20 5:56 ` [PATCH] mm/swap: Fix lost swap bits in unuse_pte() kernel test robot
2022-04-20 6:23 ` Miaohe Lin
2022-04-20 6:39 ` [kbuild-all] " Philip Li
2022-04-20 6:52 ` Miaohe Lin
2022-04-20 6:48 ` Chen, Rong A
2022-04-20 6:56 ` Miaohe Lin
2022-04-20 6:21 ` [PATCH v2] mm/swapfile: unuse_pte can map random data if swap read fails Miaohe Lin
2022-04-20 13:32 ` Peter Xu
2022-04-21 1:50 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6707adc-6d3e-92bb-4bb3-29a6e1f350f1@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=neilb@suse.de \
--cc=peterx@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=sfr@canb.auug.org.au \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).