Re: Perf Python Scripting Leaks Memory

Re: Perf Python Scripting Leaks Memory

[Arnaldo Carvalho de Melo]

Em Wed, Oct 23, 2013 at 04:37:41PM +0200, Joseph Schuchart escreveu:
>    We are using the Python scripting interface in perf to extract kernel
>    events relevant for performance analysis of HPC codes. We noticed that the
>    "perf script" call allocates a significant amount of memory (in the order
>    of several 100 MiB) during it's run, e.g. 125 MiB for a 25 MiB input file:

Thanks for the analysis and the bug fix!

I asked Tom Zanussi and he kindly reviewed your patch and provided an
Acked-by tag for it, Tom, may I add a Reviewed-by: as well?

Joseph, can I have your Signed-off-by: tag, as documented in:

Documentation/SubmittingPatches

In the "12) Sign your work" section?

Thanks!

- Arnaldo

Re: Perf Python Scripting Leaks Memory

[Tom Zanussi]

On Wed, 2013-10-23 at 17:01 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 23, 2013 at 04:37:41PM +0200, Joseph Schuchart escreveu:
> >    We are using the Python scripting interface in perf to extract kernel
> >    events relevant for performance analysis of HPC codes. We noticed that the
> >    "perf script" call allocates a significant amount of memory (in the order
> >    of several 100 MiB) during it's run, e.g. 125 MiB for a 25 MiB input file:
> 
> Thanks for the analysis and the bug fix!
> 
> I asked Tom Zanussi and he kindly reviewed your patch and provided an
> Acked-by tag for it, Tom, may I add a Reviewed-by: as well?
> 

Sure.

Reviewed-by: <tom.zanussi@linux.intel.com>

Tom

> Joseph, can I have your Signed-off-by: tag, as documented in:
> 
> Documentation/SubmittingPatches
> 
> In the "12) Sign your work" section?
> 
> Thanks!
> 
> - Arnaldo

Re: Perf Python Scripting Leaks Memory

[Joseph Schuchart]

On 23.10.2013 22:01, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 23, 2013 at 04:37:41PM +0200, Joseph Schuchart escreveu:
>>    We are using the Python scripting interface in perf to extract kernel
>>    events relevant for performance analysis of HPC codes. We noticed that the
>>    "perf script" call allocates a significant amount of memory (in the order
>>    of several 100 MiB) during it's run, e.g. 125 MiB for a 25 MiB input file:
> 
> Thanks for the analysis and the bug fix!
> 
> I asked Tom Zanussi and he kindly reviewed your patch and provided an
> Acked-by tag for it, Tom, may I add a Reviewed-by: as well?
> 
> Joseph, can I have your Signed-off-by: tag, as documented in:
> 
> Documentation/SubmittingPatches
> 

Thanks for your quick reply and sorry for not following the
recommendations in the documentation.

Signed-off-by: Joseph Schuchart <joseph.schuchart@tu-dresden.de>

Thanks!
Joseph