linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
@ 2013-11-01 10:00 Duan Jiong
  2013-11-01 13:38 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2013-11-01 10:00 UTC (permalink / raw)
  To: acme; +Cc: netdev, linux-kernel, Duan Jiong

This patch fixes coccinelle error regarding usage of IS_ERR and
PTR_ERR instead of PTR_ERR_OR_ZERO.

Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
 drivers/net/appletalk/ipddp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/appletalk/ipddp.c b/drivers/net/appletalk/ipddp.c
index 10d0dba..78f06cb 100644
--- a/drivers/net/appletalk/ipddp.c
+++ b/drivers/net/appletalk/ipddp.c
@@ -312,9 +312,7 @@ module_param(ipddp_mode, int, 0);
 static int __init ipddp_init_module(void)
 {
 	dev_ipddp = ipddp_init();
-        if (IS_ERR(dev_ipddp))
-                return PTR_ERR(dev_ipddp);
-	return 0;
+        return PTR_ERR_OR_ZERO(dev_ipddp);
 }
 
 static void __exit ipddp_cleanup_module(void)
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
  2013-11-01 10:00 [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO Duan Jiong
@ 2013-11-01 13:38 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2013-11-01 13:38 UTC (permalink / raw)
  To: Duan Jiong, acme; +Cc: netdev, linux-kernel

Hello.

On 01-11-2013 14:00, Duan Jiong wrote:

> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.

> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> ---
>   drivers/net/appletalk/ipddp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

> diff --git a/drivers/net/appletalk/ipddp.c b/drivers/net/appletalk/ipddp.c
> index 10d0dba..78f06cb 100644
> --- a/drivers/net/appletalk/ipddp.c
> +++ b/drivers/net/appletalk/ipddp.c
> @@ -312,9 +312,7 @@ module_param(ipddp_mode, int, 0);
>   static int __init ipddp_init_module(void)
>   {
>   	dev_ipddp = ipddp_init();
> -        if (IS_ERR(dev_ipddp))
> -                return PTR_ERR(dev_ipddp);
> -	return 0;
> +        return PTR_ERR_OR_ZERO(dev_ipddp);

    Indent with a tab, please.

WBR, Sergei


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-01 13:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-01 10:00 [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO Duan Jiong
2013-11-01 13:38 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).