* [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
@ 2020-10-07 3:39 Pawel Laszczak
2020-10-07 8:15 ` Roger Quadros
0 siblings, 1 reply; 6+ messages in thread
From: Pawel Laszczak @ 2020-10-07 3:39 UTC (permalink / raw)
To: balbi
Cc: peter.chen, rogerq, nsekhar, gregkh, linux-usb, linux-kernel,
kurahul, Pawel Laszczak
Patch removes not used variable 'length' from
cdns3_wa2_descmiss_copy_data function.
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
drivers/usb/cdns3/gadget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 6e7b70a2e352..692acf7b9b14 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
int chunk_end;
- int length;
descmiss_priv_req =
cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
break;
chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
- length = request->actual + descmiss_req->actual;
request->status = descmiss_req->status;
__cdns3_descmiss_copy_data(request, descmiss_req);
list_del_init(&descmiss_priv_req->list);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
2020-10-07 3:39 [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used Pawel Laszczak
@ 2020-10-07 8:15 ` Roger Quadros
2020-10-07 10:28 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Roger Quadros @ 2020-10-07 8:15 UTC (permalink / raw)
To: Pawel Laszczak, balbi
Cc: peter.chen, nsekhar, gregkh, linux-usb, linux-kernel, kurahul
On 07/10/2020 06:39, Pawel Laszczak wrote:
> Patch removes not used variable 'length' from
> cdns3_wa2_descmiss_copy_data function.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/usb/cdns3/gadget.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 6e7b70a2e352..692acf7b9b14 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>
> while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
> int chunk_end;
> - int length;
>
> descmiss_priv_req =
> cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
> @@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
> break;
>
> chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
> - length = request->actual + descmiss_req->actual;
> request->status = descmiss_req->status;
> __cdns3_descmiss_copy_data(request, descmiss_req);
> list_del_init(&descmiss_priv_req->list);
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
2020-10-07 8:15 ` Roger Quadros
@ 2020-10-07 10:28 ` Sergei Shtylyov
2020-10-08 3:57 ` Pawel Laszczak
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2020-10-07 10:28 UTC (permalink / raw)
To: Roger Quadros, Pawel Laszczak, balbi
Cc: peter.chen, nsekhar, gregkh, linux-usb, linux-kernel, kurahul
Hello!
On 10/7/20 11:15 AM, Roger Quadros wrote:
[...]
>> Patch removes not used variable 'length' from
>> cdns3_wa2_descmiss_copy_data function.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>
> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
No "commit" is needed here.
> Acked-by: Roger Quadros <rogerq@ti.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
2020-10-07 10:28 ` Sergei Shtylyov
@ 2020-10-08 3:57 ` Pawel Laszczak
2020-10-08 7:29 ` Roger Quadros
2020-10-08 10:18 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: Pawel Laszczak @ 2020-10-08 3:57 UTC (permalink / raw)
To: Sergei Shtylyov, Roger Quadros, balbi
Cc: peter.chen, nsekhar, gregkh, linux-usb, linux-kernel, Rahul Kumar
Siergei,
>
>On 10/7/20 11:15 AM, Roger Quadros wrote:
>
>[...]
>>> Patch removes not used variable 'length' from
>>> cdns3_wa2_descmiss_copy_data function.
>>>
>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>
>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>
> No "commit" is needed here.
Can you explain why?
I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
or because it's only warning - not error.
Am I right ?
>
>> Acked-by: Roger Quadros <rogerq@ti.com>
>[...]
>
Regards,
Pawel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
2020-10-08 3:57 ` Pawel Laszczak
@ 2020-10-08 7:29 ` Roger Quadros
2020-10-08 10:18 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2020-10-08 7:29 UTC (permalink / raw)
To: Pawel Laszczak, Sergei Shtylyov, balbi
Cc: peter.chen, nsekhar, gregkh, linux-usb, linux-kernel, Rahul Kumar
Pawel,
On 08/10/2020 06:57, Pawel Laszczak wrote:
> Siergei,
>
>>
>> On 10/7/20 11:15 AM, Roger Quadros wrote:
>>
>> [...]
>>>> Patch removes not used variable 'length' from
>>>> cdns3_wa2_descmiss_copy_data function.
>>>>
>>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>>
>>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>>
>> No "commit" is needed here.
>
> Can you explain why?
>
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
>
> Am I right ?
Siergei meant that the word "commit" should not be used. So it should be
Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
cheers,
-roger
>
>>
>>> Acked-by: Roger Quadros <rogerq@ti.com>
>> [...]
>>
>
> Regards,
> Pawel
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
2020-10-08 3:57 ` Pawel Laszczak
2020-10-08 7:29 ` Roger Quadros
@ 2020-10-08 10:18 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2020-10-08 10:18 UTC (permalink / raw)
To: Pawel Laszczak, Roger Quadros, balbi
Cc: peter.chen, nsekhar, gregkh, linux-usb, linux-kernel, Rahul Kumar
Hello!
On 08.10.2020 6:57, Pawel Laszczak wrote:
> Siergei,
Sergei, or, more correctly, Sergey. :-)
>
>>
>> On 10/7/20 11:15 AM, Roger Quadros wrote:
>>
>> [...]
>>>> Patch removes not used variable 'length' from
>>>> cdns3_wa2_descmiss_copy_data function.
>>>>
>>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>>
>>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>>
>> No "commit" is needed here.
>
> Can you explain why?
>
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
>
> Am I right ?
No, it's because the format is:
Fixes: <SHA1> ("<summary>")
no word "commit" is needed. :-)
>>> Acked-by: Roger Quadros <rogerq@ti.com>
>> [...]
>
> Regards,
> Pawel
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-08 10:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-07 3:39 [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used Pawel Laszczak
2020-10-07 8:15 ` Roger Quadros
2020-10-07 10:28 ` Sergei Shtylyov
2020-10-08 3:57 ` Pawel Laszczak
2020-10-08 7:29 ` Roger Quadros
2020-10-08 10:18 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).