* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 6:36 Alexandre Courbot
2013-11-12 20:04 ` Stephen Warren
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Courbot @ 2013-11-12 6:36 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding
Cc: linux-arm-kernel, linux-tegra, linux-kernel, gnurou, Alexandre Courbot
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index 80b801a94677..0fbdadcd96b7 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -92,9 +92,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: tegra: init fuse before setting reset handler
2013-11-12 6:36 [PATCH] ARM: tegra: init fuse before setting reset handler Alexandre Courbot
@ 2013-11-12 20:04 ` Stephen Warren
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2013-11-12 20:04 UTC (permalink / raw)
To: Alexandre Courbot, Thierry Reding
Cc: linux-arm-kernel, linux-tegra, linux-kernel, gnurou
On 11/11/2013 11:36 PM, Alexandre Courbot wrote:
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
Thanks. I forwarded this to the arm-soc maintainers as a patch for 3.13.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-12 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-12 6:36 [PATCH] ARM: tegra: init fuse before setting reset handler Alexandre Courbot
2013-11-12 20:04 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).