* [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config
@ 2013-11-24 10:41 Austin Boyle
2013-11-25 0:40 ` jonghwa3.lee
0 siblings, 1 reply; 3+ messages in thread
From: Austin Boyle @ 2013-11-24 10:41 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linux-pm, linux-kernel, Jonghwa Lee, Myungjoo Ham
max17042 now uses regmap interface but does not enable config option. This patch fixes the following build errors:
drivers/power/max17042_battery.c:661:15: error: variable ‘max17042_regmap_config’ has initializer but incomplete type
drivers/power/max17042_battery.c:662:2: error: unknown field ‘reg_bits’ specified in initializer
drivers/power/max17042_battery.c:662:2: warning: excess elements in struct initializer
drivers/power/max17042_battery.c:662:2: warning: (near initialization for ‘max17042_regmap_config’)
drivers/power/max17042_battery.c:663:2: error: unknown field ‘val_bits’ specified in initializer
drivers/power/max17042_battery.c:663:2: warning: excess elements in struct initializer
drivers/power/max17042_battery.c:663:2: warning: (near initialization for ‘max17042_regmap_config’)
drivers/power/max17042_battery.c:664:2: error: unknown field ‘val_format_endian’ specified in initializer
drivers/power/max17042_battery.c:664:23: error: ‘REGMAP_ENDIAN_NATIVE’ undeclared here (not in a function)
drivers/power/max17042_battery.c:664:2: warning: excess elements in struct initializer
drivers/power/max17042_battery.c:664:2: warning: (near initialization for ‘max17042_regmap_config’)
drivers/power/max17042_battery.c: In function ‘max17042_probe’:
drivers/power/max17042_battery.c:684:2: error: implicit declaration of function ‘devm_regmap_init_i2c’
Signed-off-by: Austin Boyle <boyle.austin@gmail.com>
---
diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 5e2054a..85ad58c 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -196,6 +196,7 @@ config BATTERY_MAX17040
config BATTERY_MAX17042
tristate "Maxim MAX17042/17047/17050/8997/8966 Fuel Gauge"
depends on I2C
+ select REGMAP_I2C
help
MAX17042 is fuel-gauge systems for lithium-ion (Li+) batteries
in handheld and portable equipment. The MAX17042 is configured
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config
2013-11-24 10:41 [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config Austin Boyle
@ 2013-11-25 0:40 ` jonghwa3.lee
2013-12-01 22:26 ` Anton Vorontsov
0 siblings, 1 reply; 3+ messages in thread
From: jonghwa3.lee @ 2013-11-25 0:40 UTC (permalink / raw)
To: Austin Boyle; +Cc: Anton Vorontsov, linux-pm, linux-kernel, Myungjoo Ham
On 2013년 11월 24일 19:41, Austin Boyle wrote:
> max17042 now uses regmap interface but does not enable config option. This patch fixes the following build errors:
>
> drivers/power/max17042_battery.c:661:15: error: variable ‘max17042_regmap_config’ has initializer but incomplete type
> drivers/power/max17042_battery.c:662:2: error: unknown field ‘reg_bits’ specified in initializer
> drivers/power/max17042_battery.c:662:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:662:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c:663:2: error: unknown field ‘val_bits’ specified in initializer
> drivers/power/max17042_battery.c:663:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:663:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c:664:2: error: unknown field ‘val_format_endian’ specified in initializer
> drivers/power/max17042_battery.c:664:23: error: ‘REGMAP_ENDIAN_NATIVE’ undeclared here (not in a function)
> drivers/power/max17042_battery.c:664:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:664:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c: In function ‘max17042_probe’:
> drivers/power/max17042_battery.c:684:2: error: implicit declaration of function ‘devm_regmap_init_i2c’
>
> Signed-off-by: Austin Boyle <boyle.austin@gmail.com>
> ---
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 5e2054a..85ad58c 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -196,6 +196,7 @@ config BATTERY_MAX17040
> config BATTERY_MAX17042
> tristate "Maxim MAX17042/17047/17050/8997/8966 Fuel Gauge"
> depends on I2C
> + select REGMAP_I2C
> help
> MAX17042 is fuel-gauge systems for lithium-ion (Li+) batteries
> in handheld and portable equipment. The MAX17042 is configured
>
Sorry, It's my fault. Thanks.
Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config
2013-11-25 0:40 ` jonghwa3.lee
@ 2013-12-01 22:26 ` Anton Vorontsov
0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2013-12-01 22:26 UTC (permalink / raw)
To: jonghwa3.lee; +Cc: Austin Boyle, linux-pm, linux-kernel, Myungjoo Ham
On Mon, Nov 25, 2013 at 09:40:04AM +0900, jonghwa3.lee@samsung.com wrote:
> > max17042 now uses regmap interface but does not enable config option. This patch fixes the following build errors:
> >
> > drivers/power/max17042_battery.c:661:15: error: variable ‘max17042_regmap_config’ has initializer but incomplete type
> >
> > Signed-off-by: Austin Boyle <boyle.austin@gmail.com>
> > ---
> > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> > index 5e2054a..85ad58c 100644
> > --- a/drivers/power/Kconfig
> > +++ b/drivers/power/Kconfig
> > @@ -196,6 +196,7 @@ config BATTERY_MAX17040
> > config BATTERY_MAX17042
> > tristate "Maxim MAX17042/17047/17050/8997/8966 Fuel Gauge"
> > depends on I2C
> > + select REGMAP_I2C
> > help
> > MAX17042 is fuel-gauge systems for lithium-ion (Li+) batteries
> > in handheld and portable equipment. The MAX17042 is configured
>
> Sorry, It's my fault. Thanks.
>
> Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-01 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-24 10:41 [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config Austin Boyle
2013-11-25 0:40 ` jonghwa3.lee
2013-12-01 22:26 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).