* Compile error in i2c-bcm-kona.c
@ 2013-11-25 5:11 Guenter Roeck
2013-11-25 17:06 ` Tim Kryger
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2013-11-25 5:11 UTC (permalink / raw)
To: Wolfram Sang
Cc: Tim Kryger, Matt Porter, Markus Mayer, linux-i2c, linux-kernel
Upstream HEAD, arm allmodconfig:
drivers/i2c/busses/i2c-bcm-kona.c:894:1: error: '__mod_of_device_table' aliased to undefined symbol 'kona_i2c_of_match'
make[3]: *** [drivers/i2c/busses/i2c-bcm-kona.o] Error 1
make[2]: *** [drivers/i2c/busses] Error 2
make[1]: *** [drivers/i2c] Error 2
make[1]: *** Waiting for unfinished jobs....
Source:
static const struct of_device_id bcm_kona_i2c_of_match[] = {
{.compatible = "brcm,kona-i2c",},
{},
};
MODULE_DEVICE_TABLE(of, kona_i2c_of_match);
Makes me wonder how this was tested :-(.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Compile error in i2c-bcm-kona.c
2013-11-25 5:11 Compile error in i2c-bcm-kona.c Guenter Roeck
@ 2013-11-25 17:06 ` Tim Kryger
0 siblings, 0 replies; 2+ messages in thread
From: Tim Kryger @ 2013-11-25 17:06 UTC (permalink / raw)
To: Guenter Roeck
Cc: Wolfram Sang, Matt Porter, Markus Mayer, Linux I2C List, linux-kernel
On Sun, Nov 24, 2013 at 9:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> Upstream HEAD, arm allmodconfig:
>
> drivers/i2c/busses/i2c-bcm-kona.c:894:1: error: '__mod_of_device_table'
> aliased to undefined symbol 'kona_i2c_of_match'
> make[3]: *** [drivers/i2c/busses/i2c-bcm-kona.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> Source:
>
> static const struct of_device_id bcm_kona_i2c_of_match[] = {
> {.compatible = "brcm,kona-i2c",},
> {},
> };
> MODULE_DEVICE_TABLE(of, kona_i2c_of_match);
>
> Makes me wonder how this was tested :-(.
>
> Guenter
The statically linked driver was tested extensively but I forgot to
test it as a module.
Please accept my sincerest apologies for this oversight.
I will prepare, test, and post a fix shortly.
-Tim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-25 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-25 5:11 Compile error in i2c-bcm-kona.c Guenter Roeck
2013-11-25 17:06 ` Tim Kryger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).