From: Kishon Vijay Abraham I <kishon@ti.com>
To: Mohit Kumar <mohit.kumar@st.com>, <arnd@arndb.de>
Cc: Pratyush Anand <pratyush.anand@st.com>, <spear-devel@list.st.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall
Date: Thu, 30 Jan 2014 17:13:37 +0530 [thread overview]
Message-ID: <52EA3AE9.3030000@ti.com> (raw)
In-Reply-To: <6f2dbd4fcb99a070c07b39545d98eca58101daa0.1391077731.git.mohit.kumar@st.com>
Hi,
On Thursday 30 January 2014 04:18 PM, Mohit Kumar wrote:
> From: Pratyush Anand <pratyush.anand@st.com>
>
> PCIe RC drivers are initialized with subsys_initcall. Few PCIe drivers
> like SPEAr13xx needs phy drivers to be initialized.
Instead change PCIe RC drivers to module init. Phy drivers should be loaded
very early otherwise. (Hint: drivers/Makefile).
Thanks
Kishon
>
> Therefore initialize phy core driver with subsys_initcall to avoid
> calling of phy_get before phy_class is created.
>
> Signed-off-by: Pratyush Anand <pratyush.anand@st.com>
> Cc: Mohit Kumar <mohit.kumar@st.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: spear-devel@list.st.com
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/phy/phy-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index 03cf8fb..fa73101 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -685,7 +685,7 @@ static int __init phy_core_init(void)
>
> return 0;
> }
> -module_init(phy_core_init);
> +subsys_initcall(phy_core_init);
>
> static void __exit phy_core_exit(void)
> {
>
next prev parent reply other threads:[~2014-01-30 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1391077731.git.mohit.kumar@st.com>
2014-01-30 10:48 ` [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall Mohit Kumar
2014-01-30 11:43 ` Kishon Vijay Abraham I [this message]
2014-01-30 11:52 ` Pratyush Anand
2014-01-30 12:10 ` Kishon Vijay Abraham I
2014-01-30 12:15 ` Pratyush Anand
2014-01-30 12:25 ` Kishon Vijay Abraham I
2014-01-30 12:44 ` Arnd Bergmann
2014-01-31 3:48 ` Pratyush Anand
2014-01-31 15:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA3AE9.3030000@ti.com \
--to=kishon@ti.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mohit.kumar@st.com \
--cc=pratyush.anand@st.com \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).