From: Kishon Vijay Abraham I <kishon@ti.com>
To: Pratyush Anand <pratyush.anand@st.com>
Cc: Mohit KUMAR DCG <Mohit.KUMAR@st.com>,
"arnd@arndb.de" <arnd@arndb.de>,
spear-devel <spear-devel@list.st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall
Date: Thu, 30 Jan 2014 17:40:23 +0530 [thread overview]
Message-ID: <52EA412F.7070005@ti.com> (raw)
In-Reply-To: <20140130115212.GA1171@pratyush-vbox>
Hi,
On Thursday 30 January 2014 05:22 PM, Pratyush Anand wrote:
> On Thu, Jan 30, 2014 at 07:43:37PM +0800, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 30 January 2014 04:18 PM, Mohit Kumar wrote:
>>> From: Pratyush Anand <pratyush.anand@st.com>
>>>
>>> PCIe RC drivers are initialized with subsys_initcall. Few PCIe drivers
>>> like SPEAr13xx needs phy drivers to be initialized.
>>
>> Instead change PCIe RC drivers to module init. Phy drivers should be loaded
>> very early otherwise. (Hint: drivers/Makefile).
>
> I think PCIe RC driver can not be made module init. Bjorn can comment
> better.
Why not? I have used it for DRA7xx without any issues (I'll send that one
upstream once the PIPE3 phy part gets clear).
>
> All PCIe card drivers are initialized with module init. RC driver must
> have been initialized before any card driver initialization.
> Currently, card drivers does not have deferred probe concept, so I am
> not sure if keeping RC driver as module init will work always.
the card drivers will anyway be probed only after RC driver comes up no?
>
> By the way, is there any side effect of loading phy driver very early?
I assume you meant 'is there any side effect of using subsys_initcall?', since
phy driver is loaded early anyway.
The answer is no just that module_init is common one and more people prefer to
use module_init. (btw initial versions of phy-core had susbsys_initcall before
it got changed to use module_init)
Thanks
Kishon
next prev parent reply other threads:[~2014-01-30 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1391077731.git.mohit.kumar@st.com>
2014-01-30 10:48 ` [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall Mohit Kumar
2014-01-30 11:43 ` Kishon Vijay Abraham I
2014-01-30 11:52 ` Pratyush Anand
2014-01-30 12:10 ` Kishon Vijay Abraham I [this message]
2014-01-30 12:15 ` Pratyush Anand
2014-01-30 12:25 ` Kishon Vijay Abraham I
2014-01-30 12:44 ` Arnd Bergmann
2014-01-31 3:48 ` Pratyush Anand
2014-01-31 15:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA412F.7070005@ti.com \
--to=kishon@ti.com \
--cc=Mohit.KUMAR@st.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).