From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Andreas Larsson <andreas@gaisler.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] can: sja1000: cleanups and new OF property
Date: Fri, 31 Jan 2014 15:08:53 +0100 [thread overview]
Message-ID: <52EBAE75.6050803@epfl.ch> (raw)
In-Reply-To: <52EBAA28.1070307@gaisler.com>
On 01/31/2014 02:50 PM, Andreas Larsson wrote:
> On 2014-01-31 14:40, Marc Kleine-Budde wrote:
>> On 01/31/2014 02:34 PM, Florian Vaussard wrote:
>>> Hello,
>>>
>>> (could someone with a SJA1000 on SPARC perform a functional test
>>> to see if interrupts are working? it would be great :-)
>>>
>>> Changes since v2:
>>> - Dropped patch 1 "can: sja1000: remove unused defines"
>>> - Addressed Marc's comments on patch 4 and 6 (now 3 and 5)
>>>
>>> Changes since v1:
>>> - Merge sja1000_of_platform.c into sja1000_platform.c (patch 4)
>>>
>>> The first part of this series performs serveral small cleanups
>>> (patches 1 and 2).
>>>
>>> Patch 3 merges sja1000_of_platform.c into sja1000_platform.c.
>>> Changes are pretty conservatives (mostly copy/paste/move). IRQ
>>> is treated differently in the OF and non-OF versions, thus this
>>> is where the fused version differs the most.
>>>
>>> The final part introduces the 'reg-io-width' binding (already used
>>> by some other drivers) to perform a similar job as what was done
>>> with IORESOURCE_MEM_XXBIT. This is needed on my system to correctly
>>> take into account the aliasing of the address bus.
>>>
>>> All patches were tested using OF boot on my OMAP3 system with a
>>> memory-mapped SJA1000. Thus, the non-OF path is not tested, as
>>> I do not have a platform data at hand.
>>
>> Nice, looks good now. I'll give Andreas some time to test on sparc and
>> then apply the patches.
>
>
> I am on it. I will dig up some hardware for this on Monday to test it.
>
Many thanks :o)
(be careful to enable CAN_SJA1000_PLATFORM, as I removed
CAN_SJA1000_PLATFORM_OF)
Regards,
Florian
next prev parent reply other threads:[~2014-01-31 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 13:34 [PATCH v3 0/5] can: sja1000: cleanups and new OF property Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 1/5] can: sja1000: convert printk to use netdev API Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 2/5] can: sja1000: platform: use devm_* APIs Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 3/5] can: sja1000: fuse of_platform into platform Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 4/5] Documentation: devicetree: sja1000: add reg-io-width binding Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access Florian Vaussard
2014-01-31 14:08 ` Sergei Shtylyov
2014-02-06 10:57 ` Marc Kleine-Budde
2014-02-06 14:21 ` Florian Vaussard
2014-01-31 13:40 ` [PATCH v3 0/5] can: sja1000: cleanups and new OF property Marc Kleine-Budde
2014-01-31 13:50 ` Andreas Larsson
2014-01-31 13:51 ` Marc Kleine-Budde
2014-01-31 14:08 ` Florian Vaussard [this message]
2014-02-04 8:19 ` Andreas Larsson
2014-02-04 8:28 ` Marc Kleine-Budde
2014-02-04 12:13 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBAE75.6050803@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=andreas@gaisler.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).