From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Florian Vaussard <florian.vaussard@epfl.ch>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: Andreas Larsson <andreas@gaisler.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access
Date: Thu, 06 Feb 2014 11:57:46 +0100 [thread overview]
Message-ID: <52F36AAA.9000704@pengutronix.de> (raw)
In-Reply-To: <52EBAE41.8060403@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On 01/31/2014 03:08 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 31-01-2014 17:34, Florian Vaussard wrote:
>
>> Add the 'reg-io-width' property for 8, 16 and 32-bit access, like
>> what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF
>> boot.
>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>> drivers/net/can/sja1000/sja1000_platform.c | 16 ++++++++++++++--
>> 1 file changed, 14 insertions(+), 2 deletions(-)
>
>> diff --git a/drivers/net/can/sja1000/sja1000_platform.c
>> b/drivers/net/can/sja1000/sja1000_platform.c
>> index 50dece8..25122bf 100644
>> --- a/drivers/net/can/sja1000/sja1000_platform.c
>> +++ b/drivers/net/can/sja1000/sja1000_platform.c
>> @@ -102,8 +102,20 @@ static void sp_populate_of(struct sja1000_priv
>> *priv, struct device_node *of)
>> int err;
>> u32 prop;
>>
>> - priv->read_reg = sp_read_reg8;
>> - priv->write_reg = sp_write_reg8;
>> + err = of_property_read_u32(of, "reg-io-width", &prop);
>> + if (err)
>> + prop = 1;
>> +
>> + if (prop == 4) {
>
> This is asking to be a *switch* statement instead.
Good point, I'll send a v4.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-02-06 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 13:34 [PATCH v3 0/5] can: sja1000: cleanups and new OF property Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 1/5] can: sja1000: convert printk to use netdev API Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 2/5] can: sja1000: platform: use devm_* APIs Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 3/5] can: sja1000: fuse of_platform into platform Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 4/5] Documentation: devicetree: sja1000: add reg-io-width binding Florian Vaussard
2014-01-31 13:34 ` [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access Florian Vaussard
2014-01-31 14:08 ` Sergei Shtylyov
2014-02-06 10:57 ` Marc Kleine-Budde [this message]
2014-02-06 14:21 ` Florian Vaussard
2014-01-31 13:40 ` [PATCH v3 0/5] can: sja1000: cleanups and new OF property Marc Kleine-Budde
2014-01-31 13:50 ` Andreas Larsson
2014-01-31 13:51 ` Marc Kleine-Budde
2014-01-31 14:08 ` Florian Vaussard
2014-02-04 8:19 ` Andreas Larsson
2014-02-04 8:28 ` Marc Kleine-Budde
2014-02-04 12:13 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F36AAA.9000704@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andreas@gaisler.com \
--cc=florian.vaussard@epfl.ch \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sparclinux@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).