* [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
@ 2014-02-05 9:04 Nishanth Menon
2014-02-13 23:13 ` Tony Lindgren
2014-02-20 3:04 ` Paul Walmsley
0 siblings, 2 replies; 4+ messages in thread
From: Nishanth Menon @ 2014-02-05 9:04 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, linux-arm-kernel, linux-kernel, Tero Kristo, Nishanth Menon
omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
for every call that takes place. This is an can be done only if a change
is detected.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/dpll3xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
index 3185ced..d9bcbf7 100644
--- a/arch/arm/mach-omap2/dpll3xxx.c
+++ b/arch/arm/mach-omap2/dpll3xxx.c
@@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
* stuff is inherited for free
*/
- if (!ret)
+ if (!ret && clk_get_parent(hw->clk) != new_parent)
__clk_reparent(hw->clk, new_parent);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
2014-02-05 9:04 [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done Nishanth Menon
@ 2014-02-13 23:13 ` Tony Lindgren
2014-02-14 13:13 ` Tero Kristo
2014-02-20 3:04 ` Paul Walmsley
1 sibling, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2014-02-13 23:13 UTC (permalink / raw)
To: Nishanth Menon
Cc: linux-omap, linux-arm-kernel, linux-kernel, Tero Kristo, Paul Walmsley
* Nishanth Menon <nm@ti.com> [140205 01:06]:
> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
> for every call that takes place. This is an can be done only if a change
> is detected.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Would like to see acks on this too before applying.
Tony
> ---
> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
> index 3185ced..d9bcbf7 100644
> --- a/arch/arm/mach-omap2/dpll3xxx.c
> +++ b/arch/arm/mach-omap2/dpll3xxx.c
> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
> * stuff is inherited for free
> */
>
> - if (!ret)
> + if (!ret && clk_get_parent(hw->clk) != new_parent)
> __clk_reparent(hw->clk, new_parent);
>
> return 0;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
2014-02-13 23:13 ` Tony Lindgren
@ 2014-02-14 13:13 ` Tero Kristo
0 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2014-02-14 13:13 UTC (permalink / raw)
To: Tony Lindgren, Nishanth Menon
Cc: linux-omap, linux-arm-kernel, linux-kernel, Paul Walmsley
On 02/14/2014 01:13 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140205 01:06]:
>> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
>> for every call that takes place. This is an can be done only if a change
>> is detected.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Would like to see acks on this too before applying.
Looks good to me, ack.
-Tero
>
> Tony
>
>> ---
>> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
>> index 3185ced..d9bcbf7 100644
>> --- a/arch/arm/mach-omap2/dpll3xxx.c
>> +++ b/arch/arm/mach-omap2/dpll3xxx.c
>> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
>> * stuff is inherited for free
>> */
>>
>> - if (!ret)
>> + if (!ret && clk_get_parent(hw->clk) != new_parent)
>> __clk_reparent(hw->clk, new_parent);
>>
>> return 0;
>> --
>> 1.7.9.5
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
2014-02-05 9:04 [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done Nishanth Menon
2014-02-13 23:13 ` Tony Lindgren
@ 2014-02-20 3:04 ` Paul Walmsley
1 sibling, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2014-02-20 3:04 UTC (permalink / raw)
To: Nishanth Menon
Cc: Tony Lindgren, linux-omap, linux-arm-kernel, linux-kernel, Tero Kristo
On Wed, 5 Feb 2014, Nishanth Menon wrote:
> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
> for every call that takes place. This is an can be done only if a change
> is detected.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Queued for v3.15 with Tero's ack unless the patch is updated to indicate
that it's more than an optimization.
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-20 3:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-05 9:04 [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done Nishanth Menon
2014-02-13 23:13 ` Tony Lindgren
2014-02-14 13:13 ` Tero Kristo
2014-02-20 3:04 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).