From: Egil Hjelmeland <privat@egil-hjelmeland.no>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Joe Perches <joe@perches.com>,
andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses
Date: Mon, 6 Nov 2017 13:35:41 +0100 [thread overview]
Message-ID: <52b70a27-7966-7dac-147c-6046befcd3c1@egil-hjelmeland.no> (raw)
In-Reply-To: <878tfnct0u.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 03. nov. 2017 15:54, Vivien Didelot wrote:
> Hi Egil,
>
> Egil Hjelmeland <privat@egil-hjelmeland.no> writes:
>
> If you send a v2, you may want to address the other parenthesis
> alignment issues found when running ./scripts/checkpatch -f on the
> lan9303* files.
>
There is just one remaining alignment issue. Removing that would
require introducing an extra variable just for that purpose. I
don't think that makes the code more readable. So I will not do it.
If anybody else want to do it, fine, I will just watch in silence.
> Applying this gives you a few more: https://patchwork.kernel.org/patch/10014913/
>
> (you can also add my Reviewed-by tag on patches you didn't touch.)
>
>
> Thanks,
>
> Vivien
>
Egil
next prev parent reply other threads:[~2017-11-06 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 10:55 [PATCH net-next 0/5] net: dsa: lan9303: Linting Egil Hjelmeland
2017-11-03 10:55 ` [PATCH net-next 1/5] net: dsa: lan9303: Correct register names in comments Egil Hjelmeland
2017-11-03 10:55 ` [PATCH net-next 2/5] net: dsa: lan9303: Fix syntax errors in device tree examples Egil Hjelmeland
2017-11-03 10:55 ` [PATCH net-next 3/5] net: dsa: lan9303: Replace msleep(1) with usleep_range() Egil Hjelmeland
2017-11-03 10:55 ` [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses Egil Hjelmeland
2017-11-03 14:11 ` Joe Perches
2017-11-03 14:35 ` Egil Hjelmeland
2017-11-03 14:54 ` Vivien Didelot
2017-11-06 12:35 ` Egil Hjelmeland [this message]
2017-11-06 9:46 ` Egil Hjelmeland
2017-11-03 10:55 ` [PATCH net-next 5/5] net: dsa: lan9303: Adjust indenting Egil Hjelmeland
2017-11-03 13:55 ` [PATCH net-next 0/5] net: dsa: lan9303: Linting Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52b70a27-7966-7dac-147c-6046befcd3c1@egil-hjelmeland.no \
--to=privat@egil-hjelmeland.no \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).