* [PATCH v2 34/35] sound/soc/codecs: Use kmemdup rather than duplicating its implementation
@ 2019-07-03 16:32 Fuqian Huang
2019-07-04 11:47 ` Richard Fitzgerald
0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-07-03 16:32 UTC (permalink / raw)
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
patches, alsa-devel, linux-kernel, Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
Acked-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
Changes in v2:
- Fix a typo in commit message (memset -> memcpy)
- Split into two patches
sound/soc/codecs/wm0010.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 727d6703c905..807826f30f58 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -515,7 +515,7 @@ static int wm0010_stage2_load(struct snd_soc_component *component)
dev_dbg(component->dev, "Downloading %zu byte stage 2 loader\n", fw->size);
/* Copy to local buffer first as vmalloc causes problems for dma */
- img = kzalloc(fw->size, GFP_KERNEL | GFP_DMA);
+ img = kmemdup(&fw->data[0], fw->size, GFP_KERNEL | GFP_DMA);
if (!img) {
ret = -ENOMEM;
goto abort2;
@@ -527,8 +527,6 @@ static int wm0010_stage2_load(struct snd_soc_component *component)
goto abort1;
}
- memcpy(img, &fw->data[0], fw->size);
-
spi_message_init(&m);
memset(&t, 0, sizeof(t));
t.rx_buf = out;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 34/35] sound/soc/codecs: Use kmemdup rather than duplicating its implementation
2019-07-03 16:32 [PATCH v2 34/35] sound/soc/codecs: Use kmemdup rather than duplicating its implementation Fuqian Huang
@ 2019-07-04 11:47 ` Richard Fitzgerald
0 siblings, 0 replies; 2+ messages in thread
From: Richard Fitzgerald @ 2019-07-04 11:47 UTC (permalink / raw)
To: Fuqian Huang
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
patches, alsa-devel, linux-kernel
Commit message title prefix should be "ASoC: wm0010:" not "sound/soc
/codecs:". Take a look at other patches to the same files.
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
>
> Acked-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> Changes in v2:
> - Fix a typo in commit message (memset -> memcpy)
> - Split into two patches
>
> sound/soc/codecs/wm0010.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
> index 727d6703c905..807826f30f58 100644
> --- a/sound/soc/codecs/wm0010.c
> +++ b/sound/soc/codecs/wm0010.c
> @@ -515,7 +515,7 @@ static int wm0010_stage2_load(struct snd_soc_component *component)
> dev_dbg(component->dev, "Downloading %zu byte stage 2 loader\n", fw->size);
>
> /* Copy to local buffer first as vmalloc causes problems for dma */
> - img = kzalloc(fw->size, GFP_KERNEL | GFP_DMA);
> + img = kmemdup(&fw->data[0], fw->size, GFP_KERNEL | GFP_DMA);
> if (!img) {
> ret = -ENOMEM;
> goto abort2;
> @@ -527,8 +527,6 @@ static int wm0010_stage2_load(struct snd_soc_component *component)
> goto abort1;
> }
>
> - memcpy(img, &fw->data[0], fw->size);
> -
> spi_message_init(&m);
> memset(&t, 0, sizeof(t));
> t.rx_buf = out;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-04 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-03 16:32 [PATCH v2 34/35] sound/soc/codecs: Use kmemdup rather than duplicating its implementation Fuqian Huang
2019-07-04 11:47 ` Richard Fitzgerald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).