* [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using.
@ 2014-02-01 12:35 Chen Gang
2014-02-01 12:56 ` Richard Weinberger
2014-02-17 9:50 ` Hans-Christian Egtvedt
0 siblings, 2 replies; 5+ messages in thread
From: Chen Gang @ 2014-02-01 12:35 UTC (permalink / raw)
To: hskinnemoen, egtvedt; +Cc: linux-kernel
For avr32 cross compiler, do not define '__linux__' internally, so it
will cause issue with allmodconfig.
The related error:
CC [M] fs/coda/psdev.o
In file included from include/linux/coda.h:64,
from fs/coda/psdev.c:45:
include/uapi/linux/coda.h:221: error: expected specifier-qualifier-list before 'u_quad_t'
The related toolchain version (which only download, not re-compile):
[root@gchen linux-next]# /upstream/toolchain/download/avr32-gnu-toolchain-linux_x86/bin/avr32-gcc -v
Using built-in specs.
Target: avr32
Configured with: /data2/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/src/gcc/configure --target=avr32 --host=i686-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-languages=c,c++ --disable-nls --disable-libssp --disable-libstdcxx-pch --with-dwarf2 --enable-version-specific-runtime-libs --disable-shared --enable-doc --with-mpfr-lib=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/lib --with-mpfr-include=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/include --with-gmp=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --with-mpc=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-__cxa_atexit --disable-shared --with-newlib --with-pkgversion=AVR_32_bit_GNU_Toolchain_3.4.2_435 --with-bugurl=http://www
.atmel.com/avr
Thread model: single
gcc version 4.4.7 (AVR_32_bit_GNU_Toolchain_3.4.2_435)
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/avr32/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/Makefile b/arch/avr32/Makefile
index 22fb665..dba48a5 100644
--- a/arch/avr32/Makefile
+++ b/arch/avr32/Makefile
@@ -11,7 +11,7 @@ all: uImage vmlinux.elf
KBUILD_DEFCONFIG := atstk1002_defconfig
-KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic
+KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic -D__linux__
KBUILD_AFLAGS += -mrelax -mno-pic
KBUILD_CFLAGS_MODULE += -mno-relax
LDFLAGS_vmlinux += --relax
--
1.7.11.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using. 2014-02-01 12:35 [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using Chen Gang @ 2014-02-01 12:56 ` Richard Weinberger 2014-02-01 13:46 ` Chen Gang 2014-02-17 9:50 ` Hans-Christian Egtvedt 1 sibling, 1 reply; 5+ messages in thread From: Richard Weinberger @ 2014-02-01 12:56 UTC (permalink / raw) To: Chen Gang; +Cc: hskinnemoen, egtvedt, linux-kernel On Sat, Feb 1, 2014 at 1:35 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > For avr32 cross compiler, do not define '__linux__' internally, so it > will cause issue with allmodconfig. Isn't this a toolchain bug? > The related error: > > CC [M] fs/coda/psdev.o > In file included from include/linux/coda.h:64, > from fs/coda/psdev.c:45: > include/uapi/linux/coda.h:221: error: expected specifier-qualifier-list before 'u_quad_t' > > The related toolchain version (which only download, not re-compile): > > [root@gchen linux-next]# /upstream/toolchain/download/avr32-gnu-toolchain-linux_x86/bin/avr32-gcc -v > Using built-in specs. > Target: avr32 > Configured with: /data2/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/src/gcc/configure --target=avr32 --host=i686-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-languages=c,c++ --disable-nls --disable-libssp --disable-libstdcxx-pch --with-dwarf2 --enable-version-specific-runtime-libs --disable-shared --enable-doc --with-mpfr-lib=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/lib --with-mpfr-include=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/include --with-gmp=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --with-mpc=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-__cxa_atexit --disable-shared --with-newlib --with-pkgversion=AVR_32_bit_GNU_Toolchain_3.4.2_435 --with-bugurl=http://www > .atmel.com/avr > Thread model: single > gcc version 4.4.7 (AVR_32_bit_GNU_Toolchain_3.4.2_435) > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/avr32/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/avr32/Makefile b/arch/avr32/Makefile > index 22fb665..dba48a5 100644 > --- a/arch/avr32/Makefile > +++ b/arch/avr32/Makefile > @@ -11,7 +11,7 @@ all: uImage vmlinux.elf > > KBUILD_DEFCONFIG := atstk1002_defconfig > > -KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic > +KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic -D__linux__ > KBUILD_AFLAGS += -mrelax -mno-pic > KBUILD_CFLAGS_MODULE += -mno-relax > LDFLAGS_vmlinux += --relax > -- > 1.7.11.7 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thanks, //richard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using. 2014-02-01 12:56 ` Richard Weinberger @ 2014-02-01 13:46 ` Chen Gang 2014-02-16 11:40 ` Chen Gang 0 siblings, 1 reply; 5+ messages in thread From: Chen Gang @ 2014-02-01 13:46 UTC (permalink / raw) To: Richard Weinberger; +Cc: hskinnemoen, egtvedt, linux-kernel On 02/01/2014 08:56 PM, Richard Weinberger wrote: > On Sat, Feb 1, 2014 at 1:35 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> For avr32 cross compiler, do not define '__linux__' internally, so it >> will cause issue with allmodconfig. > > Isn't this a toolchain bug? Hmm... for me, it is not toolchain's bug, it is a feature issue in gcc old version, and in newer version it is OK (in my memory, after gcc-4.7, it is OK). In our "arch/*", really contents some another architectures which already use "-D__linux__" in their "Makefile". :-) Thanks. > >> The related error: >> >> CC [M] fs/coda/psdev.o >> In file included from include/linux/coda.h:64, >> from fs/coda/psdev.c:45: >> include/uapi/linux/coda.h:221: error: expected specifier-qualifier-list before 'u_quad_t' >> >> The related toolchain version (which only download, not re-compile): >> >> [root@gchen linux-next]# /upstream/toolchain/download/avr32-gnu-toolchain-linux_x86/bin/avr32-gcc -v >> Using built-in specs. >> Target: avr32 >> Configured with: /data2/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/src/gcc/configure --target=avr32 --host=i686-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-languages=c,c++ --disable-nls --disable-libssp --disable-libstdcxx-pch --with-dwarf2 --enable-version-specific-runtime-libs --disable-shared --enable-doc --with-mpfr-lib=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/lib --with-mpfr-include=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/include --with-gmp=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --with-mpc=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-__cxa_atexit --disable-shared --with-newlib --with-pkgversion=AVR_32_bit_GNU_Toolchain_3.4.2_435 --with-bugurl=http:// www >> .atmel.com/avr >> Thread model: single >> gcc version 4.4.7 (AVR_32_bit_GNU_Toolchain_3.4.2_435) >> >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> --- >> arch/avr32/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/avr32/Makefile b/arch/avr32/Makefile >> index 22fb665..dba48a5 100644 >> --- a/arch/avr32/Makefile >> +++ b/arch/avr32/Makefile >> @@ -11,7 +11,7 @@ all: uImage vmlinux.elf >> >> KBUILD_DEFCONFIG := atstk1002_defconfig >> >> -KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic >> +KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic -D__linux__ >> KBUILD_AFLAGS += -mrelax -mno-pic >> KBUILD_CFLAGS_MODULE += -mno-relax >> LDFLAGS_vmlinux += --relax >> -- >> 1.7.11.7 >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > -- Chen Gang Open, share and attitude like air, water and life which God blessed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using. 2014-02-01 13:46 ` Chen Gang @ 2014-02-16 11:40 ` Chen Gang 0 siblings, 0 replies; 5+ messages in thread From: Chen Gang @ 2014-02-16 11:40 UTC (permalink / raw) To: Richard Weinberger; +Cc: hskinnemoen, egtvedt, linux-kernel Hello Maintainers: Please help check this patch, when you have free time. Thanks. On 02/01/2014 09:46 PM, Chen Gang wrote: > On 02/01/2014 08:56 PM, Richard Weinberger wrote: >> On Sat, Feb 1, 2014 at 1:35 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >>> For avr32 cross compiler, do not define '__linux__' internally, so it >>> will cause issue with allmodconfig. >> >> Isn't this a toolchain bug? > > Hmm... for me, it is not toolchain's bug, it is a feature issue in gcc > old version, and in newer version it is OK (in my memory, after gcc-4.7, > it is OK). > > In our "arch/*", really contents some another architectures which > already use "-D__linux__" in their "Makefile". :-) > > Thanks. > >> >>> The related error: >>> >>> CC [M] fs/coda/psdev.o >>> In file included from include/linux/coda.h:64, >>> from fs/coda/psdev.c:45: >>> include/uapi/linux/coda.h:221: error: expected specifier-qualifier-list before 'u_quad_t' >>> >>> The related toolchain version (which only download, not re-compile): >>> >>> [root@gchen linux-next]# /upstream/toolchain/download/avr32-gnu-toolchain-linux_x86/bin/avr32-gcc -v >>> Using built-in specs. >>> Target: avr32 >>> Configured with: /data2/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/src/gcc/configure --target=avr32 --host=i686-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-languages=c,c++ --disable-nls --disable-libssp --disable-libstdcxx-pch --with-dwarf2 --enable-version-specific-runtime-libs --disable-shared --enable-doc --with-mpfr-lib=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/lib --with-mpfr-include=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/include --with-gmp=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --with-mpc=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-__cxa_atexit --disable-shared --with-newlib --with-pkgversion=AVR_32_bit_GNU_Toolchain_3.4.2_435 --with-bugurl=http:/ / > www >>> .atmel.com/avr >>> Thread model: single >>> gcc version 4.4.7 (AVR_32_bit_GNU_Toolchain_3.4.2_435) >>> >>> >>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >>> --- >>> arch/avr32/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/avr32/Makefile b/arch/avr32/Makefile >>> index 22fb665..dba48a5 100644 >>> --- a/arch/avr32/Makefile >>> +++ b/arch/avr32/Makefile >>> @@ -11,7 +11,7 @@ all: uImage vmlinux.elf >>> >>> KBUILD_DEFCONFIG := atstk1002_defconfig >>> >>> -KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic >>> +KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic -D__linux__ >>> KBUILD_AFLAGS += -mrelax -mno-pic >>> KBUILD_CFLAGS_MODULE += -mno-relax >>> LDFLAGS_vmlinux += --relax >>> -- >>> 1.7.11.7 >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ >> >> >> > > -- Chen Gang Open, share and attitude like air, water and life which God blessed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using. 2014-02-01 12:35 [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using Chen Gang 2014-02-01 12:56 ` Richard Weinberger @ 2014-02-17 9:50 ` Hans-Christian Egtvedt 1 sibling, 0 replies; 5+ messages in thread From: Hans-Christian Egtvedt @ 2014-02-17 9:50 UTC (permalink / raw) To: Chen Gang; +Cc: hskinnemoen, linux-kernel Around Sat 01 Feb 2014 20:35:54 +0800 or thereabout, Chen Gang wrote: > For avr32 cross compiler, do not define '__linux__' internally, so it > will cause issue with allmodconfig. > > The related error: > > CC [M] fs/coda/psdev.o > In file included from include/linux/coda.h:64, > from fs/coda/psdev.c:45: > include/uapi/linux/coda.h:221: error: expected specifier-qualifier-list before 'u_quad_t' > > The related toolchain version (which only download, not re-compile): > > [root@gchen linux-next]# /upstream/toolchain/download/avr32-gnu-toolchain-linux_x86/bin/avr32-gcc -v > Using built-in specs. > Target: avr32 > Configured with: /data2/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/src/gcc/configure --target=avr32 --host=i686-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-languages=c,c++ --disable-nls --disable-libssp --disable-libstdcxx-pch --with-dwarf2 --enable-version-specific-runtime-libs --disable-shared --enable-doc --with-mpfr-lib=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/lib --with-mpfr-include=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/include --with-gmp=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --with-mpc=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-__cxa_atexit --disable-shared --with-newlib --with-pkgversion=AVR_32_bit_GNU_Toolchain_3.4.2_435 --with-bugurl=http://www > .atmel.com/avr > Thread model: single > gcc version 4.4.7 (AVR_32_bit_GNU_Toolchain_3.4.2_435) > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no> I will merge this into the avr32 tree in the for-linus branch. AFAICT this is also suitable for stable, so I'll add the appropriate CC. > --- > arch/avr32/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/avr32/Makefile b/arch/avr32/Makefile > index 22fb665..dba48a5 100644 > --- a/arch/avr32/Makefile > +++ b/arch/avr32/Makefile > @@ -11,7 +11,7 @@ all: uImage vmlinux.elf > > KBUILD_DEFCONFIG := atstk1002_defconfig > > -KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic > +KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic -D__linux__ > KBUILD_AFLAGS += -mrelax -mno-pic > KBUILD_CFLAGS_MODULE += -mno-relax > LDFLAGS_vmlinux += --relax -- mvh Hans-Christian Egtvedt ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-17 9:50 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-02-01 12:35 [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using Chen Gang 2014-02-01 12:56 ` Richard Weinberger 2014-02-01 13:46 ` Chen Gang 2014-02-16 11:40 ` Chen Gang 2014-02-17 9:50 ` Hans-Christian Egtvedt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).