Re: [PATCH] ARM: imx6: add missing put_device() call in imx6q_suspend_init()

Re: [PATCH] ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

> if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a
> corresponding put_device(). Thus add a jump target to fix the exception
> handling for this function implementation.

Do you find a previous update suggestion useful?

ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
https://lore.kernel.org/patchwork/patch/1151158/
https://lkml.org/lkml/2019/11/9/125

Regards,
Markus

Re: [PATCH] ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[yukuai (C)]

On 2020/6/5 3:07, Markus Elfring wrote:
>> if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a
>> corresponding put_device(). Thus add a jump target to fix the exception
>> handling for this function implementation.
> 
> Do you find a previous update suggestion useful?
> 
> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> https://lore.kernel.org/patchwork/patch/1151158/
> https://lkml.org/lkml/2019/11/9/125

Hi, Markus

It is useful indeed. Although I didn't run cocci script, since it can 
produce too many false result which is hard to filter out.

BTW, I see you haver done the work already, I guess I won't send any 
patches related to 'missing put_device after of_find_device_by_node()'. 
Any idea why these pathes didn't get applied ?

Best regards,
Yu Kuai

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

>> Do you find a previous update suggestion useful?
>>
>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
>> https://lore.kernel.org/patchwork/patch/1151158/
>> https://lkml.org/lkml/2019/11/9/125
…
> It is useful indeed.

Thanks for your positive feedback.


> Although I didn't run cocci script, since it can produce too many false result
> which is hard to filter out.

Would you like to clarify any corresponding software analysis options?


> BTW, I see you haver done the work already, I guess I won't send any patches
> related to 'missing put_device after of_find_device_by_node()'.

You may continue also with contributions in such a direction.
I would like to point out that other developers occasionally got into the mood
to improve implementation details in similar ways already.


> Any idea why these pathes didn't get applied ?

I can make assumptions about the reasons for the possibly questionable handling
of such patches.

Regards,
Markus

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Shawn Guo]

On Fri, Jun 05, 2020 at 12:15:32PM +0200, Markus Elfring wrote:
> >> Do you find a previous update suggestion useful?
> >>
> >> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> >> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> >> https://lore.kernel.org/patchwork/patch/1151158/
> >> https://lkml.org/lkml/2019/11/9/125
> …
> > It is useful indeed.
> 
> Thanks for your positive feedback.
> 
> 
> > Although I didn't run cocci script, since it can produce too many false result
> > which is hard to filter out.
> 
> Would you like to clarify any corresponding software analysis options?
> 
> 
> > BTW, I see you haver done the work already, I guess I won't send any patches
> > related to 'missing put_device after of_find_device_by_node()'.
> 
> You may continue also with contributions in such a direction.
> I would like to point out that other developers occasionally got into the mood
> to improve implementation details in similar ways already.
> 
> 
> > Any idea why these pathes didn't get applied ?
> 
> I can make assumptions about the reasons for the possibly questionable handling
> of such patches.

Markus,

Could you resend it to my kernel.org address?

Shawn

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

>>>> Do you find a previous update suggestion useful?
>>>>
>>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
>>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
>>>> https://lore.kernel.org/patchwork/patch/1151158/
>>>> https://lkml.org/lkml/2019/11/9/125
>> …
>>> It is useful indeed.
…
>>> Any idea why these pathes didn't get applied ?
>>
>> I can make assumptions about the reasons for the possibly questionable handling
>> of such patches.
>
> Markus,
>
> Could you resend it to my kernel.org address?

You can get relevant information from the referenced message archive interfaces,
can't you?

Regards,
Markus

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Shawn Guo]

On Tue, Jun 23, 2020 at 09:48:52AM +0200, Markus Elfring wrote:
> >>>> Do you find a previous update suggestion useful?
> >>>>
> >>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> >>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> >>>> https://lore.kernel.org/patchwork/patch/1151158/
> >>>> https://lkml.org/lkml/2019/11/9/125
> >> …
> >>> It is useful indeed.
> …
> >>> Any idea why these pathes didn't get applied ?
> >>
> >> I can make assumptions about the reasons for the possibly questionable handling
> >> of such patches.
> >
> > Markus,
> >
> > Could you resend it to my kernel.org address?
> 
> You can get relevant information from the referenced message archive interfaces,
> can't you?

Well, I'm asking you to resend to make sure the following:

 - Use correct maintainer mailbox address.
 - You still care about the patch.
 - The patch applies to v5.8-rc.

Shawn

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

>>>>>> Do you find a previous update suggestion useful?
>>>>>>
>>>>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
>>>>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
>>>>>> https://lore.kernel.org/patchwork/patch/1151158/
>>>>>> https://lkml.org/lkml/2019/11/9/125
…
>> You can get relevant information from the referenced message archive interfaces,
>> can't you?
>
> Well, I'm asking you to resend to make sure the following:
>
>  - Use correct maintainer mailbox address.

Were the selected message recipients appropriate at 2019-11-09?


>  - You still care about the patch.

Partly, yes.


>  - The patch applies to v5.8-rc.

Would you like to try it out if my proposal is still valid?

Does the change approach by Yu Kuai supersede it?

Regards,
Markus

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Shawn Guo]

On Tue, Jun 23, 2020 at 02:00:09PM +0200, Markus Elfring wrote:
> >>>>>> Do you find a previous update suggestion useful?
> >>>>>>
> >>>>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> >>>>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> >>>>>> https://lore.kernel.org/patchwork/patch/1151158/
> >>>>>> https://lkml.org/lkml/2019/11/9/125
> …
> >> You can get relevant information from the referenced message archive interfaces,
> >> can't you?
> >
> > Well, I'm asking you to resend to make sure the following:
> >
> >  - Use correct maintainer mailbox address.
> 
> Were the selected message recipients appropriate at 2019-11-09?

At least, my mailbox was not.

> 
> 
> >  - You still care about the patch.
> 
> Partly, yes.
> 
> 
> >  - The patch applies to v5.8-rc.
> 
> Would you like to try it out if my proposal is still valid?
> 
> Does the change approach by Yu Kuai supersede it?

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

>>>>>>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
>>>>>>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
>>>>>>>> https://lore.kernel.org/patchwork/patch/1151158/
>>>>>>>> https://lkml.org/lkml/2019/11/9/125
…
>>>  - The patch applies to v5.8-rc.
>>
>> Would you like to try it out if my proposal is still valid?

Are you going to compare the published patches any further?


>> Does the change approach by Yu Kuai supersede it?

Which patch variant will be integrated finally?

Regards,
Markus

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Shawn Guo]

On Tue, Jun 23, 2020 at 8:29 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> >>>>>>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> >>>>>>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> >>>>>>>> https://lore.kernel.org/patchwork/patch/1151158/
> >>>>>>>> https://lkml.org/lkml/2019/11/9/125
> …
> >>>  - The patch applies to v5.8-rc.
> >>
> >> Would you like to try it out if my proposal is still valid?
>
> Are you going to compare the published patches any further?
>
>
> >> Does the change approach by Yu Kuai supersede it?
>
> Which patch variant will be integrated finally?

Just picked up Yu Kuai's patch.

Shawn

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

>>>>>>>>>> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
>>>>>>>>>> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
>>>>>>>>>> https://lore.kernel.org/patchwork/patch/1151158/
>>>>>>>>>> https://lkml.org/lkml/2019/11/9/125
…
>> Are you going to compare the published patches any further?
>>
>>
>>>> Does the change approach by Yu Kuai supersede it?
>>
>> Which patch variant will be integrated finally?
>
> Just picked up Yu Kuai's patch.

Did you adjust any details?
https://lkml.org/lkml/2020/6/23/542
https://lore.kernel.org/patchwork/comment/1457270/

With which delay will a corresponding commit be published?
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/arch/arm/mach-imx/pm-imx6.c

Regards,
Markus

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

[Markus Elfring]

>> Are you going to compare the published patches any further?
…
>> Which patch variant will be integrated finally?
>
> Just picked up Yu Kuai's patch.

Is it interesting anyhow that you committed a change description
which contained a typo (on 2020-06-23 20:11:30 +0800)?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm/mach-imx/pm-imx6.c?id=0f92519843a05e97b58c6076edb23d747e8be262

Would it have been helpful to add the tag “Fixes”?

Regards,
Markus