From: Hans de Goede <hdegoede@redhat.com>
To: Jithu Joseph <jithu.joseph@intel.com>, markgross@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
gregkh@linuxfoundation.org, ashok.raj@intel.com,
tony.luck@intel.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, patches@lists.linux.dev,
ravi.v.shankar@intel.com, thiago.macieira@intel.com,
athenas.jimenez.gonzalez@intel.com, sohil.mehta@intel.com
Subject: Re: [PATCH v2 09/14] platform/x86/intel/ifs: Use generic microcode headers and functions
Date: Thu, 10 Nov 2022 22:11:56 +0100 [thread overview]
Message-ID: <53080422-a1de-0e44-7725-5cb69d1e23cc@redhat.com> (raw)
In-Reply-To: <20221107225323.2733518-10-jithu.joseph@intel.com>
Hi all,
On 11/7/22 23:53, Jithu Joseph wrote:
> Existing implementation (broken) of IFS used a header format (for IFS
> test images) which was very similar to microcode format, but didn’t
> accommodate extended signatures. This meant same IFS test image had to
> be duplicated for different steppings and the validation code in the
> driver was only looking at the primary header parameters. Going forward
> IFS test image headers has been tweaked to become fully compatible with
> microcode format.
>
> Newer IFS test image headers will use microcode_header_intel->hdrver = 2,
> so as to distinguish it from microcode images and older IFS test images.
>
> In light of the above, use struct microcode_header_intel directly in
> IFS driver instead of duplicating into a separate ifs_header structure.
> Further use existing microcode_sanity_check() and find_matching_signature()
> directly instead of implementing separate ones within the driver.
>
> More IFS specific checks will be added subsequently.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> arch/x86/include/asm/microcode_intel.h | 1 +
> drivers/platform/x86/intel/ifs/load.c | 102 +++++--------------------
> 2 files changed, 20 insertions(+), 83 deletions(-)
>
> diff --git a/arch/x86/include/asm/microcode_intel.h b/arch/x86/include/asm/microcode_intel.h
> index 0ff4545f72d2..f905238748fc 100644
> --- a/arch/x86/include/asm/microcode_intel.h
> +++ b/arch/x86/include/asm/microcode_intel.h
> @@ -43,6 +43,7 @@ struct extended_sigtable {
> #define EXT_HEADER_SIZE (sizeof(struct extended_sigtable))
> #define EXT_SIGNATURE_SIZE (sizeof(struct extended_signature))
> #define MICROCODE_HEADER_VER_UCODE 1
> +#define MICROCODE_HEADER_VER_IFS 2
>
> #define get_totalsize(mc) \
> (((struct microcode_intel *)mc)->hdr.datasize ? \
> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
> index 60ba5a057f91..7c0d8602817b 100644
> --- a/drivers/platform/x86/intel/ifs/load.c
> +++ b/drivers/platform/x86/intel/ifs/load.c
> @@ -8,22 +8,8 @@
>
> #include "ifs.h"
>
> -struct ifs_header {
> - u32 header_ver;
> - u32 blob_revision;
> - u32 date;
> - u32 processor_sig;
> - u32 check_sum;
> - u32 loader_rev;
> - u32 processor_flags;
> - u32 metadata_size;
> - u32 total_size;
> - u32 fusa_info;
> - u64 reserved;
> -};
> -
> -#define IFS_HEADER_SIZE (sizeof(struct ifs_header))
> -static struct ifs_header *ifs_header_ptr; /* pointer to the ifs image header */
> +#define IFS_HEADER_SIZE (sizeof(struct microcode_header_intel))
> +static struct microcode_header_intel *ifs_header_ptr; /* pointer to the ifs image header */
> static u64 ifs_hash_ptr; /* Address of ifs metadata (hash) */
> static u64 ifs_test_image_ptr; /* 256B aligned address of test pattern */
> static DECLARE_COMPLETION(ifs_done);
> @@ -150,33 +136,18 @@ static void copy_hashes_authenticate_chunks(struct work_struct *work)
> */
> static int scan_chunks_sanity_check(struct device *dev)
> {
> - int metadata_size, curr_pkg, cpu, ret = -ENOMEM;
> struct ifs_data *ifsd = ifs_get_data(dev);
> + int curr_pkg, cpu, ret = -ENOMEM;
> bool *package_authenticated;
> struct ifs_work local_work;
> - char *test_ptr;
>
> package_authenticated = kcalloc(topology_max_packages(), sizeof(bool), GFP_KERNEL);
> if (!package_authenticated)
> return ret;
>
> - metadata_size = ifs_header_ptr->metadata_size;
>
> - /* Spec says that if the Meta Data Size = 0 then it should be treated as 2000 */
> - if (metadata_size == 0)
> - metadata_size = 2000;
> -
> - /* Scan chunk start must be 256 byte aligned */
> - if ((metadata_size + IFS_HEADER_SIZE) % 256) {
> - dev_err(dev, "Scan pattern offset within the binary is not 256 byte aligned\n");
> - return -EINVAL;
> - }
> -
> - test_ptr = (char *)ifs_header_ptr + IFS_HEADER_SIZE + metadata_size;
> ifsd->loading_error = false;
> -
> - ifs_test_image_ptr = (u64)test_ptr;
> - ifsd->loaded_version = ifs_header_ptr->blob_revision;
> + ifsd->loaded_version = ifs_header_ptr->rev;
>
> /* copy the scan hash and authenticate per package */
> cpus_read_lock();
> @@ -203,67 +174,33 @@ static int scan_chunks_sanity_check(struct device *dev)
> return ret;
> }
>
> -static int ifs_sanity_check(struct device *dev,
> - const struct microcode_header_intel *mc_header)
> +static int ifs_image_sanity_check(struct device *dev, const struct microcode_header_intel *data)
> {
> - unsigned long total_size, data_size;
> - u32 sum, *mc;
> -
> - total_size = get_totalsize(mc_header);
> - data_size = get_datasize(mc_header);
> + struct ucode_cpu_info uci;
>
> - if ((data_size + MC_HEADER_SIZE > total_size) || (total_size % sizeof(u32))) {
> - dev_err(dev, "bad ifs data file size.\n");
> + /* Provide a specific error message when loading an older/unsupported image */
> + if (data->hdrver != MICROCODE_HEADER_VER_IFS) {
> + dev_err(dev, "Header version %d not supported\n", data->hdrver);
> return -EINVAL;
> }
>
> - if (mc_header->ldrver != 1 || mc_header->hdrver != 1) {
> - dev_err(dev, "invalid/unknown ifs update format.\n");
> + if (intel_microcode_sanity_check((void *)data, true, MICROCODE_HEADER_VER_IFS)) {
> + dev_err(dev, "sanity check failed\n");
> return -EINVAL;
> }
>
> - mc = (u32 *)mc_header;
> - sum = 0;
> - for (int i = 0; i < total_size / sizeof(u32); i++)
> - sum += mc[i];
> + intel_cpu_collect_info(&uci);
>
> - if (sum) {
> - dev_err(dev, "bad ifs data checksum, aborting.\n");
> + if (!intel_find_matching_signature((void *)data,
> + uci.cpu_sig.sig,
> + uci.cpu_sig.pf)) {
> + dev_err(dev, "cpu signature, processor flags not matching\n");
> return -EINVAL;
> }
>
> return 0;
> }
>
> -static bool find_ifs_matching_signature(struct device *dev, struct ucode_cpu_info *uci,
> - const struct microcode_header_intel *shdr)
> -{
> - unsigned int mc_size;
> -
> - mc_size = get_totalsize(shdr);
> -
> - if (!mc_size || ifs_sanity_check(dev, shdr) < 0) {
> - dev_err(dev, "ifs sanity check failure\n");
> - return false;
> - }
> -
> - if (!intel_cpu_signatures_match(uci->cpu_sig.sig, uci->cpu_sig.pf, shdr->sig, shdr->pf)) {
> - dev_err(dev, "ifs signature, pf not matching\n");
> - return false;
> - }
> -
> - return true;
> -}
> -
> -static bool ifs_image_sanity_check(struct device *dev, const struct microcode_header_intel *data)
> -{
> - struct ucode_cpu_info uci;
> -
> - intel_cpu_collect_info(&uci);
> -
> - return find_ifs_matching_signature(dev, &uci, data);
> -}
> -
> /*
> * Load ifs image. Before loading ifs module, the ifs image must be located
> * in /lib/firmware/intel/ifs and named as {family/model/stepping}.{testname}.
> @@ -284,12 +221,11 @@ void ifs_load_firmware(struct device *dev)
> goto done;
> }
>
> - if (!ifs_image_sanity_check(dev, (struct microcode_header_intel *)fw->data)) {
> - dev_err(dev, "ifs header sanity check failed\n");
> + ret = ifs_image_sanity_check(dev, (struct microcode_header_intel *)fw->data);
> + if (ret)
> goto release;
> - }
>
> - ifs_header_ptr = (struct ifs_header *)fw->data;
> + ifs_header_ptr = (struct microcode_header_intel *)fw->data;
> ifs_hash_ptr = (u64)(ifs_header_ptr + 1);
>
> ret = scan_chunks_sanity_check(dev);
next prev parent reply other threads:[~2022-11-10 21:13 UTC|newest]
Thread overview: 193+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 20:33 [PATCH 00/14] IFS multi test image support and misc changes Jithu Joseph
2022-10-21 20:34 ` [PATCH 01/14] platform/x86/intel/ifs: Remove unused selection Jithu Joseph
2022-10-21 20:34 ` [PATCH 02/14] platform/x86/intel/ifs: Propagate load failure error code Jithu Joseph
2022-10-24 22:52 ` Sohil Mehta
2022-10-24 23:17 ` Joseph, Jithu
2022-10-21 20:34 ` [PATCH 03/14] platform/x86/intel/ifs: return a more appropriate Error code Jithu Joseph
2022-10-24 22:57 ` Sohil Mehta
2022-10-24 23:01 ` Luck, Tony
2022-10-21 20:34 ` [PATCH 04/14] platform/x86/intel/ifs: Remove image loading during init Jithu Joseph
2022-10-24 23:50 ` Sohil Mehta
2022-10-25 0:41 ` Joseph, Jithu
2022-10-25 6:06 ` Sohil Mehta
2022-10-26 23:53 ` Joseph, Jithu
2022-11-01 7:00 ` Sohil Mehta
2022-10-21 20:34 ` [PATCH 05/14] x86/microcode/intel: Expose find_matching_signature() for IFS Jithu Joseph
2022-11-02 19:03 ` Borislav Petkov
2022-11-02 21:32 ` Joseph, Jithu
2022-10-21 20:34 ` [PATCH 06/14] x86/microcode/intel: Use appropriate type in microcode_sanity_check() Jithu Joseph
2022-10-21 20:34 ` [PATCH 07/14] x86/microcode/intel: Expose microcode_sanity_check() Jithu Joseph
2022-11-01 7:28 ` Sohil Mehta
2022-11-01 19:06 ` Joseph, Jithu
2022-11-03 11:33 ` Borislav Petkov
2022-11-03 19:25 ` Ashok Raj
2022-11-03 23:32 ` Borislav Petkov
2022-11-04 6:15 ` Joseph, Jithu
2022-11-04 10:50 ` Borislav Petkov
2022-11-04 22:02 ` Joseph, Jithu
2022-11-04 22:14 ` Borislav Petkov
2022-10-21 20:34 ` [PATCH 08/14] x86/microcode/intel: Meta-data support in microcode file Jithu Joseph
2022-11-01 8:51 ` Sohil Mehta
2022-11-01 18:05 ` Joseph, Jithu
2022-11-03 11:35 ` Borislav Petkov
2022-10-21 20:34 ` [PATCH 09/14] platform/x86/intel/ifs: Use generic microcode headers and functions Jithu Joseph
2022-11-01 18:37 ` Sohil Mehta
2022-11-01 21:07 ` Joseph, Jithu
2022-10-21 20:34 ` [PATCH 10/14] platform/x86/intel/ifs: Add metadata validation Jithu Joseph
2022-11-01 20:28 ` Sohil Mehta
2022-11-09 23:10 ` Sohil Mehta
2022-10-21 20:34 ` [PATCH 11/14] platform/x86/intel/ifs: Remove reload sysfs entry Jithu Joseph
2022-10-21 20:34 ` [PATCH 12/14] platform/x86/intel/ifs: Add current_batch " Jithu Joseph
2022-11-01 22:26 ` Sohil Mehta
2022-11-01 23:27 ` Joseph, Jithu
2022-11-03 8:03 ` Sohil Mehta
2022-10-21 20:34 ` [PATCH 13/14] Documentation/ABI: Update IFS ABI doc Jithu Joseph
2022-11-01 22:34 ` Sohil Mehta
2022-11-01 22:48 ` Joseph, Jithu
2022-11-01 22:59 ` Sohil Mehta
2022-11-02 22:10 ` Joseph, Jithu
2022-11-03 7:49 ` Sohil Mehta
2022-10-21 20:34 ` [PATCH 14/14] Revert "platform/x86/intel/ifs: Mark as BROKEN" Jithu Joseph
2022-11-03 8:21 ` [PATCH 00/14] IFS multi test image support and misc changes Sohil Mehta
2022-11-07 9:24 ` Hans de Goede
2022-11-07 23:01 ` Joseph, Jithu
2022-11-07 22:53 ` [PATCH v2 " Jithu Joseph
2022-11-07 22:53 ` [PATCH v2 01/14] platform/x86/intel/ifs: Remove unused selection Jithu Joseph
2022-11-09 1:52 ` Sohil Mehta
2022-11-10 21:03 ` Hans de Goede
2022-11-07 22:53 ` [PATCH v2 02/14] platform/x86/intel/ifs: return a more appropriate Error code Jithu Joseph
2022-11-09 1:57 ` Sohil Mehta
2022-11-10 21:04 ` Hans de Goede
2022-11-07 22:53 ` [PATCH v2 03/14] platform/x86/intel/ifs: Remove image loading during init Jithu Joseph
2022-11-09 1:59 ` Sohil Mehta
2022-11-10 21:06 ` Hans de Goede
2022-11-07 22:53 ` [PATCH v2 04/14] x86/microcode/intel: Expose find_matching_signature() for IFS Jithu Joseph
2022-11-09 2:06 ` Sohil Mehta
2022-11-11 13:44 ` Borislav Petkov
2022-11-07 22:53 ` [PATCH v2 05/14] x86/microcode/intel: Use appropriate type in microcode_sanity_check() Jithu Joseph
2022-11-09 2:47 ` Sohil Mehta
2022-11-11 13:46 ` Borislav Petkov
2022-11-07 22:53 ` [PATCH v2 06/14] x86/microcode/intel: Expose microcode_sanity_check() Jithu Joseph
2022-11-09 3:03 ` Sohil Mehta
2022-11-09 3:29 ` Joseph, Jithu
2022-11-11 14:33 ` Borislav Petkov
2022-11-11 21:39 ` Joseph, Jithu
2022-11-07 22:53 ` [PATCH v2 07/14] x86/microcode/intel: Use a reserved field for metasize Jithu Joseph
2022-11-09 3:06 ` Sohil Mehta
2022-11-11 14:37 ` Borislav Petkov
2022-11-07 22:53 ` [PATCH v2 08/14] platform/x86/intel/ifs: Add metadata support Jithu Joseph
2022-11-09 3:25 ` Sohil Mehta
2022-11-10 21:08 ` Hans de Goede
2022-11-11 16:16 ` Borislav Petkov
2022-11-07 22:53 ` [PATCH v2 09/14] platform/x86/intel/ifs: Use generic microcode headers and functions Jithu Joseph
2022-11-09 3:29 ` Sohil Mehta
2022-11-10 21:11 ` Hans de Goede [this message]
2022-11-11 16:23 ` Borislav Petkov
2022-11-11 20:41 ` Joseph, Jithu
2022-11-16 17:26 ` Tony Luck
2022-11-16 18:53 ` Borislav Petkov
2022-11-16 19:02 ` Luck, Tony
2022-11-07 22:53 ` [PATCH v2 10/14] platform/x86/intel/ifs: Add metadata validation Jithu Joseph
2022-11-09 23:15 ` Sohil Mehta
2022-11-10 1:22 ` Joseph, Jithu
2022-11-10 9:40 ` Sohil Mehta
2022-11-10 21:18 ` Hans de Goede
2022-11-11 18:39 ` Borislav Petkov
2022-11-11 18:48 ` Dave Hansen
2022-11-11 20:30 ` Joseph, Jithu
2022-11-11 21:29 ` Ashok Raj
2022-11-07 22:53 ` [PATCH v2 11/14] platform/x86/intel/ifs: Remove reload sysfs entry Jithu Joseph
2022-11-09 23:16 ` Sohil Mehta
2022-11-10 21:19 ` Hans de Goede
2022-11-07 22:53 ` [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch " Jithu Joseph
2022-11-09 23:46 ` Sohil Mehta
2022-11-10 21:22 ` Hans de Goede
2022-11-12 16:26 ` Borislav Petkov
2022-11-12 18:21 ` Thiago Macieira
2022-11-12 19:20 ` Borislav Petkov
2022-11-12 19:58 ` Ashok Raj
2022-11-13 2:06 ` Thiago Macieira
2022-11-12 18:33 ` Luck, Tony
2022-11-12 19:28 ` Borislav Petkov
2022-11-12 23:32 ` Luck, Tony
2022-11-13 2:35 ` Thiago Macieira
2022-11-13 7:37 ` gregkh
2022-11-13 11:48 ` Borislav Petkov
2022-11-13 15:15 ` Ashok Raj
2022-11-13 15:58 ` Borislav Petkov
2022-11-13 17:01 ` Ashok Raj
2022-11-13 18:41 ` Borislav Petkov
2022-11-13 21:40 ` Thiago Macieira
2022-11-13 22:59 ` Borislav Petkov
2022-11-14 18:13 ` Dave Hansen
2022-11-14 18:25 ` Luck, Tony
2022-11-14 19:03 ` Borislav Petkov
2022-11-14 19:07 ` Luck, Tony
2022-11-14 19:17 ` Borislav Petkov
2022-11-14 19:38 ` Luck, Tony
2022-11-14 19:51 ` Borislav Petkov
2022-11-13 16:41 ` Joseph, Jithu
2022-11-13 16:58 ` Borislav Petkov
2022-11-13 17:55 ` Joseph, Jithu
2022-11-13 18:27 ` Borislav Petkov
2022-11-13 21:33 ` Tony Luck
2022-11-13 22:55 ` Borislav Petkov
2022-11-13 21:21 ` Thiago Macieira
2022-11-13 22:40 ` Borislav Petkov
2022-11-13 21:51 ` Thiago Macieira
2022-11-13 23:05 ` Borislav Petkov
2022-11-14 8:28 ` Hans de Goede
2022-11-14 7:15 ` gregkh
2022-11-14 15:33 ` Tony Luck
2022-11-14 15:47 ` Borislav Petkov
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-07 22:53 ` [PATCH v2 13/14] Documentation/ABI: Update IFS ABI doc Jithu Joseph
2022-11-09 23:55 ` Sohil Mehta
2022-11-10 1:16 ` Joseph, Jithu
2022-11-10 21:33 ` Hans de Goede
2022-11-07 22:53 ` [PATCH v2 14/14] Revert "platform/x86/intel/ifs: Mark as BROKEN" Jithu Joseph
2022-11-09 23:57 ` Sohil Mehta
2022-11-10 21:34 ` Hans de Goede
2022-11-10 9:59 ` [PATCH v2 00/14] IFS multi test image support and misc changes Borislav Petkov
2022-11-10 21:37 ` Hans de Goede
2022-11-10 21:58 ` Joseph, Jithu
2022-11-17 3:59 ` [PATCH v3 00/16] " Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 01/16] platform/x86/intel/ifs: Remove unused selection Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 02/16] platform/x86/intel/ifs: Return a more appropriate Error code Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] platform/x86/intel/ifs: Return a more appropriate error code tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 03/16] platform/x86/intel/ifs: Remove image loading during init Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 04/16] platform/x86/intel/ifs: Remove memory allocation from load path Jithu Joseph
2022-11-17 8:51 ` Hans de Goede
2022-11-17 17:29 ` Jithu Joseph
2022-11-17 18:01 ` Hans de Goede
2022-11-17 19:59 ` Jithu Joseph
2022-11-17 21:13 ` Hans de Goede
2022-11-17 22:44 ` Joseph, Jithu
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 05/16] x86/microcode/intel: Reuse find_matching_signature() Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 06/16] x86/microcode/intel: Use appropriate type in microcode_sanity_check() Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 07/16] x86/microcode/intel: Reuse microcode_sanity_check() Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 08/16] x86/microcode/intel: Add hdr_type to intel_microcode_sanity_check() Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 09/16] x86/microcode/intel: Use a reserved field for metasize Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 10/16] platform/x86/intel/ifs: Add metadata support Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Ashok Raj
2022-11-17 3:59 ` [PATCH v3 11/16] platform/x86/intel/ifs: Use generic microcode headers and functions Jithu Joseph
2022-11-17 22:50 ` Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 12/16] platform/x86/intel/ifs: Add metadata validation Jithu Joseph
2022-11-17 23:04 ` Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 13/16] platform/x86/intel/ifs: Remove reload sysfs entry Jithu Joseph
2022-11-19 16:24 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 14/16] platform/x86/intel/ifs: Add current_batch " Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 15/16] Documentation/ABI: Update IFS ABI doc Jithu Joseph
2022-11-19 16:23 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
2022-11-17 3:59 ` [PATCH v3 16/16] Revert "platform/x86/intel/ifs: Mark as BROKEN" Jithu Joseph
2022-11-19 16:23 ` [tip: x86/microcode] " tip-bot2 for Jithu Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53080422-a1de-0e44-7725-5cb69d1e23cc@redhat.com \
--to=hdegoede@redhat.com \
--cc=ashok.raj@intel.com \
--cc=athenas.jimenez.gonzalez@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mingo@redhat.com \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=thiago.macieira@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).