[PATCH] exfat: use updated exfat_chain directly during renaming

[PATCH] exfat: use updated exfat_chain directly during renaming

[Sungjong Seo]

In order for a file to access its own directory entry set,
exfat_inode_info(ei) has two copied values. One is ei->dir, which is
a snapshot of exfat_chain of the parent directory, and the other is
ei->entry, which is the offset of the start of the directory entry set
in the parent directory.

Since the parent directory can be updated after the snapshot point,
it should be used only for accessing one's own directory entry set.

However, as of now, during renaming, it could try to traverse or to
allocate clusters via snapshot values, it does not make sense.

This potential problem has been revealed when exfat_update_parent_info()
was removed by commit d8dad2588add ("exfat: fix referencing wrong parent
directory information after renaming"). However, I don't think it's good
idea to bring exfat_update_parent_info() back.

Instead, let's use the updated exfat_chain of parent directory diectly.

Fixes: d8dad2588add ("exfat: fix referencing wrong parent directory information after renaming")

Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
---
 fs/exfat/namei.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
index 76acc3721951..c6eaf7e9ea74 100644
--- a/fs/exfat/namei.c
+++ b/fs/exfat/namei.c
@@ -1198,7 +1198,9 @@ static int __exfat_rename(struct inode *old_parent_inode,
 		return -ENOENT;
 	}
 
-	exfat_chain_dup(&olddir, &ei->dir);
+	exfat_chain_set(&olddir, EXFAT_I(old_parent_inode)->start_clu,
+		EXFAT_B_TO_CLU_ROUND_UP(i_size_read(old_parent_inode), sbi),
+		EXFAT_I(old_parent_inode)->flags);
 	dentry = ei->entry;
 
 	ep = exfat_get_dentry(sb, &olddir, dentry, &old_bh);
-- 
2.25.1

Re: [PATCH] exfat: use updated exfat_chain directly during renaming

[Namjae Jeon]

2022-06-08 11:04 GMT+09:00, Sungjong Seo <sj1557.seo@samsung.com>:
> In order for a file to access its own directory entry set,
> exfat_inode_info(ei) has two copied values. One is ei->dir, which is
> a snapshot of exfat_chain of the parent directory, and the other is
> ei->entry, which is the offset of the start of the directory entry set
> in the parent directory.
>
> Since the parent directory can be updated after the snapshot point,
> it should be used only for accessing one's own directory entry set.
>
> However, as of now, during renaming, it could try to traverse or to
> allocate clusters via snapshot values, it does not make sense.
>
> This potential problem has been revealed when exfat_update_parent_info()
> was removed by commit d8dad2588add ("exfat: fix referencing wrong parent
> directory information after renaming"). However, I don't think it's good
> idea to bring exfat_update_parent_info() back.
>
> Instead, let's use the updated exfat_chain of parent directory diectly.
>
> Fixes: d8dad2588add ("exfat: fix referencing wrong parent directory
> information after renaming")
>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
Applied, Thanks for your patch!

Re: [PATCH] exfat: use updated exfat_chain directly during renaming

[Pavel Reichl]

On 6/8/22 04:04, Sungjong Seo wrote:
>
> Fixes: d8dad2588add ("exfat: fix referencing wrong parent directory information after renaming")

Hello,

I just wonder, since the fixed patch had tag: 'Cc: stable@vger.kernel.org' should this, fixing patch, go to stable as well?

Thanks!

Re: [PATCH] exfat: use updated exfat_chain directly during renaming

[Namjae Jeon]

2022-09-30 18:00 GMT+09:00, Pavel Reichl <preichl@redhat.com>:
>
> On 6/8/22 04:04, Sungjong Seo wrote:
>>
>> Fixes: d8dad2588add ("exfat: fix referencing wrong parent directory
>> information after renaming")
>
> Hello,
>
> I just wonder, since the fixed patch had tag: 'Cc: stable@vger.kernel.org'
> should this, fixing patch, go to stable as well?
It was well applied into stable kernels although stable tag was missing.
>
> Thanks!
>
>

Re: [PATCH] exfat: use updated exfat_chain directly during renaming

[Pavel Reichl]

On 9/30/22 11:13, Namjae Jeon wrote:
> 2022-09-30 18:00 GMT+09:00, Pavel Reichl <preichl@redhat.com>:
>> On 6/8/22 04:04, Sungjong Seo wrote:
>>> Fixes: d8dad2588add ("exfat: fix referencing wrong parent directory
>>> information after renaming")
>> Hello,
>>
>> I just wonder, since the fixed patch had tag: 'Cc: stable@vger.kernel.org'
>> should this, fixing patch, go to stable as well?
> It was well applied into stable kernels although stable tag was missing.
Oh, OK, thank you!
>> Thanks!
>>
>>