* [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
@ 2014-05-01 8:23 Raghavendra Ganiga
2014-05-01 9:05 ` Ian Abbott
0 siblings, 1 reply; 6+ messages in thread
From: Raghavendra Ganiga @ 2014-05-01 8:23 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Raghavendra Ganiga
This is a patch to fix coding style
warnings found by checkpatch.pl tool
Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 70545e6..b24bf9b 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -668,6 +668,7 @@ static int do_devconfig_ioctl(struct comedi_device *dev,
return -EBUSY;
if (dev->attached) {
struct module *driver_module = dev->driver->module;
+
comedi_device_detach(dev);
module_put(driver_module);
}
@@ -2653,6 +2654,7 @@ static int __init comedi_init(void)
/* create devices files for legacy/manual use */
for (i = 0; i < comedi_num_legacy_minors; i++) {
struct comedi_device *dev;
+
dev = comedi_alloc_board_minor(NULL);
if (IS_ERR(dev)) {
comedi_cleanup_board_minors();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
2014-05-01 8:23 [PATCH] staging: comedi: fix coding style issues in comedi_fops.c Raghavendra Ganiga
@ 2014-05-01 9:05 ` Ian Abbott
0 siblings, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2014-05-01 9:05 UTC (permalink / raw)
To: Raghavendra Ganiga, hsweeten, gregkh; +Cc: devel, linux-kernel
On 2014/05/01 09:23 AM, Raghavendra Ganiga wrote:
> This is a patch to fix coding style
> warnings found by checkpatch.pl tool
>
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 70545e6..b24bf9b 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -668,6 +668,7 @@ static int do_devconfig_ioctl(struct comedi_device *dev,
> return -EBUSY;
> if (dev->attached) {
> struct module *driver_module = dev->driver->module;
> +
> comedi_device_detach(dev);
> module_put(driver_module);
> }
> @@ -2653,6 +2654,7 @@ static int __init comedi_init(void)
> /* create devices files for legacy/manual use */
> for (i = 0; i < comedi_num_legacy_minors; i++) {
> struct comedi_device *dev;
> +
> dev = comedi_alloc_board_minor(NULL);
> if (IS_ERR(dev)) {
> comedi_cleanup_board_minors();
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
2014-04-30 17:34 Raghavendra Ganiga
2014-04-30 19:59 ` Dan Carpenter
@ 2014-05-01 9:01 ` Ian Abbott
1 sibling, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2014-05-01 9:01 UTC (permalink / raw)
To: Raghavendra Ganiga, hsweeten, gregkh; +Cc: devel, linux-kernel
On 2014/04/30 06:34 PM, Raghavendra Ganiga wrote:
> This is a patch to fix coding style
> warnings found by the checkpatch.pl tool
>
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index acc8019..a62d639 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev, "%d not valid subdevice\n",
> + cmd->subdev);
> return -EIO;
> }
>
> if (!s->do_cmd || !s->do_cmdtest || !s->async) {
> dev_dbg(dev->class_dev,
> - "subdevice %d does not support commands\n", cmd->subdev);
> + "subdevice %d does not support commands\n",
> + cmd->subdev);
> return -EIO;
> }
(I think this is "PATCH v2".)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
2014-04-30 17:34 Raghavendra Ganiga
@ 2014-04-30 19:59 ` Dan Carpenter
2014-05-01 9:01 ` Ian Abbott
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-04-30 19:59 UTC (permalink / raw)
To: Raghavendra Ganiga; +Cc: abbotti, hsweeten, gregkh, devel, linux-kernel
On Wed, Apr 30, 2014 at 11:04:49PM +0530, Raghavendra Ganiga wrote:
> This is a patch to fix coding style
> warnings found by the checkpatch.pl tool
>
Someone fixed this already. You should be working against linux-next
for this kind of thing.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
@ 2014-04-30 17:34 Raghavendra Ganiga
2014-04-30 19:59 ` Dan Carpenter
2014-05-01 9:01 ` Ian Abbott
0 siblings, 2 replies; 6+ messages in thread
From: Raghavendra Ganiga @ 2014-04-30 17:34 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: ravi23ganiga, devel, linux-kernel
This is a patch to fix coding style
warnings found by the checkpatch.pl tool
Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index acc8019..a62d639 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
s = &dev->subdevices[cmd->subdev];
if (s->type == COMEDI_SUBD_UNUSED) {
- dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
+ dev_dbg(dev->class_dev, "%d not valid subdevice\n",
+ cmd->subdev);
return -EIO;
}
if (!s->do_cmd || !s->do_cmdtest || !s->async) {
dev_dbg(dev->class_dev,
- "subdevice %d does not support commands\n", cmd->subdev);
+ "subdevice %d does not support commands\n",
+ cmd->subdev);
return -EIO;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
@ 2014-04-25 17:50 RAGHAVENDRA GANIGA
0 siblings, 0 replies; 6+ messages in thread
From: RAGHAVENDRA GANIGA @ 2014-04-25 17:50 UTC (permalink / raw)
To: ravi23ganiga; +Cc: linux-kernel
>From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga <ravi23ganiga@gmail.com>
Date: Fri, 25 Apr 2014 23:11:22 +0530
Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
This is a patch to fix coding style
warnings found by the checkpatch.pl tool
Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index ea6dc36..0cd67d0 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
s = &dev->subdevices[cmd->subdev];
if (s->type == COMEDI_SUBD_UNUSED) {
- dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
+ dev_dbg(dev->class_dev,
+ "%d not valid subdevice\n", cmd->subdev);
return -EIO;
}
if (!s->do_cmd || !s->do_cmdtest || !s->async) {
dev_dbg(dev->class_dev,
- "subdevice %d does not support commands\n", cmd->subdev);
+ "subdevice %d does not support commands\n",
+ cmd->subdev);
return -EIO;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-01 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-01 8:23 [PATCH] staging: comedi: fix coding style issues in comedi_fops.c Raghavendra Ganiga
2014-05-01 9:05 ` Ian Abbott
-- strict thread matches above, loose matches on Subject: below --
2014-04-30 17:34 Raghavendra Ganiga
2014-04-30 19:59 ` Dan Carpenter
2014-05-01 9:01 ` Ian Abbott
2014-04-25 17:50 RAGHAVENDRA GANIGA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).