From: Kukjin Kim <kgene.kim@samsung.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
gregkh@linuxfoundation.org, balbi@ti.com, kgene.kim@samsung.com,
t.figa@samsung.com, k.debski@samsung.com, jg1.han@samsung.com
Subject: Re: [PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework
Date: Fri, 02 May 2014 22:17:54 +0900 [thread overview]
Message-ID: <53639B02.1020101@samsung.com> (raw)
In-Reply-To: <1399034855-9686-1-git-send-email-gautam.vivek@samsung.com>
On 05/02/14 21:47, Vivek Gautam wrote:
> Based and tested on 'usb-next' branch of Greg's usb tree, with relevant
> device tree patches[1]
>
> Hi Alan,
> I have included your Acked-by in all the four patches, but there has been
> some amount of restructuring as suggested by Tomasz Figa.
> Please let me know if you have some comments on this patch-series.
>
> Changes from v4:
> - Addressed review comments for restructuring exynos_ohci_get_phy()
> and exynos_ehci_get_phy(); and thereby adding proper checks in
> exynos_ohci_phy_enable()/disable() as well as exynos_ehci_phy_enable()/
> disable().
>
> Changes from v3:
> - Calling usb_phy_shutdown() when exynos_o/ehci_phy_enable() is failing.
> - Made exynos_o/ehci_phy_disable() return void, since its return value
> did not serve any purpose.
> - Calling clk_disable_unprepare() in exynos_o/ehci_resume() when
> exynos_o/ehci_phy_enable() is failed.
>
> Changes from v2:
> - Added two patches in the series for some cleanup.
> usb: ohci-exynos: Use struct device instead of platform_device
> usb: ehci-exynos: Use struct device instead of platform_device
> - Addressed review comments.
> -- Moved exynos_ohci_phyg_on()/off routines inside
> exynos_ohci_phy_enable()/disable.
> -- Added functions exynos_ehci_phy_enable() and exynos_ehci_phy_disable()
> and moved exynos_ehci_phyg_on()/off routines respectively in them.
> -- Added necessary checks.
>
> [1]: [PATCH 0/4] dts: Add usb2phy to Exynos 5250/5420
> https://lkml.org/lkml/2014/4/30/119
>
> Kamil Debski (1):
> usb: ehci-exynos: Change to use phy provided by the generic phy
> framework
>
> Vivek Gautam (3):
> usb: ohci-exynos: Use struct device instead of platform_device
> usb: ehci-exynos: Use struct device instead of platform_device
> usb: ohci-exynos: Add facility to use phy provided by the generic phy
> framework
>
> .../devicetree/bindings/usb/exynos-usb.txt | 31 +++++
> drivers/usb/host/ehci-exynos.c | 136 ++++++++++++++++----
> drivers/usb/host/ohci-exynos.c | 134 +++++++++++++++----
> 3 files changed, 254 insertions(+), 47 deletions(-)
>
This series looks good to me, please feel free to add my ack on this series,
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks,
Kukjin
prev parent reply other threads:[~2014-05-02 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 12:47 [PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework Vivek Gautam
2014-05-02 12:47 ` [PATCH v3 1/4] usb: ohci-exynos: Use struct device instead of platform_device Vivek Gautam
2014-05-05 5:03 ` [PATCH v4 " Vivek Gautam
2014-05-02 12:47 ` [PATCH v3 2/4] usb: ehci-exynos: " Vivek Gautam
2014-05-05 5:04 ` [PATCH v4 " Vivek Gautam
2014-05-02 12:47 ` [PATCH v5 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework Vivek Gautam
2014-05-02 17:39 ` Tomasz Figa
2014-05-05 5:02 ` [PATCH v6 " Vivek Gautam
2014-05-09 8:20 ` Tomasz Figa
2014-05-02 12:47 ` [PATCH v11 4/4] usb: ehci-exynos: Change " Vivek Gautam
2014-05-05 5:02 ` [PATCH v12 " Vivek Gautam
2014-05-09 8:19 ` Tomasz Figa
2014-05-02 13:17 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53639B02.1020101@samsung.com \
--to=kgene.kim@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).