From: Tomasz Figa <t.figa@samsung.com>
To: Vivek Gautam <gautam.vivek@samsung.com>,
linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
gregkh@linuxfoundation.org, balbi@ti.com, kgene.kim@samsung.com,
k.debski@samsung.com, jg1.han@samsung.com
Subject: Re: [PATCH v12 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework
Date: Fri, 09 May 2014 10:19:51 +0200 [thread overview]
Message-ID: <536C8FA7.2040401@samsung.com> (raw)
In-Reply-To: <1399266148-31729-1-git-send-email-gautam.vivek@samsung.com>
Hi Vivek,
On 05.05.2014 07:02, Vivek Gautam wrote:
> From: Kamil Debski <k.debski@samsung.com>
>
> Add the phy provider, supplied by new Exynos-usb2phy using
> Generic phy framework.
> Keeping the support for older USB phy intact right now, in order
> to prevent any functionality break in absence of relevant
> device tree side change for ehci-exynos.
> Once we move to new phy in the device nodes for ehci, we can
> remove the support for older phys.
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> [gautam.vivek@samsung.com: Addressed review comments from mailing list]
> [gautam.vivek@samsung.com: Kept the code for old usb-phy, and just
> added support for new exynos5-usb2phy in generic phy framework]
> [gautam.vivek@samsung.com: Edited the commit message]
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>
> Changes from v11:
> - Removed setting phy explicitly to error pointer.
> - Changed error check to '-ENOSYS' instead of '-ENXIO' in failure case of
> devm_of_phy_get().
>
> Changes from v10:
> - Removed 'phy-names' property from the bindings since we don't need it.
> - Restructured exynos_ehci_get_phy() function to handle error codes as
> well as return relevant error codes effectively.
> - Added IS_ERR() check for PHYs in exynos_ehci_phy_enable()/disable().
>
> Changes from v9:
> - Calling usb_phy_shutdown() when exynos_ehci_phy_enable() is failing.
> - Made exynos_ehci_phy_disable() return void, since its return value
> did not serve any purpose.
> - Calling clk_disable_unprepare() in exynos_ehci_resume() when
> exynos_ehci_phy_enable() is failed.
>
> .../devicetree/bindings/usb/exynos-usb.txt | 15 +++
> drivers/usb/host/ehci-exynos.c | 129 +++++++++++++++++---
> 2 files changed, 124 insertions(+), 20 deletions(-)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-09 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 12:47 [PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework Vivek Gautam
2014-05-02 12:47 ` [PATCH v3 1/4] usb: ohci-exynos: Use struct device instead of platform_device Vivek Gautam
2014-05-05 5:03 ` [PATCH v4 " Vivek Gautam
2014-05-02 12:47 ` [PATCH v3 2/4] usb: ehci-exynos: " Vivek Gautam
2014-05-05 5:04 ` [PATCH v4 " Vivek Gautam
2014-05-02 12:47 ` [PATCH v5 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework Vivek Gautam
2014-05-02 17:39 ` Tomasz Figa
2014-05-05 5:02 ` [PATCH v6 " Vivek Gautam
2014-05-09 8:20 ` Tomasz Figa
2014-05-02 12:47 ` [PATCH v11 4/4] usb: ehci-exynos: Change " Vivek Gautam
2014-05-05 5:02 ` [PATCH v12 " Vivek Gautam
2014-05-09 8:19 ` Tomasz Figa [this message]
2014-05-02 13:17 ` [PATCH v5 0/4] usb: ehci/ohci-exynos: Move to " Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C8FA7.2040401@samsung.com \
--to=t.figa@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=k.debski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).