* [PATCH] usb: gadget: atmel_usba: always test udc->driver
@ 2014-05-06 15:16 Alexandre Belloni
2014-05-09 10:09 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2014-05-06 15:16 UTC (permalink / raw)
To: Felipe Balbi
Cc: Nicolas Ferre, linux-arm-kernel, linux-kernel, linux-usb,
Alexandre Belloni
Found using smatch: drivers/usb/gadget/atmel_usba_udc.c:1689 usba_udc_irq()
error: we previously assumed 'udc->driver' could be null (see line 1636)
Always test udc->driver before using its members.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/usb/gadget/atmel_usba_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index 9f65324f9ae0..76023ce449a3 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -1686,7 +1686,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
reset_all_endpoints(udc);
if (udc->gadget.speed != USB_SPEED_UNKNOWN
- && udc->driver->disconnect) {
+ && udc->driver && udc->driver->disconnect) {
udc->gadget.speed = USB_SPEED_UNKNOWN;
spin_unlock(&udc->lock);
udc->driver->disconnect(&udc->gadget);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: atmel_usba: always test udc->driver
2014-05-06 15:16 [PATCH] usb: gadget: atmel_usba: always test udc->driver Alexandre Belloni
@ 2014-05-09 10:09 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2014-05-09 10:09 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Alexandre Belloni, linux-arm-kernel, linux-kernel, linux-usb
On 06/05/2014 17:16, Alexandre Belloni :
> Found using smatch: drivers/usb/gadget/atmel_usba_udc.c:1689 usba_udc_irq()
> error: we previously assumed 'udc->driver' could be null (see line 1636)
>
> Always test udc->driver before using its members.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks,
> ---
> drivers/usb/gadget/atmel_usba_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> index 9f65324f9ae0..76023ce449a3 100644
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -1686,7 +1686,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
> reset_all_endpoints(udc);
>
> if (udc->gadget.speed != USB_SPEED_UNKNOWN
> - && udc->driver->disconnect) {
> + && udc->driver && udc->driver->disconnect) {
> udc->gadget.speed = USB_SPEED_UNKNOWN;
> spin_unlock(&udc->lock);
> udc->driver->disconnect(&udc->gadget);
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-09 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-06 15:16 [PATCH] usb: gadget: atmel_usba: always test udc->driver Alexandre Belloni
2014-05-09 10:09 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).