From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mturquette@linaro.org,
t.figa@samsung.com, kgene.kim@samsung.com, galak@codeaurora.org,
ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
pawel.moll@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH 0/4] Add framework to support clkout
Date: Sat, 10 May 2014 12:39:52 +0900 [thread overview]
Message-ID: <536D9F88.9000505@samsung.com> (raw)
In-Reply-To: <1399640410-30957-1-git-send-email-tushar.behera@linaro.org>
Hi Tushar,
On 05/09/2014 10:00 PM, Tushar Behera wrote:
> The MUX/GATE register for XCLKOUT doesn't resides within PMU domain,
> this can be accessed through a regmap provided by syscon driver. Adding
> another clock provider to handle regmap based handing of XCLKOUT.
>
> Dependency:
> 1. [PATCH v3] mfd: syscon: Support early initialization
> http://article.gmane.org/gmane.linux.kernel/1679446
>
> Also we need to find a suitable place to call early_syscon_init(), after
> the device tree has been unflattened and before clock initialization.
>
> While testing, I called this before of_clk_init() in arch/arm/kernel/time.c,
> but that place is too generic. Calling anywhere from exynos.c is not
> working ATM.
IMO we do not need to, or if I am not wrong we should not change time.c.
It's possible if we have exynos specific init_time with following changes.
FYI, In my patch series for Exynos PMU [1], currently I am handling this in
exynos_dt_machine_init. But definitely it can be handled as below and it works
without any side effect and I have tested it. Only reason I do not adopted this
as for Exynos PMU patch support I had other options. But if required and if
following change is acceptable I can include this in my next version of Exynos
PMU patch series.
[1]: https://lkml.org/lkml/2014/4/30/18
+static void __init exynos_init_time(void)
+{
+ /* Nothing to do timer specific
+ * as early_syscon_init requires DT to be unflattened and
+ * system should be able to allocate memory we need to
+ * postpone until init_time, but it should be done before
+ * init_machine. Because before init_machine, secondary
+ * core boot starts and it uses PMU registers.
+ */
+
+ exynos_map_pmu();
+
+ of_clk_init(NULL);
+ clocksource_of_init();
+
+}
+
DT_MACHINE_START(EXYNOS_DT, "SAMSUNG EXYNOS (Flattened Device Tree)")
/* Maintainer: Thomas Abraham <thomas.abraham@linaro.org> */
/* Maintainer: Kukjin Kim <kgene.kim@samsung.com> */
.smp = smp_ops(exynos_smp_ops),
.map_io = exynos_init_io,
.init_early = exynos_firmware_init,
+ .init_time = exynos_init_time,
>
> Tushar Behera (4):
> clk: samsung: out: Add infrastructure to register CLKOUT
> clk: samsung: exynos5420: Add xclkout debug clock
> clk: samsung: exynos5250: Add xclkout debug clock
> ARM: dts: Add pmu-syscon handle for Exynos5420/Exynos5250 clock
>
> arch/arm/boot/dts/exynos5250.dtsi | 1 +
> arch/arm/boot/dts/exynos5420.dtsi | 1 +
> drivers/clk/samsung/Makefile | 2 +-
> drivers/clk/samsung/clk-exynos5250.c | 14 +++
> drivers/clk/samsung/clk-exynos5420.c | 14 +++
> drivers/clk/samsung/clk-out.c | 181 ++++++++++++++++++++++++++++++++
> drivers/clk/samsung/clk.h | 33 ++++++
> include/dt-bindings/clock/exynos5250.h | 3 +
> include/dt-bindings/clock/exynos5420.h | 5 +-
> 9 files changed, 252 insertions(+), 2 deletions(-)
> create mode 100644 drivers/clk/samsung/clk-out.c
>
--
Best Regards,
Pankaj Dubey
next prev parent reply other threads:[~2014-05-10 3:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 13:00 [PATCH 0/4] Add framework to support clkout Tushar Behera
2014-05-09 13:00 ` [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT Tushar Behera
2014-05-10 3:51 ` Pankaj Dubey
2014-05-12 4:46 ` Tushar Behera
2014-05-15 13:44 ` Rahul Sharma
2014-05-15 14:07 ` Tomasz Figa
2014-05-15 14:14 ` Rahul Sharma
2014-05-19 3:30 ` Tushar Behera
2014-05-19 10:44 ` Tomasz Figa
2014-05-09 13:00 ` [PATCH 2/4] clk: samsung: exynos5420: Add xclkout debug clock Tushar Behera
2014-05-09 13:00 ` [PATCH 3/4] clk: samsung: exynos5250: " Tushar Behera
2014-05-09 13:00 ` [PATCH 4/4] ARM: dts: Add pmu-syscon handle for Exynos5420/Exynos5250 clock Tushar Behera
2014-05-10 3:39 ` Pankaj Dubey [this message]
2014-05-12 4:42 ` [PATCH 0/4] Add framework to support clkout Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536D9F88.9000505@samsung.com \
--to=pankaj.dubey@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=t.figa@samsung.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).