From: Tushar Behera <tushar.behera@linaro.org>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mturquette@linaro.org,
t.figa@samsung.com, kgene.kim@samsung.com, galak@codeaurora.org,
ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
pawel.moll@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT
Date: Mon, 12 May 2014 10:16:59 +0530 [thread overview]
Message-ID: <53705243.1030704@linaro.org> (raw)
In-Reply-To: <536DA243.6000600@samsung.com>
On 05/10/2014 09:21 AM, Pankaj Dubey wrote:
> On 05/09/2014 10:00 PM, Tushar Behera wrote:
>> All SoC in Exynos-series have a clock with name XCLKOUT to provide
>> debug information about various clocks available in the SoC. The register
>> controlling the MUX and GATE of this clock is provided within PMU domain.
>> Since PMU domain can't be dedicatedly mapped by every driver, the
>> register
>> needs to be handled through a regmap handle provided by PMU syscon
>> controller. Right now, CCF doesn't allow regmap based MUX and GATE
>> clocks,
>> hence a dedicated clock provider for XCLKOUT is added here.
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> CC: Tomasz Figa <t.figa@samsung.com>
>> ---
>> drivers/clk/samsung/Makefile | 2 +-
>> drivers/clk/samsung/clk-out.c | 181
>> +++++++++++++++++++++++++++++++++++++++++
>> drivers/clk/samsung/clk.h | 33 ++++++++
>> 3 files changed, 215 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/clk/samsung/clk-out.c
>>
[ ... ]
>> +/**
>> + * struct samsung_clkout_soc_data: SoC specific register details
>> + * @reg: Offset of CLKOUT register from PMU base
>
> how about naming this variable as "offset" instead of "reg".
>
Okay, I will change that.
[ ... ]
>> +u8 samsung_clkout_get_parent(struct clk_hw *hw)
>> +{
>> + struct samsung_clkout *clkout = to_clk_out(hw);
>> + const struct samsung_clkout_soc_data *soc_data = clkout->soc_data;
>> + unsigned int parent_mask = BIT(soc_data->mux_width) - 1;
>> + unsigned int val;
>> + int ret;
>> +
>> + ret = regmap_read(clkout->regmap, soc_data->reg, &val);
>
> Do we really need to keep return value in "ret" as I can't see you are
> using it anywhere?
>
Right, we are not using that and can be removed.
>> +
>> + return (val >> soc_data->mux_shift) & parent_mask;
>> +}
>> +
[ ... ]
>> +/* All existing Exynos serial of SoCs have common values for this
>> offsets. */
> typo: serial/series/
Sure. Thanks for your review.
--
Tushar Behera
next prev parent reply other threads:[~2014-05-12 4:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 13:00 [PATCH 0/4] Add framework to support clkout Tushar Behera
2014-05-09 13:00 ` [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT Tushar Behera
2014-05-10 3:51 ` Pankaj Dubey
2014-05-12 4:46 ` Tushar Behera [this message]
2014-05-15 13:44 ` Rahul Sharma
2014-05-15 14:07 ` Tomasz Figa
2014-05-15 14:14 ` Rahul Sharma
2014-05-19 3:30 ` Tushar Behera
2014-05-19 10:44 ` Tomasz Figa
2014-05-09 13:00 ` [PATCH 2/4] clk: samsung: exynos5420: Add xclkout debug clock Tushar Behera
2014-05-09 13:00 ` [PATCH 3/4] clk: samsung: exynos5250: " Tushar Behera
2014-05-09 13:00 ` [PATCH 4/4] ARM: dts: Add pmu-syscon handle for Exynos5420/Exynos5250 clock Tushar Behera
2014-05-10 3:39 ` [PATCH 0/4] Add framework to support clkout Pankaj Dubey
2014-05-12 4:42 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53705243.1030704@linaro.org \
--to=tushar.behera@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pankaj.dubey@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).