Re: [Patch V2 0/9] I2C ACPI operation region handler support

[Lan Tianyu <tianyu.lan@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

On 05/15/2014 03:50 PM, Rolf Eike Beer wrote:
> Lan Tianyu wrote:
>> On 05/13/2014 09:09 PM, Rolf Eike Beer wrote:
>>> Am Montag, 28. April 2014, 22:27:39 schrieb Lan Tianyu:
>>>> ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart)
>>>> operation
>>>> region. It allows ACPI aml code able to access such kind of devices to
>>>> implement some ACPI standard method.
>>>>
>>>> On the Asus T100TA, Bios use GenericSerialBus operation region to access
>>>> i2c device to get battery info. So battery function depends on the I2C
>>>> operation region support. Here is the bug link.
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=69011
>>>
>>> Hi all,
>>
>>> I have tested this series and got some errors, but no additional
> functionality:
>> Hi Rolf:
>> 	Thanks for test. Could you attach the output of dmesg and acpidump?
>> Which machine you are testing on?
>
> Hi,
>
> this is an Aava Inari 8 tablet (pre-release hardware). Please find the DSDT
> and the dmesg.log attached.
>
> In case of any further questions don't hesitate to ask, I'll try to be more
> responsible.
>

Hi Eike:
	Could you apply the patch in the attachment and attach the output of 	dmesg?
					


> Regards,
>
> Eike
>


[-- Attachment #2: debug.patch --]
[-- Type: text/x-patch, Size: 499 bytes --]

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 4ed8d48..cc8c132 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -139,8 +139,7 @@ int acpi_bus_attach_private_data(acpi_handle handle, void *data)
 	status = acpi_attach_data(handle,
 			acpi_bus_private_data_handler, data);
 	if (ACPI_FAILURE(status)) {
-		ACPI_ERROR((AE_INFO, "Error attaching device[%p] data\n",
-				handle));
+		acpi_handle_err(handle, "Error attaching device data %d\n", status);
 		return -ENODEV;
 	}