Re: [Patch V2 0/9] I2C ACPI operation region handler support

[Lan Tianyu <tianyu.lan@intel.com>]

On 05/20/2014 10:17 PM, Rolf Eike Beer wrote:
> Rolf Eike Beer wrote:
>> Lan Tianyu wrote:
>>> On 05/13/2014 09:09 PM, Rolf Eike Beer wrote:
>>>> Am Montag, 28. April 2014, 22:27:39 schrieb Lan Tianyu:
>>>>> ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart)
>>>>> operation
>>>>> region. It allows ACPI aml code able to access such kind of devices to
>>>>> implement some ACPI standard method.
>>>>>
>>>>> On the Asus T100TA, Bios use GenericSerialBus operation region to
>>>>> access
>>>>> i2c device to get battery info. So battery function depends on the I2C
>>>>> operation region support. Here is the bug link.
>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=69011
>
>>>> I have tested this series and got some errors, but no additional
>>>> functionality:
>
>> this is an Aava Inari 8 tablet (pre-release hardware). Please find the DSDT
>> and the dmesg.log attached.
>
> It may be that I have taken the wrong ACPI files. This is the result of a
> fresh run of acpidump, together with the most recent dmesg.log, just in case
> I messed it up.

Hi Rolf:
	I have check the log. I2C ACPI operation region targets to I2C controller which 
has one ACPI node in the ACPI table and is associated with one I2C adapter. 
Graphic with one ACPI handle registers several I2C adapters. This causes attach 
data to the ACPI handle with the same handler several time. The ACPICA function 
will return ALREADY EXIST error code and causes the log you mentioned. There is 
no I2C ACPI operation region under graphic device node and so not break 
function. To avoid these noise logs, I make them only appear under dynamic debug 
mode in the my V3 patchset.


>
> Kernel now is at 60b5f90+some patches:
>
> 8e7bd6f pinctrl: baytrail: Register GPIO chip after chip->to_irq is set
> c4b2230 pinctrl: baytrail: Add back Baytrail-T ACPI ID
> 32f3364 gpio: Add support for Intel SoC PMIC (Crystal Cove)
> 088ee81 mfd: intel_soc_pmic: Build files
> 5315135 mfd: intel_soc_pmic: Crystal Cove support
> 8b5ed0b mfd: intel_soc_pmic: I2C interface
> b18979f mfd: intel_soc_pmic: Core driver
> 5200b75 add debugging
>    (This is the debug patch Lan Tianyu sent as reply to the previous mail)
> bd3e6c6 I2C/ACPI: Add CONFIG_I2C_ACPI config
> 947f0a1 I2C/ACPI: Move ACPI related code to i2c-acpi.c
> 534f182 I2C/ACPI: Add i2c ACPI operation region support
> 32384d4 I2C: Add smbus word/block process call helper function
> aa6459e I2C: Add smbus quick read/write helper function
> 51825ed ACPI/Thermal: Use acpi_bus_attach_private_data() to attach private data
> 95e9e92 ACPI: Add acpi_bus_attach_private_data() to facilitate to attach data to ACPI handle
> cc6fecb ACPICA: Export acpi_buffer_to_resource symbol
> ad38de6 ACPI / LPSS: custom power domain for LPSS
> b0caadf ACPI / PM: Export rest of the subsys functions
> 22a7210 ACPI / platform: add another ID for Broadcom Bluetooth and GPS chips
>   (this just adds AAM4752 as another platform id)
> 000627d ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips
>
> Eike
>