linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PULL REQUEST] i2c for 3.17
@ 2014-08-09 13:56 Wolfram Sang
  2014-08-09 17:34 ` Linus Torvalds
  0 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2014-08-09 13:56 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 7154 bytes --]

Linus,

here is the pull request for 3.17 for the I2C subsystem. Highlights:

* class based instantiation finally dropped for most embedded drivers
  bringing boot up performance gains
* removed two drivers (one outdated, one a duplicate)
* ACPI has now operation region support (thanks to Lan Tianyu)
* the i2c-stub driver got overhauled and gained new features to become
  more useful when writing i2c client drivers (thanks to Guenter
  Roeck and Jean Delvare)

The rest is driver bugfixes, added bindings/ids, cleanups, ...
Please pull.

Thanks,

   Wolfram


The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee:

  Linux 3.16-rc2 (2014-06-21 19:02:54 -1000)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-3.17

for you to fetch changes up to ebba48b702ab11bbb76e357a7246bc2f19ad02bc:

  i2c: mpc: delete unneeded test before of_node_put (2014-08-08 18:45:30 +0200)

----------------------------------------------------------------
Alan Cox (1):
      i2c: designware: add new bindings

Christoph Jaeger (1):
      i2c: taos-evm: Use module_serio_driver()

Doug Anderson (1):
      i2c: exynos5: Properly use the "noirq" variants of suspend/resume

Fabio Estevam (1):
      i2c: i2c-st: Use %pa to print 'resource_size_t' type

Guenter Roeck (1):
      i2c: stub: Add support for SMBus block commands

Jean Delvare (6):
      i2c: stub: Remember the number of emulated chips
      i2c: stub: Add support for banked register ranges
      i2c: i801: Fix the alignment of the device table
      i2c: i801: Add device ID for Intel Wildcat Point PCH
      i2c: stub: Avoid an array overrun on I2C block transfers
      i2c: gpio: Drop dead code in i2c_gpio_remove

Jisheng Zhang (1):
      i2c: pca954x: put the mux to disconnected state after resume

Julia Lawall (1):
      i2c: mpc: delete unneeded test before of_node_put

Lan Tianyu (2):
      I2C/ACPI: Add i2c ACPI operation region support
      I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config

Maxime COQUELIN (1):
      i2c: st: Update i2c timings

Naveen Krishna Ch (2):
      i2c: exynos5: remove an unnecessary read of FIFO_STATUS register
      i2c: exynos5: remove extra line and fix an assignment

Pramod Gurav (1):
      i2c: qup: disable clks and return instead of just returning error

Sachin Kamat (1):
      i2c: exynos5: always enable HSI2C

Uwe Kleine-König (1):
      i2c: efm32: correct namespacing of location property

Vincent Palatin (1):
      i2c: s3c2410: resume the I2C controller earlier

Wolfram Sang (19):
      i2c: s6000: remove duplicate driver
      i2c: scx200: drop GPIO based i2c driver
      i2c: add debug info when class instantiation was dropped
      i2c: i2c-at91: Drop class based scanning to improve bootup time
      i2c: i2c-bcm2835: Drop class based scanning to improve bootup time
      i2c: i2c-bfin-twi: Drop class based scanning to improve bootup time
      i2c: i2c-davinci: Drop class based scanning to improve bootup time
      i2c: i2c-designware-platdrv: Drop class based scanning to improve bootup time
      i2c: i2c-mv64xxx: Drop class based scanning to improve bootup time
      i2c: i2c-nomadik: Drop class based scanning to improve bootup time
      i2c: i2c-ocores: Drop class based scanning to improve bootup time
      i2c: i2c-omap: Drop class based scanning to improve bootup time
      i2c: i2c-rcar: Drop class based scanning to improve bootup time
      i2c: i2c-s3c2410: Drop class based scanning to improve bootup time
      i2c: i2c-sirf: Drop class based scanning to improve bootup time
      i2c: i2c-stu300: Drop class based scanning to improve bootup time
      i2c: i2c-tegra: Drop class based scanning to improve bootup time
      i2c: i2c-xiic: Drop class based scanning to improve bootup time
      drivers/i2c/busses: use correct type for dma_map/unmap

Xiubo Li (1):
      i2c: imx: Fix format warning for dev_dbg

addy ke (1):
      i2c: rk3x: fix interrupt handling issue

 .../devicetree/bindings/i2c/i2c-efm32.txt          |   4 +-
 Documentation/i2c/busses/i2c-i801                  |   1 +
 Documentation/i2c/i2c-stub                         |  23 +-
 drivers/i2c/Kconfig                                |  18 +-
 drivers/i2c/Makefile                               |   5 +-
 drivers/i2c/busses/Kconfig                         |  46 +--
 drivers/i2c/busses/Makefile                        |   2 -
 drivers/i2c/busses/i2c-at91.c                      |   6 +-
 drivers/i2c/busses/i2c-bcm2835.c                   |   2 +-
 drivers/i2c/busses/i2c-bfin-twi.c                  |   2 +-
 drivers/i2c/busses/i2c-davinci.c                   |   2 +-
 drivers/i2c/busses/i2c-designware-pcidrv.c         |   9 +
 drivers/i2c/busses/i2c-designware-platdrv.c        |   3 +-
 drivers/i2c/busses/i2c-efm32.c                     |   8 +-
 drivers/i2c/busses/i2c-exynos5.c                   |  16 +-
 drivers/i2c/busses/i2c-gpio.c                      |   2 -
 drivers/i2c/busses/i2c-i801.c                      | 139 +++----
 drivers/i2c/busses/i2c-imx.c                       |   5 +-
 drivers/i2c/busses/i2c-mpc.c                       |   3 +-
 drivers/i2c/busses/i2c-mv64xxx.c                   |   2 +-
 drivers/i2c/busses/i2c-nomadik.c                   |   8 +-
 drivers/i2c/busses/i2c-ocores.c                    |  12 +-
 drivers/i2c/busses/i2c-omap.c                      |   2 +-
 drivers/i2c/busses/i2c-qup.c                       |  12 +-
 drivers/i2c/busses/i2c-rcar.c                      |  14 +-
 drivers/i2c/busses/i2c-rk3x.c                      |   2 +-
 drivers/i2c/busses/i2c-s3c2410.c                   |  16 +-
 drivers/i2c/busses/i2c-s6000.c                     | 404 ---------------------
 drivers/i2c/busses/i2c-s6000.h                     |  79 ----
 drivers/i2c/busses/i2c-sirf.c                      |   2 +-
 drivers/i2c/busses/i2c-st.c                        |  34 +-
 drivers/i2c/busses/i2c-stu300.c                    |   2 +-
 drivers/i2c/busses/i2c-taos-evm.c                  |  13 +-
 drivers/i2c/busses/i2c-tegra.c                     |   2 +-
 drivers/i2c/busses/i2c-xiic.c                      |  12 +-
 drivers/i2c/busses/scx200_i2c.c                    | 129 -------
 drivers/i2c/i2c-acpi.c                             | 362 ++++++++++++++++++
 drivers/i2c/i2c-core.c                             | 107 +-----
 drivers/i2c/i2c-stub.c                             | 237 +++++++++++-
 drivers/i2c/muxes/i2c-mux-pca954x.c                |  15 +
 include/linux/acpi.h                               |  11 +
 include/linux/i2c.h                                |  12 +
 include/linux/i2c/s6000.h                          |  10 -
 43 files changed, 853 insertions(+), 942 deletions(-)
 delete mode 100644 drivers/i2c/busses/i2c-s6000.c
 delete mode 100644 drivers/i2c/busses/i2c-s6000.h
 delete mode 100644 drivers/i2c/busses/scx200_i2c.c
 create mode 100644 drivers/i2c/i2c-acpi.c
 delete mode 100644 include/linux/i2c/s6000.h

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PULL REQUEST] i2c for 3.17
  2014-08-09 13:56 [PULL REQUEST] i2c for 3.17 Wolfram Sang
@ 2014-08-09 17:34 ` Linus Torvalds
  2014-08-11  1:39   ` Lan Tianyu
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2014-08-09 17:34 UTC (permalink / raw)
  To: Wolfram Sang, Mika Westerberg, Lan Tianyu
  Cc: linux-i2c, Linux Kernel Mailing List

On Sat, Aug 9, 2014 at 6:56 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
> here is the pull request for 3.17 for the I2C subsystem. Highlights:

Lowlight: selecting ACPI support (which used to be the default if ACPI
was enabled) now forces i2c to be built-in.

I've pulled this, but it's broken. You need to fix it someway.

The reason for this is

  config I2C
         tristate "I2C support"
  ...
  config I2C_ACPI
         bool "I2C ACPI support"
         select I2C
         depends on ACPI
   ...

where if I2C_APCI is on (y), then that "select I2C" will cause I2C to
be upgraded to 'y' as well.

This seems to be intentional, judging by the commit message, but it's
wrong. Distributions etc generally compile i2c as a module, and you've
now broken that.

This is a regression. Change the "select I2C" to a "depends on I2C",
and test the end result. Don't force people to build things into the
kernel.

                 Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PULL REQUEST] i2c for 3.17
  2014-08-09 17:34 ` Linus Torvalds
@ 2014-08-11  1:39   ` Lan Tianyu
  0 siblings, 0 replies; 7+ messages in thread
From: Lan Tianyu @ 2014-08-11  1:39 UTC (permalink / raw)
  To: Linus Torvalds, Wolfram Sang, Mika Westerberg
  Cc: linux-i2c, Linux Kernel Mailing List

On 2014年08月10日 01:34, Linus Torvalds wrote:
> On Sat, Aug 9, 2014 at 6:56 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>> here is the pull request for 3.17 for the I2C subsystem. Highlights:
> 
> Lowlight: selecting ACPI support (which used to be the default if ACPI
> was enabled) now forces i2c to be built-in.
> 
> I've pulled this, but it's broken. You need to fix it someway.
> 
> The reason for this is
> 
>   config I2C
>          tristate "I2C support"
>   ...
>   config I2C_ACPI
>          bool "I2C ACPI support"
>          select I2C
>          depends on ACPI
>    ...
> 
> where if I2C_APCI is on (y), then that "select I2C" will cause I2C to
> be upgraded to 'y' as well.
> 
> This seems to be intentional, judging by the commit message, but it's
> wrong. Distributions etc generally compile i2c as a module, and you've
> now broken that.
> 
> This is a regression. Change the "select I2C" to a "depends on I2C",
> and test the end result. Don't force people to build things into the
> kernel.

Hi Linus:
	Sorry about this, I will create a fix patch soon. Thanks.

> 
>                  Linus
> 


-- 
Best regards
Tianyu Lan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PULL REQUEST] i2c for 3.17
@ 2014-10-03 21:10 Wolfram Sang
  0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2014-10-03 21:10 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Linus,

here are two i2c driver bugfixes which would be nice to have in 3.17.

Thanks,

   Wolfram


The following changes since commit fe82dcec644244676d55a1384c958d5f67979adb:

  Linux 3.17-rc7 (2014-09-28 14:29:07 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current

for you to fetch changes up to 86b59bbfae2a895aa26b3d15f31b1a705dbfede1:

  i2c: qup: Fix order of runtime pm initialization (2014-10-03 03:20:47 +0200)

----------------------------------------------------------------
Alexandru M Stan (1):
      i2c: rk3x: fix 0 length write transfers

Andy Gross (1):
      i2c: qup: Fix order of runtime pm initialization

 drivers/i2c/busses/i2c-qup.c  | 12 ++++++++----
 drivers/i2c/busses/i2c-rk3x.c |  2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PULL REQUEST] i2c for 3.17
@ 2014-09-25 18:41 Wolfram Sang
  0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2014-09-25 18:41 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-i2c, linux-kernel, Jean Delvare, Mika Westerberg

[-- Attachment #1: Type: text/plain, Size: 3018 bytes --]

Linus,

this is probably not the kind of pull request you want to see that late
in the cycle. Yet, the ACPI refactorization was problematic again and
caused another two issues which need fixing. My holidays with limited
internet (plus travelling) and the developer's illness didn't help
either :(

The details:

- ACPI code was refactored out into a seperate file and as a
  side-effect, the i2c-core module got renamed. Jean Delvare rightfully
  complained about the rename being problematic for distributions. So,
  Mika and I thought the least problematic way to deal with it is to move
  all the code back into the main i2c core source file. This is mainly a
  huge code move with some #ifdeffery applied. No functional code changes.
  Our personal tests and the testbots did not find problems. (I was
  thinking about reverting, too, yet that would also have ~800 lines
  changed)

- The new ACPI code also had a NULL pointer exception, thanks to Peter
  for finding and fixing it.

- Mikko fixed a locking problem by decoupling clock_prepare and
  clock_enable.

- Addy learnt that the datasheet was wrong and reimplemented the
  frequency setup according to the new algorithm.

- Fan fixed an off-by-one error when copying data

- Janusz fixed a copy'n'paste bug which gave a wrong error message

- Sergei made sure that "don't touch" bits are not accessed

Please pull.

Thanks,

   Wolfram


The following changes since commit 9e82bf014195d6f0054982c463575cdce24292be:

  Linux 3.17-rc5 (2014-09-14 17:50:12 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current

for you to fetch changes up to 0aef44e84ad16cd87a88df78773fd81ecca34f11:

  i2c: acpi: Fix NULL Pointer dereference (2014-09-25 16:08:15 +0200)

----------------------------------------------------------------
Fan Du (1):
      i2c: ismt: use correct length when copy buffer

Janusz Użycki (1):
      i2c: mxs: fix error message in pio transfer

Mikko Perttunen (1):
      i2c: tegra: Move clk_prepare/clk_set_rate to probe

Peter Hüwe (1):
      i2c: acpi: Fix NULL Pointer dereference

Sergei Shtylyov (1):
      i2c: rcar: fix RCAR_IRQ_ACK_{RECV|SEND}

Wolfram Sang (1):
      i2c: move acpi code back into the core

addy ke (1):
      i2c: rk3x: fix divisor calculation for SCL frequency

 MAINTAINERS                    |   1 -
 drivers/i2c/Makefile           |   5 +-
 drivers/i2c/busses/i2c-ismt.c  |   4 +-
 drivers/i2c/busses/i2c-mxs.c   |   2 +-
 drivers/i2c/busses/i2c-rcar.c  |   4 +-
 drivers/i2c/busses/i2c-rk3x.c  |  11 +-
 drivers/i2c/busses/i2c-tegra.c |  57 +++++--
 drivers/i2c/i2c-acpi.c         | 364 -----------------------------------------
 drivers/i2c/i2c-core.c         | 364 +++++++++++++++++++++++++++++++++++++++++
 include/linux/i2c.h            |  16 --
 10 files changed, 420 insertions(+), 408 deletions(-)
 delete mode 100644 drivers/i2c/i2c-acpi.c

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PULL REQUEST] i2c for 3.17
@ 2014-09-05 19:41 Wolfram Sang
  0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2014-09-05 19:41 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

Linus,

here are I2C driver bugfixes for the 3.17 release. Details can be found
in the commit messages, yet I think this is typical driver stuff. Please
pull.

Thanks,

   Wolfram


The following changes since commit 69e273c0b0a3c337a521d083374c918dc52c666f:

  Linux 3.17-rc3 (2014-08-31 18:23:04 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current

for you to fetch changes up to 91bfe2989af02e709ca01ccf518c4fbda3efc70f:

  Revert "i2c: rcar: remove spinlock" (2014-09-04 19:59:42 +0200)

----------------------------------------------------------------
Chen-Yu Tsai (1):
      i2c: mv64xxx: continue probe when clock-frequency is missing

Marek Roszko (1):
      i2c: at91: add bound checking on SMBus block length bytes

Sergei Shtylyov (2):
      i2c: rcar: fix MNR interrupt handling
      Revert "i2c: rcar: remove spinlock"

Simon Lindgren (1):
      i2c: at91: Fix a race condition during signal handling in at91_do_twi_xfer.

addy ke (1):
      i2c: rk3x: fix bug that cause transfer fails in master receive mode

 drivers/i2c/busses/i2c-at91.c    | 32 ++++++++++++++++++++++++++------
 drivers/i2c/busses/i2c-mv64xxx.c |  3 +--
 drivers/i2c/busses/i2c-rcar.c    | 37 +++++++++++++++++++++++++++++++------
 drivers/i2c/busses/i2c-rk3x.c    |  4 ++++
 4 files changed, 62 insertions(+), 14 deletions(-)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PULL REQUEST] i2c for 3.17
@ 2014-08-21  3:25 Wolfram Sang
  0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2014-08-21  3:25 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

Linus,

here is the fixup for the 'lowlight' of my last pull request. I2C is not
selected anymore by I2C_ACPI. Instead, the code in question now depends
on I2C=y. Also, Mika has agreed to support me and be the maintainer for
I2C-ACPI related patches. Finally, a new-ID-patch came along last week.

Please pull,

   Wolfram


The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:

  Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next

for you to fetch changes up to 4560d67722816cca4b2f3dfb1d7c5b902fd2075b:

  MAINTAINERS: add maintainer for ACPI parts of I2C (2014-08-19 10:34:08 -0500)

----------------------------------------------------------------
Alan Cox (1):
      i2c: i801: Add PCI ID for Intel Braswell

Lan Tianyu (1):
      i2c: rework kernel config I2C_ACPI

Wolfram Sang (1):
      MAINTAINERS: add maintainer for ACPI parts of I2C

 MAINTAINERS                   |  7 +++++++
 drivers/i2c/Kconfig           | 15 ++++++---------
 drivers/i2c/Makefile          |  2 +-
 drivers/i2c/busses/i2c-i801.c |  2 ++
 drivers/i2c/i2c-acpi.c        |  2 ++
 include/linux/i2c.h           | 12 ++++++++----
 6 files changed, 26 insertions(+), 14 deletions(-)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-10-03 21:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 13:56 [PULL REQUEST] i2c for 3.17 Wolfram Sang
2014-08-09 17:34 ` Linus Torvalds
2014-08-11  1:39   ` Lan Tianyu
2014-08-21  3:25 Wolfram Sang
2014-09-05 19:41 Wolfram Sang
2014-09-25 18:41 Wolfram Sang
2014-10-03 21:10 Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).