From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "hui.liu" <hui.liu@mediatek.com>,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com
Cc: johnson.wang@mediatek.com, zhiyong.tao@mediatek.com,
sean.wang@mediatek.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for mt8188
Date: Fri, 22 Jul 2022 20:19:27 +0200 [thread overview]
Message-ID: <53d432e9-6715-05c4-d258-896ec38afa4f@linaro.org> (raw)
In-Reply-To: <ea7755e599ad8c06bc04b6249c2a6d0ab3b920f3.camel@mediatek.com>
On 22/07/2022 03:40, hui.liu wrote:
> Hi, Krzysztof
>
> That's the comment about reg and reg-names description:
>>> + reg:
>>> + description: |
>>> + Physical address base for gpio base registers. There are 8
>>> GPIO
>>> + physical address base in mt8188.
>>
>> Redundant description, skip it. You should list the instead and
>> describe
>> each of it.
>>
>>> + maxItems: 8
>>> +
>>> + reg-names:
>>> + description: |
>>> + Gpio base register names.
>>
>> Redundant description, skip it.
>>
>>> + maxItems: 8
>>
>> You need to list the items instead.
>
> I plan to update reg and reg-names as the following:
> reg:
> description: |
> Physical address base for gpio base registers. There are 6
> different GPIO physical address bases in mt8188.
> minItems: 6
> maxItems: 6
You should rather have here items with description:
items:
- description: what is it
- description: what is it
....
>
> reg-names:
> items:
> - const: iocfg0
> - const: iocfg_rm
> - const: iocfg_lt
> - const: iocfg_lm
> - const: iocfg_rt
> - const: eint
>
> Is it right?
>
> Thanks.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-22 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 11:38 [PATCH 0/3] Mediatek pinctrl patches for mt8188 Hui Liu
2022-07-18 11:38 ` [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition " Hui Liu
2022-07-18 14:08 ` Krzysztof Kozlowski
[not found] ` <08a7209fe198839093b3ef729fc97c1a950e1fbc.camel@mediatek.com>
2022-07-21 14:44 ` Krzysztof Kozlowski
[not found] ` <ea7755e599ad8c06bc04b6249c2a6d0ab3b920f3.camel@mediatek.com>
2022-07-22 18:19 ` Krzysztof Kozlowski [this message]
[not found] ` <9dbcee74667cdc77ad80c043bb7725c63ff1cbd2.camel@mediatek.com>
2022-07-26 9:45 ` Krzysztof Kozlowski
2022-07-18 14:12 ` Rob Herring
2022-07-18 11:38 ` [PATCH 2/3] dt-bindings: pinctrl: mt8188: add pinmux definition Hui Liu
2022-07-18 14:08 ` Krzysztof Kozlowski
2022-07-18 11:38 ` [PATCH 3/3] pinctrl: add pinctrl driver for mt8188 Hui Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53d432e9-6715-05c4-d258-896ec38afa4f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hui.liu@mediatek.com \
--cc=johnson.wang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).