From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geliang Tang <geliangtang@gmail.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mptcp: add some missing pr_fmt defines
Date: Fri, 3 Apr 2020 13:57:48 +0200 [thread overview]
Message-ID: <53e4271f-c881-c52d-c6e1-4930a4f6898a@tessares.net> (raw)
In-Reply-To: <f66ab0b7dfcc895d901e6e85b30f2a21842d2b2c.1585904950.git.geliangtang@gmail.com>
Hi Geliang,
On 03/04/2020 11:14, Geliang Tang wrote:
> Some of the mptcp logs didn't print out the format string:
>
> [ 185.651493] DSS
> [ 185.651494] data_fin=0 dsn64=0 use_map=0 ack64=1 use_ack=1
> [ 185.651494] data_ack=13792750332298763796
> [ 185.651495] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 data_avail=0 skb=0000000063dc595d
> [ 185.651495] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 status=0
> [ 185.651495] MPTCP: msk ack_seq=9bbc894565aa2f9a subflow ack_seq=9bbc894565aa2f9a
> [ 185.651496] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 data_avail=1 skb=0000000012e809e1
>
> So this patch added these missing pr_fmt defines. Then we can get the same
> format string "MPTCP" in all mptcp logs like this:
>
> [ 142.795829] MPTCP: DSS
> [ 142.795829] MPTCP: data_fin=0 dsn64=0 use_map=0 ack64=1 use_ack=1
> [ 142.795829] MPTCP: data_ack=8089704603109242421
> [ 142.795830] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 data_avail=0 skb=00000000d5f230df
> [ 142.795830] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 status=0
> [ 142.795831] MPTCP: msk ack_seq=66790290f1199d9b subflow ack_seq=66790290f1199d9b
> [ 142.795831] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 data_avail=1 skb=00000000de5aca2e
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
>
> ---
> Changes in v2:
> - add pr_fmt to C files, not headers.
Thank you for this v2 (sorry, it was in my spam folder).
I thought checkpatch.pl would have forced you to add a new blank line in
net/mptcp/pm.c after the copyright comment and before the beginning of
the code but it seems not. And there was no blank line before so I guess
it's OK like that!
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
next prev parent reply other threads:[~2020-04-03 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 7:57 [PATCH] mptcp: move pr_fmt defining to protocol.h Geliang Tang
2020-04-03 9:14 ` [PATCH v2] mptcp: add some missing pr_fmt defines Geliang Tang
2020-04-03 11:57 ` Matthieu Baerts [this message]
2020-04-03 23:06 ` David Miller
2020-04-03 10:29 ` [PATCH] mptcp: move pr_fmt defining to protocol.h Matthieu Baerts
2020-04-03 11:41 ` Geliang Tang
2020-04-03 11:49 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53e4271f-c881-c52d-c6e1-4930a4f6898a@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=davem@davemloft.net \
--cc=geliangtang@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).