From: Boaz Harrosh <openosd@gmail.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
Shakil A Khan <shakilk1729@gmail.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
William Andros Adamson <andros@netapp.com>,
Jeffrey Layton <jlayton@primarydata.com>,
"David S. Miller" <davem@davemloft.net>,
Bruce Fields <bfields@fieldses.org>
Subject: Re: [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire
Date: Tue, 02 Sep 2014 13:52:15 +0300 [thread overview]
Message-ID: <5405A15F.2060002@gmail.com> (raw)
In-Reply-To: <CAHQdGtQAwp_QuQE-xmjJNkcxbu7g4QtYQv8qrPT_qWpkym1GZg@mail.gmail.com>
On 09/01/2014 04:50 PM, Trond Myklebust wrote:
> On Mon, Sep 1, 2014 at 7:32 AM, Shakil A Khan <shakilk1729@gmail.com> wrote:
>> Signed-off-by : Shakil A Khan <shakilk1729@gmail.com>
>> ---
>> net/sunrpc/auth_gss/auth_gss.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
>> index afb292c..bea0951 100644
>> --- a/net/sunrpc/auth_gss/auth_gss.c
>> +++ b/net/sunrpc/auth_gss/auth_gss.c
>> @@ -1387,7 +1387,7 @@ gss_key_timeout(struct rpc_cred *rc)
>> struct gss_cred *gss_cred = container_of(rc, struct gss_cred, gc_base);
>> struct gss_cl_ctx *ctx;
>> unsigned long now = jiffies;
>> - unsigned long expire;
>> + unsigned long expire = 0;
>>
>> rcu_read_lock();
>> ctx = rcu_dereference(gss_cred->gc_ctx);
>> --
>> 1.7.1
>
> That would be a compiler bug, not a kernel bug. The kernel code is
> perfectly correct as it stands, and will never access the
> uninitialised variable.
>
Than you will need the infamous uninitialised_var()
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index afb292c..bea0951 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -1387,7 +1387,7 @@ gss_key_timeout(struct rpc_cred *rc)
struct gss_cred *gss_cred = container_of(rc, struct gss_cred, gc_base);
struct gss_cl_ctx *ctx;
unsigned long now = jiffies;
- unsigned long expire;
+ unsigned long uninitialised_var(expire);
rcu_read_lock();
ctx = rcu_dereference(gss_cred->gc_ctx);
Cheers
Boaz
next prev parent reply other threads:[~2014-09-02 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 11:32 [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire Shakil A Khan
2014-09-01 13:50 ` Trond Myklebust
2014-09-02 10:52 ` Boaz Harrosh [this message]
2014-09-02 13:21 ` Bruce Fields
2014-09-02 13:59 ` Boaz Harrosh
2014-09-02 14:17 ` Bruce Fields
2014-09-02 16:05 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5405A15F.2060002@gmail.com \
--to=openosd@gmail.com \
--cc=andros@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=jlayton@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=shakilk1729@gmail.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).