From: Boaz Harrosh <openosd@gmail.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Shakil A Khan <shakilk1729@gmail.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
William Andros Adamson <andros@netapp.com>,
Jeffrey Layton <jlayton@primarydata.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire
Date: Tue, 02 Sep 2014 16:59:45 +0300 [thread overview]
Message-ID: <5405CD51.9020601@gmail.com> (raw)
In-Reply-To: <20140902132140.GA31793@fieldses.org>
On 09/02/2014 04:21 PM, Bruce Fields wrote:
>
> You'd rather avoid sprinkling that all over, though. If nothing else it
> increases the chances you'll suppress a legimate warning some day.
>
But this is exactly why it was created.
If you do the "= 0" then it is gone forever. If you have missed a legitimate
needed assignment, it will be missed as well.
But if you do the uninitialized_var() dance then there is a make option that turns
it off and every once in a while people do a make with it to see if it still
holds.
The diff between foo = 0; and uninitialized_var(foo) is that the programmer is
communicating to his friends that:
"I have encountered a bogus compiler, this is falsely initialized"
As opposed to =0 the compiler bug is covered up and forgotten
> And unless I'm missing something this one really does look like an
> unambiguous compiler bug.
>
Right! so that is how you specify this in code at Linux: uninitialized_var(foo);
Putting =0 is way way worse, because it will never be revised and specially
not automatically with a make switch.
And leaving the warning on is even worse because two three of these and people
start to ignore warnings.
> --b.
>
uninitialized_var was made to be a friend not an enemy, in the face of real
ugliness it is the best we can do. And that is what it should communicate to
everyone. Why has it become everyone's favorite blasphemy I do not know.
Cheers
Boaz
next prev parent reply other threads:[~2014-09-02 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 11:32 [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire Shakil A Khan
2014-09-01 13:50 ` Trond Myklebust
2014-09-02 10:52 ` Boaz Harrosh
2014-09-02 13:21 ` Bruce Fields
2014-09-02 13:59 ` Boaz Harrosh [this message]
2014-09-02 14:17 ` Bruce Fields
2014-09-02 16:05 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5405CD51.9020601@gmail.com \
--to=openosd@gmail.com \
--cc=andros@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=jlayton@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=shakilk1729@gmail.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).