linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Dmitry Lifshitz <lifshitz@compulab.co.il>,
	Felipe Balbi <balbi@ti.com>,
	George Cherian <george.cherian@ti.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, <bcousson@baylibre.com>,
	<tony@atomide.com>, <rob.herring@calxeda.com>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<swarren@wwwdotorg.org>, <ijc+devicetree@hellion.org.uk>,
	<linux@arm.linux.org.uk>, <linux-omap@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Date: Mon, 8 Sep 2014 14:39:08 +0300	[thread overview]
Message-ID: <540D955C.6060602@ti.com> (raw)
In-Reply-To: <540D9449.3090008@compulab.co.il>

On 09/08/2014 02:34 PM, Dmitry Lifshitz wrote:
> Hi Felipe, Roger
> 
> On 04/16/2014 07:16 PM, Felipe Balbi wrote:
>> On Fri, Oct 11, 2013 at 05:46:12PM +0300, Roger Quadros wrote:
>>> Hi,
>>>
>>> On 10/10/2013 01:49 PM, Kishon Vijay Abraham I wrote:
>>>> From: George Cherian <george.cherian@ti.com>
>>>>
>>>> Added dr_mode property in dwc3 and set its default mode to device.
>>>
>>> If there is a specific reason why this is not set to "otg", we need
>>> to explain it here.
>>>
>>> AFAIK the port is meant to be used as OTG port.
>>
>> we still don't have the workaround for dual role ports, I've been
>> working on it but still need to retest and make sure it's working fine
>> before merging upstream.
>>
> 
> 
> Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
> 
> I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
> 
> If I set CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).
> 
> CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET bring port to appropriate mode and it works.
> 
> What is the purpose of setting dr_mode = "peripheral" in omap5.dtsi, since it is overridden by config options in dwc3_probe()?

If dual role works it should be "otg" then. I'm not sure why it was set to peripheral. Maybe the role switching mechanism
was not in place earlier.

George any objections for "otg"?

cheers,
-roger

  reply	other threads:[~2014-09-08 11:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10 10:49 [PATCH 1/2] ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1 Kishon Vijay Abraham I
2013-10-10 10:49 ` [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3 Kishon Vijay Abraham I
2013-10-11 14:46   ` Roger Quadros
2013-10-15  5:49     ` [PATCH v2 " Kishon Vijay Abraham I
2013-10-16 13:17       ` Kishon Vijay Abraham I
2013-10-17 20:08         ` Benoit Cousson
2013-10-21 10:03           ` Kishon Vijay Abraham I
2014-04-16 16:16     ` [PATCH " Felipe Balbi
2014-04-16 16:22       ` Felipe Balbi
2014-09-08 11:34       ` Dmitry Lifshitz
2014-09-08 11:39         ` Roger Quadros [this message]
2014-09-08 12:32           ` Dmitry Lifshitz
2014-09-08 13:25             ` Felipe Balbi
2014-09-08 13:24         ` Felipe Balbi
2014-09-10 12:03           ` Dmitry Lifshitz
2014-09-11 17:14             ` Felipe Balbi
2013-10-10 14:19 ` [PATCH 1/2] ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1 Nishanth Menon
2013-10-11  6:13   ` Kishon Vijay Abraham I
2013-10-11  6:30     ` Nishanth Menon
2013-10-11  6:53       ` Kishon Vijay Abraham I
2013-10-11  6:54         ` Kishon Vijay Abraham I
2013-10-11  7:27           ` Nishanth Menon
2013-10-16 13:17 ` Kishon Vijay Abraham I
2013-10-16 13:27   ` Nishanth Menon
2013-10-17 20:09     ` Benoit Cousson
2013-10-21 10:03       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540D955C.6060602@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kishon@ti.com \
    --cc=lifshitz@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).