From: Nishanth Menon <nm@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
dt list <devicetree@vger.kernel.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
Tony Lindgren <tony@atomide.com>,
Stephen Warren <swarren@wwwdotorg.org>,
lkml <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
Benoit Cousson <bcousson@baylibre.com>,
linux-omap <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1
Date: Fri, 11 Oct 2013 02:27:02 -0500 [thread overview]
Message-ID: <CAGo_u6q-5v05nou+WSw_scWgUDHYXMELtaMGXu7Vk2Wx4pNqog@mail.gmail.com> (raw)
In-Reply-To: <5257A0C0.8000701@ti.com>
On Fri, Oct 11, 2013 at 1:54 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> On Friday 11 October 2013 12:23 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Friday 11 October 2013 12:00 PM, Nishanth Menon wrote:
>>> On Fri, Oct 11, 2013 at 1:13 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>>>
>>>>> regulator-boot-on indicates that PMIC enables it by default as part of
>>>>> OTP or some internal behavior -> Looking at the measurements done on
>>>>> uEVM and OTP information -> regulator-boot-on should be kept here.
>>>>
>>>> No. Actually I don’t want PMIC to enable it by default. I want the palmas-usb
>>>> driver to handle it.
>>>> Enabling it by default makes palmas-usb to detect VBUS interrupt. This should
>>>> ideally be detected only when you connect a host cable.
>>>> Btw I didn't exactly get why you want regulator-boot-on should be kept here.
>>>
>>> binding description states:
>>> - regulator-boot-on: bootloader/firmware enabled regulator
>>> Further info: include/linux/regulator/machine.h
>>> * @boot_on: Set if the regulator is enabled when the system is initially
>>> * started. If the regulator is not enabled by the hardware or
>>> * bootloader then it will be enabled when the constraints are
>>> * applied.
>>>
>>> What that means is that it is enabled by firmware/bootloader (in our
>>> case One Time Program {OTP} inside Palmas) when the system switches on
>>> even before the kernel starts. and we know SMPS10 is autoenabled by
>>> Palmas OTP configuration even before first instruction in A15
>>> executes.
>>
>> Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I
>> tend to think that it might be OUT2 that's getting enabled by the OTP.
>>>
>>> I think you misunderstand this to mean that you'd like the regulator
>>> to be *switched on* automatically at kernel boot by regulator
>>> framework - there is no reasoning why we'd want such a binding since
>>> we'd expect drivers to do their job of requesting and enabling
>>> regulators on need..
>>
>> The comment you just quoted tells it enables the regulator if its not enabled
>> by hardware. "If the regulator is not enabled by the hardware or bootloader
>> then it will be enabled when the constraints are applied." At-least that's what
>> I understood from that comment.
>>
>> Also from our experiments it doesn't look like SMPS10_OUT1 is enabled by the
>> OTP and it gets enabled when we have *regulator-boot-on* constraints.
>
> btw.. I think this is the code in regulator fw that's responsible for enabling..
>
> /* If the constraints say the regulator should be on at this point
> * and we have control then make sure it is enabled.
> */
> if ((rdev->constraints->always_on || rdev->constraints->boot_on) &&
> ops->enable) {
> ret = ops->enable(rdev);
> if (ret < 0) {
> rdev_err(rdev, "failed to enable\n");
> goto out;
> }
> }
Drat, you are right, I did not really dig deep. thanks for correcting
my understanding here.
I propose the following change in binding as it seems completely
misleading to me.
diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt
b/Documentation/devicetree/bindings/regulator/regulator.txt
index 2bd8f09..d999f096 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/regulator.txt
@@ -8,7 +8,9 @@ Optional properties:
- regulator-min-microamp: smallest current consumers may set
- regulator-max-microamp: largest current consumers may set
- regulator-always-on: boolean, regulator should never be disabled
-- regulator-boot-on: bootloader/firmware enabled regulator
+- regulator-boot-on: regulator is enabled when the system is initially started.
+ If the regulator is not enabled by the hardware or bootloader then it will be
+ enabled when the constraints are applied.
- regulator-allow-bypass: allow the regulator to go into bypass mode
- <name>-supply: phandle to the parent supply/regulator node
- regulator-ramp-delay: ramp delay for regulator(in uV/uS)
next prev parent reply other threads:[~2013-10-11 7:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 10:49 [PATCH 1/2] ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1 Kishon Vijay Abraham I
2013-10-10 10:49 ` [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3 Kishon Vijay Abraham I
2013-10-11 14:46 ` Roger Quadros
2013-10-15 5:49 ` [PATCH v2 " Kishon Vijay Abraham I
2013-10-16 13:17 ` Kishon Vijay Abraham I
2013-10-17 20:08 ` Benoit Cousson
2013-10-21 10:03 ` Kishon Vijay Abraham I
2014-04-16 16:16 ` [PATCH " Felipe Balbi
2014-04-16 16:22 ` Felipe Balbi
2014-09-08 11:34 ` Dmitry Lifshitz
2014-09-08 11:39 ` Roger Quadros
2014-09-08 12:32 ` Dmitry Lifshitz
2014-09-08 13:25 ` Felipe Balbi
2014-09-08 13:24 ` Felipe Balbi
2014-09-10 12:03 ` Dmitry Lifshitz
2014-09-11 17:14 ` Felipe Balbi
2013-10-10 14:19 ` [PATCH 1/2] ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1 Nishanth Menon
2013-10-11 6:13 ` Kishon Vijay Abraham I
2013-10-11 6:30 ` Nishanth Menon
2013-10-11 6:53 ` Kishon Vijay Abraham I
2013-10-11 6:54 ` Kishon Vijay Abraham I
2013-10-11 7:27 ` Nishanth Menon [this message]
2013-10-16 13:17 ` Kishon Vijay Abraham I
2013-10-16 13:27 ` Nishanth Menon
2013-10-17 20:09 ` Benoit Cousson
2013-10-21 10:03 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGo_u6q-5v05nou+WSw_scWgUDHYXMELtaMGXu7Vk2Wx4pNqog@mail.gmail.com \
--to=nm@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).