linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: disable vdso_test to avoid breakage with old glibc
@ 2014-09-17  0:09 Peter Foley
  2014-09-18  0:23 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2014-09-17  0:09 UTC (permalink / raw)
  To: linux-kernel, linux-doc, rdunlap; +Cc: sfr, Peter Foley

glibc versions older than 2.16 don't include sys/auxv.h which this
executable uses.
Since we don't have a good way to test for specific glibc versions in
kbuild, just disable it for now.

Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
 Documentation/vDSO/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
index d87bb29..2b99e57 100644
--- a/Documentation/vDSO/Makefile
+++ b/Documentation/vDSO/Makefile
@@ -1,5 +1,5 @@
-# List of programs to build
-hostprogs-y := vdso_test
+# vdso_test won't build for glibc < 2.16, so disable it
+# hostprogs-y := vdso_test
 hostprogs-$(CONFIG_X86) := vdso_standalone_test_x86
 vdso_standalone_test_x86-objs := vdso_standalone_test_x86.o parse_vdso.o
 vdso_test-objs := parse_vdso.o vdso_test.o
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation: disable vdso_test to avoid breakage with old glibc
  2014-09-17  0:09 [PATCH] Documentation: disable vdso_test to avoid breakage with old glibc Peter Foley
@ 2014-09-18  0:23 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2014-09-18  0:23 UTC (permalink / raw)
  To: Peter Foley, linux-kernel, linux-doc; +Cc: sfr

On 09/16/14 17:09, Peter Foley wrote:
> glibc versions older than 2.16 don't include sys/auxv.h which this
> executable uses.
> Since we don't have a good way to test for specific glibc versions in
> kbuild, just disable it for now.
> 
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>

Applied.  Thanks.

> ---
>  Documentation/vDSO/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
> index d87bb29..2b99e57 100644
> --- a/Documentation/vDSO/Makefile
> +++ b/Documentation/vDSO/Makefile
> @@ -1,5 +1,5 @@
> -# List of programs to build
> -hostprogs-y := vdso_test
> +# vdso_test won't build for glibc < 2.16, so disable it
> +# hostprogs-y := vdso_test
>  hostprogs-$(CONFIG_X86) := vdso_standalone_test_x86
>  vdso_standalone_test_x86-objs := vdso_standalone_test_x86.o parse_vdso.o
>  vdso_test-objs := parse_vdso.o vdso_test.o
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-18  0:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17  0:09 [PATCH] Documentation: disable vdso_test to avoid breakage with old glibc Peter Foley
2014-09-18  0:23 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).