* [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250.
@ 2014-09-17 3:07 Jonghwa Lee
2014-09-17 8:53 ` Vikas Sajjan
0 siblings, 1 reply; 3+ messages in thread
From: Jonghwa Lee @ 2014-09-17 3:07 UTC (permalink / raw)
To: linux-samsung-soc, linux-arm-kernel, linux-kernel; +Cc: kgene.kim, Jonghwa Lee
Add rtc alarm and tick irq to wakeup sources in exynos3250.
Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Acked-by : Chanwoo choi <cw00.choi@samsung.com>
---
arch/arm/mach-exynos/pm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
index fa7218a..d78dcf9 100644
--- a/arch/arm/mach-exynos/pm.c
+++ b/arch/arm/mach-exynos/pm.c
@@ -66,6 +66,12 @@ static struct sleep_save exynos_core_save[] = {
static u32 exynos_irqwake_intmask = 0xffffffff;
+static const struct exynos_wkup_irq exynos3250_wkup_irq[] = {
+ { 105, BIT(1) }, /* RTC alarm */
+ { 106, BIT(2) }, /* RTC tick */
+ { /* sentinel */ },
+};
+
static const struct exynos_wkup_irq exynos4_wkup_irq[] = {
{ 76, BIT(1) }, /* RTC alarm */
{ 77, BIT(2) }, /* RTC tick */
@@ -81,9 +87,10 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
static int exynos_irq_set_wake(struct irq_data *data, unsigned int state)
{
const struct exynos_wkup_irq *wkup_irq;
-
if (soc_is_exynos5250())
wkup_irq = exynos5250_wkup_irq;
+ else if (soc_is_exynos3250())
+ wkup_irq = exynos3250_wkup_irq;
else
wkup_irq = exynos4_wkup_irq;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250.
2014-09-17 3:07 [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250 Jonghwa Lee
@ 2014-09-17 8:53 ` Vikas Sajjan
2014-09-18 2:04 ` jonghwa3.lee
0 siblings, 1 reply; 3+ messages in thread
From: Vikas Sajjan @ 2014-09-17 8:53 UTC (permalink / raw)
To: Jonghwa Lee; +Cc: linux-samsung-soc, linux-arm-kernel, linux-kernel, Kukjin Kim
Hi,
On Wed, Sep 17, 2014 at 8:52 AM, Jonghwa Lee <jonghwa3.lee@samsung.com> wrote:
> Add rtc alarm and tick irq to wakeup sources in exynos3250.
>
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> Acked-by : Chanwoo choi <cw00.choi@samsung.com>
> ---
> arch/arm/mach-exynos/pm.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
> index fa7218a..d78dcf9 100644
> --- a/arch/arm/mach-exynos/pm.c
> +++ b/arch/arm/mach-exynos/pm.c
> @@ -66,6 +66,12 @@ static struct sleep_save exynos_core_save[] = {
>
> static u32 exynos_irqwake_intmask = 0xffffffff;
>
> +static const struct exynos_wkup_irq exynos3250_wkup_irq[] = {
> + { 105, BIT(1) }, /* RTC alarm */
> + { 106, BIT(2) }, /* RTC tick */
> + { /* sentinel */ },
> +};
> +
> static const struct exynos_wkup_irq exynos4_wkup_irq[] = {
> { 76, BIT(1) }, /* RTC alarm */
> { 77, BIT(2) }, /* RTC tick */
> @@ -81,9 +87,10 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
> static int exynos_irq_set_wake(struct irq_data *data, unsigned int state)
> {
> const struct exynos_wkup_irq *wkup_irq;
> -
> if (soc_is_exynos5250())
> wkup_irq = exynos5250_wkup_irq;
> + else if (soc_is_exynos3250())
> + wkup_irq = exynos3250_wkup_irq;
Don't add anymore soc_is_exynosxxx() checks, please rebase on [1],
which refactors the pm.c to use DT based lookup.
[1] http://www.spinics.net/lists/arm-kernel/msg355266.html
> else
> wkup_irq = exynos4_wkup_irq;
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250.
2014-09-17 8:53 ` Vikas Sajjan
@ 2014-09-18 2:04 ` jonghwa3.lee
0 siblings, 0 replies; 3+ messages in thread
From: jonghwa3.lee @ 2014-09-18 2:04 UTC (permalink / raw)
To: Vikas Sajjan
Cc: linux-samsung-soc, linux-arm-kernel, linux-kernel, Kukjin Kim
On 2014년 09월 17일 17:53, Vikas Sajjan wrote:
> Hi,
>
> On Wed, Sep 17, 2014 at 8:52 AM, Jonghwa Lee <jonghwa3.lee@samsung.com> wrote:
>> Add rtc alarm and tick irq to wakeup sources in exynos3250.
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
>> Acked-by : Chanwoo choi <cw00.choi@samsung.com>
>> ---
>> arch/arm/mach-exynos/pm.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
>> index fa7218a..d78dcf9 100644
>> --- a/arch/arm/mach-exynos/pm.c
>> +++ b/arch/arm/mach-exynos/pm.c
>> @@ -66,6 +66,12 @@ static struct sleep_save exynos_core_save[] = {
>>
>> static u32 exynos_irqwake_intmask = 0xffffffff;
>>
>> +static const struct exynos_wkup_irq exynos3250_wkup_irq[] = {
>> + { 105, BIT(1) }, /* RTC alarm */
>> + { 106, BIT(2) }, /* RTC tick */
>> + { /* sentinel */ },
>> +};
>> +
>> static const struct exynos_wkup_irq exynos4_wkup_irq[] = {
>> { 76, BIT(1) }, /* RTC alarm */
>> { 77, BIT(2) }, /* RTC tick */
>> @@ -81,9 +87,10 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
>> static int exynos_irq_set_wake(struct irq_data *data, unsigned int state)
>> {
>> const struct exynos_wkup_irq *wkup_irq;
>> -
>> if (soc_is_exynos5250())
>> wkup_irq = exynos5250_wkup_irq;
>> + else if (soc_is_exynos3250())
>> + wkup_irq = exynos3250_wkup_irq;
>
>
> Don't add anymore soc_is_exynosxxx() checks, please rebase on [1],
> which refactors the pm.c to use DT based lookup.
>
> [1] http://www.spinics.net/lists/arm-kernel/msg355266.html
>
Okay, I'll wait those patches are merged, then I'll rebase and repost it.
Thanks,
Jonghwa.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-18 2:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17 3:07 [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250 Jonghwa Lee
2014-09-17 8:53 ` Vikas Sajjan
2014-09-18 2:04 ` jonghwa3.lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).