linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	Doug Anderson <dianders@chromium.org>,
	Daniel Drake <drake@endlessm.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow
Date: Mon, 22 Sep 2014 15:44:52 +0900	[thread overview]
Message-ID: <541FC564.8000002@samsung.com> (raw)
In-Reply-To: <1410954633-27025-3-git-send-email-javier.martinez@collabora.co.uk>

Dear Javier,

On 09/17/2014 08:50 PM, Javier Martinez Canillas wrote:
> commit 546b117fdf17 ("rtc: s3c: add support for RTC of Exynos3250 SoC")
> added an "rtc_src" DT property for the Samsung's S3C Real Time Clock
> controller that specifies the 32.768 kHz clock that uses the RTC as its
> source clock. In the case of the Exynos5250 based Snow board, the Maxim
> 77686 32kHz AP clock is used as the source clock.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index e51fcef..56eec56 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -10,6 +10,7 @@
>  
>  /dts-v1/;
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/clock/maxim,max77686.h>
>  #include "exynos5250.dtsi"
>  
>  / {
> @@ -29,6 +30,8 @@
>  
>  	rtc@101E0000 {
>  		status = "okay";
> +		clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
> +		clock-names = "rtc", "rtc_src";
>  	};
>  
>  	pinctrl@11400000 {
> @@ -350,7 +353,7 @@
>  	samsung,i2c-sda-delay = <100>;
>  	samsung,i2c-max-bus-freq = <378000>;
>  
> -	max77686@09 {
> +	max77686: max77686@09 {
>  		compatible = "maxim,max77686";
>  		interrupt-parent = <&gpx3>;
>  		interrupts = <2 0>;
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi


      parent reply	other threads:[~2014-09-22  6:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 11:50 [PATCH 0/2] s3c RTC fix for Exynos Chromebooks Javier Martinez Canillas
2014-09-17 11:50 ` [PATCH 1/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos Peach boards Javier Martinez Canillas
2014-09-17 15:24   ` Doug Anderson
2014-09-22  6:41   ` Chanwoo Choi
2014-09-17 11:50 ` [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow Javier Martinez Canillas
2014-09-17 15:47   ` Doug Anderson
2014-09-17 15:51     ` Andreas Färber
2014-09-22 12:09       ` Kukjin Kim
2014-09-23  6:17       ` Kukjin Kim
2014-09-23 16:00         ` Kukjin Kim
2014-09-23 16:18           ` Javier Martinez Canillas
2014-09-24 21:41             ` Javier Martinez Canillas
2014-09-24 23:27               ` Kukjin Kim
2014-09-25  7:18                 ` Javier Martinez Canillas
2014-09-18  6:48     ` Javier Martinez Canillas
2014-09-22  6:44   ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541FC564.8000002@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=dianders@chromium.org \
    --cc=drake@endlessm.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).