From: Kukjin Kim <kgene.kim@samsung.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: "Kukjin Kim" <kgene.kim@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"'Doug Anderson'" <dianders@chromium.org>,
'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"'Daniel Drake'" <drake@endlessm.com>,
"'Chanwoo Choi'" <cw00.choi@samsung.com>,
"'Andreas Färber'" <afaerber@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow
Date: Thu, 25 Sep 2014 08:27:28 +0900 [thread overview]
Message-ID: <54235360.7090303@samsung.com> (raw)
In-Reply-To: <54233A84.7040902@collabora.co.uk>
On 09/25/14 06:41, Javier Martinez Canillas wrote:
> Hello Kukjin,
>
Hi,
> On 09/23/2014 06:18 PM, Javier Martinez Canillas wrote:
>> On 09/23/2014 06:00 PM, Kukjin Kim wrote:
>>> On 09/23/14 15:17, Kukjin Kim wrote:
>>>
>>> I've applied above and this series and please double-check the commits
>>> in my tree. If no problems, I will send the branch out for v3.18 soon...
>>>
>>> Thanks,
>>> Kukjin
>>>
>>
>> I've looked the RTC source clock patches and look good to me. Thanks a lot for your help!
>>
>
> Today I also had time to review the rebased patches from Andreas and found
> two issues introduced during the merge conflict resolution:
>
Oops. Thanks for your quick fix it up.
> 1) The spi_1 dev node on exynos5250-smdk5250.dts now uses the old "cs-gpio"
> DT property under the controller-data instead of the standard "cs-gpios"
> under the SPI parent. IOW, is a regression of the bug fixed in commit
> e138d43 ("ARM: dts: fix the chip select gpios definition in the SPI nodes").
>
> 2) The display-timings child node of the dp-controller was removed in commit
> a98c3c2 ("ARM: dts: update display related nodes for exynos5250-snow") but
> was introduced again in the Snow DTS during the merge.
>
> I'll post a series that fixes both issues with the following patches:
>
I've applied them.
> Javier Martinez Canillas (2):
> ARM: dts: Fix chip select GPIO on smdk5250
> ARM: dts: Remove display timings node from exynos5250-snow
>
> I see that you already send a pull request to arm-soc maintainers so probably
> these will be part of the fixes during the 3.18 rc cycle.
>
I'll queue them in my third pull-request maybe today :)
Thanks,
Kukjin
next prev parent reply other threads:[~2014-09-24 23:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 11:50 [PATCH 0/2] s3c RTC fix for Exynos Chromebooks Javier Martinez Canillas
2014-09-17 11:50 ` [PATCH 1/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos Peach boards Javier Martinez Canillas
2014-09-17 15:24 ` Doug Anderson
2014-09-22 6:41 ` Chanwoo Choi
2014-09-17 11:50 ` [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow Javier Martinez Canillas
2014-09-17 15:47 ` Doug Anderson
2014-09-17 15:51 ` Andreas Färber
2014-09-22 12:09 ` Kukjin Kim
2014-09-23 6:17 ` Kukjin Kim
2014-09-23 16:00 ` Kukjin Kim
2014-09-23 16:18 ` Javier Martinez Canillas
2014-09-24 21:41 ` Javier Martinez Canillas
2014-09-24 23:27 ` Kukjin Kim [this message]
2014-09-25 7:18 ` Javier Martinez Canillas
2014-09-18 6:48 ` Javier Martinez Canillas
2014-09-22 6:44 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54235360.7090303@samsung.com \
--to=kgene.kim@samsung.com \
--cc=afaerber@suse.de \
--cc=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=drake@endlessm.com \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).