* [PATCH v3] xen/xenbus: Correct the comments for xenbus_grant_ring()
@ 2014-09-26 15:34 Chen Gang
2014-09-26 18:08 ` David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-09-26 15:34 UTC (permalink / raw)
To: David Vrabel; +Cc: xen-devel, linux-kernel
A grant reference (which is a positive number) can indicate success, so
the original comments need be improved.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/xen/xenbus/xenbus_client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
index 439c9dc..aa9b2fc 100644
--- a/drivers/xen/xenbus/xenbus_client.c
+++ b/drivers/xen/xenbus/xenbus_client.c
@@ -361,8 +361,8 @@ static void xenbus_switch_fatal(struct xenbus_device *dev, int depth, int err,
* @ring_mfn: mfn of ring to grant
* Grant access to the given @ring_mfn to the peer of the given device. Return
- * 0 on success, or -errno on error. On error, the device will switch to
- * XenbusStateClosing, and the error will be saved in the store.
+ * a grant reference on success, or -errno on error. On error, the device will
+ * switch to XenbusStateClosing, and the error will be saved in the store.
*/
int xenbus_grant_ring(struct xenbus_device *dev, unsigned long ring_mfn)
{
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] xen/xenbus: Correct the comments for xenbus_grant_ring()
2014-09-26 15:34 [PATCH v3] xen/xenbus: Correct the comments for xenbus_grant_ring() Chen Gang
@ 2014-09-26 18:08 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2014-09-26 18:08 UTC (permalink / raw)
To: Chen Gang; +Cc: xen-devel, linux-kernel
On 26/09/14 16:34, Chen Gang wrote:
> A grant reference (which is a positive number) can indicate success, so
> the original comments need be improved.
Applied to devel/for-linus-3.18.
Thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-26 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-26 15:34 [PATCH v3] xen/xenbus: Correct the comments for xenbus_grant_ring() Chen Gang
2014-09-26 18:08 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).