From: Randy Dunlap <rdunlap@infradead.org>
To: YueHaibing <yuehaibing@huawei.com>,
bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, efremov@linux.com,
andriy.shevchenko@linux.intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI
Date: Mon, 31 Aug 2020 21:07:54 -0700 [thread overview]
Message-ID: <5427fca0-6674-42e9-a3b1-52b060ef0301@infradead.org> (raw)
In-Reply-To: <20200901035825.25256-1-yuehaibing@huawei.com>
On 8/31/20 8:58 PM, YueHaibing wrote:
> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> acpi_noirq_set();
> ^~~~~~~~~~~~~~
> acpi_irq_get
>
> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Bjorn has merged my patch (or so his email says), but apparently it's not
in linux-next yet.
> ---
> arch/x86/pci/intel_mid_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index 00c62115f39c..0aaf31917061 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -33,6 +33,7 @@
> #include <asm/hw_irq.h>
> #include <asm/io_apic.h>
> #include <asm/intel-mid.h>
> +#include <asm/acpi.h>
>
> #define PCIE_CAP_OFFSET 0x100
>
>
thanks.
--
~Randy
next prev parent reply other threads:[~2020-09-01 4:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 3:58 [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI YueHaibing
2020-09-01 4:07 ` Randy Dunlap [this message]
2020-09-01 6:17 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5427fca0-6674-42e9-a3b1-52b060ef0301@infradead.org \
--to=rdunlap@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=efremov@linux.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).