* [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI
@ 2020-09-01 3:58 YueHaibing
2020-09-01 4:07 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-09-01 3:58 UTC (permalink / raw)
To: bhelgaas, tglx, mingo, bp, x86, hpa, efremov, andriy.shevchenko
Cc: linux-pci, linux-kernel, YueHaibing
arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
acpi_noirq_set();
^~~~~~~~~~~~~~
acpi_irq_get
Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/x86/pci/intel_mid_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 00c62115f39c..0aaf31917061 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/arch/x86/pci/intel_mid_pci.c
@@ -33,6 +33,7 @@
#include <asm/hw_irq.h>
#include <asm/io_apic.h>
#include <asm/intel-mid.h>
+#include <asm/acpi.h>
#define PCIE_CAP_OFFSET 0x100
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI
2020-09-01 3:58 [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI YueHaibing
@ 2020-09-01 4:07 ` Randy Dunlap
2020-09-01 6:17 ` Yuehaibing
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-09-01 4:07 UTC (permalink / raw)
To: YueHaibing, bhelgaas, tglx, mingo, bp, x86, hpa, efremov,
andriy.shevchenko
Cc: linux-pci, linux-kernel
On 8/31/20 8:58 PM, YueHaibing wrote:
> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> acpi_noirq_set();
> ^~~~~~~~~~~~~~
> acpi_irq_get
>
> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Bjorn has merged my patch (or so his email says), but apparently it's not
in linux-next yet.
> ---
> arch/x86/pci/intel_mid_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index 00c62115f39c..0aaf31917061 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -33,6 +33,7 @@
> #include <asm/hw_irq.h>
> #include <asm/io_apic.h>
> #include <asm/intel-mid.h>
> +#include <asm/acpi.h>
>
> #define PCIE_CAP_OFFSET 0x100
>
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI
2020-09-01 4:07 ` Randy Dunlap
@ 2020-09-01 6:17 ` Yuehaibing
0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2020-09-01 6:17 UTC (permalink / raw)
To: Randy Dunlap, bhelgaas, tglx, mingo, bp, x86, hpa, efremov,
andriy.shevchenko
Cc: linux-pci, linux-kernel
On 2020/9/1 12:07, Randy Dunlap wrote:
> On 8/31/20 8:58 PM, YueHaibing wrote:
>> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
>> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
>> acpi_noirq_set();
>> ^~~~~~~~~~~~~~
>> acpi_irq_get
>>
>> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Bjorn has merged my patch (or so his email says), but apparently it's not
> in linux-next yet.
Thanks for info.
>
>
>> ---
>> arch/x86/pci/intel_mid_pci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
>> index 00c62115f39c..0aaf31917061 100644
>> --- a/arch/x86/pci/intel_mid_pci.c
>> +++ b/arch/x86/pci/intel_mid_pci.c
>> @@ -33,6 +33,7 @@
>> #include <asm/hw_irq.h>
>> #include <asm/io_apic.h>
>> #include <asm/intel-mid.h>
>> +#include <asm/acpi.h>
>>
>> #define PCIE_CAP_OFFSET 0x100
>>
>>
>
> thanks.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-01 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 3:58 [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI YueHaibing
2020-09-01 4:07 ` Randy Dunlap
2020-09-01 6:17 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).