* [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
@ 2014-10-04 9:48 Chen Gang
2014-10-06 10:08 ` Thierry Reding
0 siblings, 1 reply; 9+ messages in thread
From: Chen Gang @ 2014-10-04 9:48 UTC (permalink / raw)
To: thierry.reding, linux-pwm, linux-kernel
PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
allmodconfig under um):
MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 3865dfb..de1ffb5 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -82,7 +82,7 @@ config PWM_BFIN
config PWM_CLPS711X
tristate "CLPS711X PWM support"
- depends on ARCH_CLPS711X || COMPILE_TEST
+ depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
help
Generic PWM framework driver for Cirrus Logic CLPS711X.
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-10-04 9:48 [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM Chen Gang
@ 2014-10-06 10:08 ` Thierry Reding
2014-10-06 13:07 ` Chen Gang
0 siblings, 1 reply; 9+ messages in thread
From: Thierry Reding @ 2014-10-06 10:08 UTC (permalink / raw)
To: Chen Gang; +Cc: linux-pwm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On Sat, Oct 04, 2014 at 05:48:42PM +0800, Chen Gang wrote:
> PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> MODPOST 1205 modules
> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
> ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/pwm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 3865dfb..de1ffb5 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -82,7 +82,7 @@ config PWM_BFIN
>
> config PWM_CLPS711X
> tristate "CLPS711X PWM support"
> - depends on ARCH_CLPS711X || COMPILE_TEST
> + depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of
its own. This is in my opinion (slightly) more readable and matches what
we already have for other drivers.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-10-06 10:08 ` Thierry Reding
@ 2014-10-06 13:07 ` Chen Gang
0 siblings, 0 replies; 9+ messages in thread
From: Chen Gang @ 2014-10-06 13:07 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-pwm, linux-kernel
On 10/6/14 18:08, Thierry Reding wrote:
> On Sat, Oct 04, 2014 at 05:48:42PM +0800, Chen Gang wrote:
>> PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
>> allmodconfig under um):
>>
>> MODPOST 1205 modules
>> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
>> ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/pwm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> index 3865dfb..de1ffb5 100644
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -82,7 +82,7 @@ config PWM_BFIN
>>
>> config PWM_CLPS711X
>> tristate "CLPS711X PWM support"
>> - depends on ARCH_CLPS711X || COMPILE_TEST
>> + depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
>
> Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of
> its own. This is in my opinion (slightly) more readable and matches what
> we already have for other drivers.
>
It is OK to me, thank you for your work.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-07-14 10:00 ` Chen Gang
@ 2014-07-23 11:51 ` Chen Gang
0 siblings, 0 replies; 9+ messages in thread
From: Chen Gang @ 2014-07-23 11:51 UTC (permalink / raw)
To: Thierry Reding
Cc: linux-pwm, linux-kernel, Richard Weinberger, Liqin Chen, Lennox Wu
Oh, sorry, after a long discussion, we have to keep current status no
touch -- let individual modules depends on HAS_IOMEM if they need it.
So, this patch is still alive, please help check it, when you have time.
Thanks.
On 07/14/2014 06:00 PM, Chen Gang wrote:
>
> 在 2014年7月14日，下午5:33，Thierry Reding <thierry.reding@gmail.com> 写道：
>
>> On Mon, Jul 14, 2014 at 05:14:05PM +0800, Chen Gang wrote:
>>>
>>> 在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道：
>>>
>>>> On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote:
>>>>> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
>>>>>
>>>>> The related error (with allmodconfig under score):
>>>>>
>>>>> MODPOST 1365 modules
>>>>> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
>>>>>
>>>>>
>>>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>>>> ---
>>>>> drivers/pwm/Kconfig | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> NAK given the discussion in the other thread.
>>>>
>>>> Thierry
>>>
>>> OK, thanks, and I shall continue focusing the other thread, and send related patch after
>>> get conclusion (hope I can finish within this week).
>>
>> Great, thanks for taking care of this.
>>
>
> That what I should/will do. I start the related thread, so I have duty to try
> to finish it in time. :-)
>
> Thanks.
> —
> Chen Gang
> Open, share, and attitude like air, water, and life which God blessed.
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-07-14 9:33 ` Thierry Reding
@ 2014-07-14 10:00 ` Chen Gang
2014-07-23 11:51 ` Chen Gang
0 siblings, 1 reply; 9+ messages in thread
From: Chen Gang @ 2014-07-14 10:00 UTC (permalink / raw)
To: Thierry Reding
Cc: Chen Gang, linux-pwm, linux-kernel, Richard Weinberger,
Liqin Chen, Lennox Wu
在 2014年7月14日，下午5:33，Thierry Reding <thierry.reding@gmail.com> 写道：
> On Mon, Jul 14, 2014 at 05:14:05PM +0800, Chen Gang wrote:
>>
>> 在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道：
>>
>>> On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote:
>>>> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
>>>>
>>>> The related error (with allmodconfig under score):
>>>>
>>>> MODPOST 1365 modules
>>>> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
>>>>
>>>>
>>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>>> ---
>>>> drivers/pwm/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> NAK given the discussion in the other thread.
>>>
>>> Thierry
>>
>> OK, thanks, and I shall continue focusing the other thread, and send related patch after
>> get conclusion (hope I can finish within this week).
>
> Great, thanks for taking care of this.
>
That what I should/will do. I start the related thread, so I have duty to try
to finish it in time. :-)
Thanks.
—
Chen Gang
Open, share, and attitude like air, water, and life which God blessed.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-07-14 9:14 ` Chen Gang
@ 2014-07-14 9:33 ` Thierry Reding
2014-07-14 10:00 ` Chen Gang
0 siblings, 1 reply; 9+ messages in thread
From: Thierry Reding @ 2014-07-14 9:33 UTC (permalink / raw)
To: Chen Gang
Cc: linux-pwm, linux-kernel, Richard Weinberger, Liqin Chen, Lennox Wu
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Mon, Jul 14, 2014 at 05:14:05PM +0800, Chen Gang wrote:
>
> 在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道：
>
> > On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote:
> >> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
> >>
> >> The related error (with allmodconfig under score):
> >>
> >> MODPOST 1365 modules
> >> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
> >>
> >>
> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> >> ---
> >> drivers/pwm/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > NAK given the discussion in the other thread.
> >
> > Thierry
>
> OK, thanks, and I shall continue focusing the other thread, and send related patch after
> get conclusion (hope I can finish within this week).
Great, thanks for taking care of this.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-07-14 8:18 ` Thierry Reding
@ 2014-07-14 9:14 ` Chen Gang
2014-07-14 9:33 ` Thierry Reding
0 siblings, 1 reply; 9+ messages in thread
From: Chen Gang @ 2014-07-14 9:14 UTC (permalink / raw)
To: Thierry Reding
Cc: Chen Gang, linux-pwm, linux-kernel, Richard Weinberger,
Liqin Chen, Lennox Wu
在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道：
> On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote:
>> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
>>
>> The related error (with allmodconfig under score):
>>
>> MODPOST 1365 modules
>> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/pwm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> NAK given the discussion in the other thread.
>
> Thierry
OK, thanks, and I shall continue focusing the other thread, and send related patch after
get conclusion (hope I can finish within this week).
Thanks
—
Chen Gang
Open share, and attitude like air water, and life which God blessed.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
2014-07-13 11:49 Chen Gang
@ 2014-07-14 8:18 ` Thierry Reding
2014-07-14 9:14 ` Chen Gang
0 siblings, 1 reply; 9+ messages in thread
From: Thierry Reding @ 2014-07-14 8:18 UTC (permalink / raw)
To: Chen Gang
Cc: linux-pwm, linux-kernel, Richard Weinberger, Liqin Chen, Lennox Wu
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote:
> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
>
> The related error (with allmodconfig under score):
>
> MODPOST 1365 modules
> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/pwm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
NAK given the discussion in the other thread.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM
@ 2014-07-13 11:49 Chen Gang
2014-07-14 8:18 ` Thierry Reding
0 siblings, 1 reply; 9+ messages in thread
From: Chen Gang @ 2014-07-13 11:49 UTC (permalink / raw)
To: thierry.reding
Cc: linux-pwm, linux-kernel, Richard Weinberger, Liqin Chen, Lennox Wu
PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM.
The related error (with allmodconfig under score):
MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/pwm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 4ad7b89..2faf5ce 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -82,7 +82,7 @@ config PWM_BFIN
config PWM_CLPS711X
tristate "CLPS711X PWM support"
- depends on ARCH_CLPS711X || COMPILE_TEST
+ depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
help
Generic PWM framework driver for Cirrus Logic CLPS711X.
--
1.7.11.7
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-10-06 13:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-04 9:48 [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM Chen Gang
2014-10-06 10:08 ` Thierry Reding
2014-10-06 13:07 ` Chen Gang
-- strict thread matches above, loose matches on Subject: below --
2014-07-13 11:49 Chen Gang
2014-07-14 8:18 ` Thierry Reding
2014-07-14 9:14 ` Chen Gang
2014-07-14 9:33 ` Thierry Reding
2014-07-14 10:00 ` Chen Gang
2014-07-23 11:51 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).