* [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC @ 2014-10-06 17:53 Sonny Rao 2014-10-06 18:11 ` Doug Anderson 2014-10-08 11:28 ` Alim Akhtar 0 siblings, 2 replies; 8+ messages in thread From: Sonny Rao @ 2014-10-06 17:53 UTC (permalink / raw) To: linux-mmc Cc: Heiko Stuebner, Seungwon Jeon, Jaehoon Chung, Ulf Hansson, dianders, eddie.cai, addy.ke, linux-arm-kernel, linux-kernel, Sonny Rao We've already got a reset of DMA after it's done. Add one before we start DMA too. This fixes a data corruption on Rockchip SoCs which will get bad data when doing a DMA transfer after doing a PIO transfer. We tested this on an Exynos 5800 with HS200 and didn't notice any difference in sequential read throughput. Signed-off-by: Sonny Rao <sonnyrao@chromium.org> Signed-off-by: Doug Anderson <dianders@chromium.org> --- drivers/mmc/host/dw_mmc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 69f0cc6..2b5401e 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -83,6 +83,7 @@ struct idmac_desc { #endif /* CONFIG_MMC_DW_IDMAC */ static bool dw_mci_reset(struct dw_mci *host); +static bool dw_mci_ctrl_reset(struct dw_mci *host, u32 reset); #if defined(CONFIG_DEBUG_FS) static int dw_mci_req_show(struct seq_file *s, void *v) @@ -448,6 +449,9 @@ static void dw_mci_idmac_start_dma(struct dw_mci *host, unsigned int sg_len) dw_mci_translate_sglist(host, host->data, sg_len); + /* Make sure to reset DMA in case we did PIO before this */ + dw_mci_ctrl_reset(host, SDMMC_CTRL_DMA_RESET); + /* Select IDMAC interface */ temp = mci_readl(host, CTRL); temp |= SDMMC_CTRL_USE_IDMAC; -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC 2014-10-06 17:53 [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC Sonny Rao @ 2014-10-06 18:11 ` Doug Anderson 2014-10-07 23:59 ` Jaehoon Chung 2014-10-08 11:28 ` Alim Akhtar 1 sibling, 1 reply; 8+ messages in thread From: Doug Anderson @ 2014-10-06 18:11 UTC (permalink / raw) To: Sonny Rao Cc: linux-mmc, Heiko Stuebner, Seungwon Jeon, Jaehoon Chung, Ulf Hansson, Eddie Cai, Addy Ke, linux-arm-kernel, linux-kernel Sonny, On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao <sonnyrao@chromium.org> wrote: > We've already got a reset of DMA after it's done. Add one before we > start DMA too. This fixes a data corruption on Rockchip SoCs which > will get bad data when doing a DMA transfer after doing a PIO transfer. > > We tested this on an Exynos 5800 with HS200 and didn't notice any > difference in sequential read throughput. > > Signed-off-by: Sonny Rao <sonnyrao@chromium.org> > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > drivers/mmc/host/dw_mmc.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Doug Anderson <dianders@chromium.org> Tested-by: Doug Anderson <dianders@chromium.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC 2014-10-06 18:11 ` Doug Anderson @ 2014-10-07 23:59 ` Jaehoon Chung 0 siblings, 0 replies; 8+ messages in thread From: Jaehoon Chung @ 2014-10-07 23:59 UTC (permalink / raw) To: Doug Anderson, Sonny Rao Cc: linux-mmc, Heiko Stuebner, Seungwon Jeon, Ulf Hansson, Eddie Cai, Addy Ke, linux-arm-kernel, linux-kernel Acked-by: Jaehoon Chung <jh80.chung@samsung.com> On 10/07/2014 03:11 AM, Doug Anderson wrote: > Sonny, > > On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao <sonnyrao@chromium.org> wrote: >> We've already got a reset of DMA after it's done. Add one before we >> start DMA too. This fixes a data corruption on Rockchip SoCs which >> will get bad data when doing a DMA transfer after doing a PIO transfer. >> >> We tested this on an Exynos 5800 with HS200 and didn't notice any >> difference in sequential read throughput. >> >> Signed-off-by: Sonny Rao <sonnyrao@chromium.org> >> Signed-off-by: Doug Anderson <dianders@chromium.org> >> --- >> drivers/mmc/host/dw_mmc.c | 4 ++++ >> 1 file changed, 4 insertions(+) > > Reviewed-by: Doug Anderson <dianders@chromium.org> > Tested-by: Doug Anderson <dianders@chromium.org> > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC 2014-10-06 17:53 [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC Sonny Rao 2014-10-06 18:11 ` Doug Anderson @ 2014-10-08 11:28 ` Alim Akhtar [not found] ` <CAO3aYcqi0g=eJta33s5oM-tAAmAhe86VvHd43p5RJ7qMPZzfrg@mail.gmail.com> 1 sibling, 1 reply; 8+ messages in thread From: Alim Akhtar @ 2014-10-08 11:28 UTC (permalink / raw) To: Sonny Rao Cc: linux-mmc, Heiko Stuebner, Seungwon Jeon, Jaehoon Chung, Ulf Hansson, Douglas Anderson, eddie.cai, addy.ke, linux-arm-kernel, linux-kernel Hi Sonny/Doug, On Mon, Oct 6, 2014 at 11:23 PM, Sonny Rao <sonnyrao@chromium.org> wrote: > We've already got a reset of DMA after it's done. Add one before we > start DMA too. This fixes a data corruption on Rockchip SoCs which > will get bad data when doing a DMA transfer after doing a PIO transfer. > > We tested this on an Exynos 5800 with HS200 and didn't notice any > difference in sequential read throughput. > > Signed-off-by: Sonny Rao <sonnyrao@chromium.org> > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > drivers/mmc/host/dw_mmc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 69f0cc6..2b5401e 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -83,6 +83,7 @@ struct idmac_desc { > #endif /* CONFIG_MMC_DW_IDMAC */ > > static bool dw_mci_reset(struct dw_mci *host); > +static bool dw_mci_ctrl_reset(struct dw_mci *host, u32 reset); > > #if defined(CONFIG_DEBUG_FS) > static int dw_mci_req_show(struct seq_file *s, void *v) > @@ -448,6 +449,9 @@ static void dw_mci_idmac_start_dma(struct dw_mci *host, unsigned int sg_len) > > dw_mci_translate_sglist(host, host->data, sg_len); > > + /* Make sure to reset DMA in case we did PIO before this */ > + dw_mci_ctrl_reset(host, SDMMC_CTRL_DMA_RESET); > + Though this is good to do, but this does not look complete to me. dw_mmc data book does mention that " It is recommended that the host issue reset to DMA interface by setting DMA_RESET bit of the CTRL register and then issue a IDMAC software reset." The above lines are from 'Transmission and reception with internal DMA' section of the data book. My suggestion here to add dw_mci_idmac_reset() call after this above change. What is the controller version used in your case? > /* Select IDMAC interface */ > temp = mci_readl(host, CTRL); > temp |= SDMMC_CTRL_USE_IDMAC; > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Alim ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAO3aYcqi0g=eJta33s5oM-tAAmAhe86VvHd43p5RJ7qMPZzfrg@mail.gmail.com>]
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC [not found] ` <CAO3aYcqi0g=eJta33s5oM-tAAmAhe86VvHd43p5RJ7qMPZzfrg@mail.gmail.com> @ 2014-10-09 22:19 ` Alim Akhtar 2014-10-10 0:36 ` Doug Anderson 0 siblings, 1 reply; 8+ messages in thread From: Alim Akhtar @ 2014-10-09 22:19 UTC (permalink / raw) To: Eddie Cai(蔡枫) Cc: Ulf Hansson, linux-mmc, Heiko Stuebner, Sonny Rao, Seungwon Jeon, linux-kernel, addy.ke, Jaehoon Chung, linux-arm-kernel, Douglas Anderson Hi Eddie, On Thu, Oct 9, 2014 at 7:43 PM, Eddie Cai(蔡枫) <eddie.cai@rock-chips.com> wrote: > Hi Alim > > 2014年10月8日 上午4:28于 "Alim Akhtar" <alim.akhtar@gmail.com>写道: > > >> >> Hi Sonny/Doug, >> >> On Mon, Oct 6, 2014 at 11:23 PM, Sonny Rao <sonnyrao@chromium.org> wrote: >> > We've already got a reset of DMA after it's done. Add one before we >> > start DMA too. This fixes a data corruption on Rockchip SoCs which >> > will get bad data when doing a DMA transfer after doing a PIO transfer. >> > >> > We tested this on an Exynos 5800 with HS200 and didn't notice any >> > difference in sequential read throughput. >> > >> > Signed-off-by: Sonny Rao <sonnyrao@chromium.org> >> > Signed-off-by: Doug Anderson <dianders@chromium.org> >> > --- >> > drivers/mmc/host/dw_mmc.c | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> > index 69f0cc6..2b5401e 100644 >> > --- a/drivers/mmc/host/dw_mmc.c >> > +++ b/drivers/mmc/host/dw_mmc.c >> > @@ -83,6 +83,7 @@ struct idmac_desc { >> > #endif /* CONFIG_MMC_DW_IDMAC */ >> > >> > static bool dw_mci_reset(struct dw_mci *host); >> > +static bool dw_mci_ctrl_reset(struct dw_mci *host, u32 reset); >> > >> > #if defined(CONFIG_DEBUG_FS) >> > static int dw_mci_req_show(struct seq_file *s, void *v) >> > @@ -448,6 +449,9 @@ static void dw_mci_idmac_start_dma(struct dw_mci >> > *host, unsigned int sg_len) >> > >> > dw_mci_translate_sglist(host, host->data, sg_len); >> > >> > + /* Make sure to reset DMA in case we did PIO before this */ >> > + dw_mci_ctrl_reset(host, SDMMC_CTRL_DMA_RESET); >> > + >> Though this is good to do, but this does not look complete to me. >> dw_mmc data book does mention that " It is recommended that the host >> issue reset to DMA interface by setting DMA_RESET bit of the CTRL >> register and then issue a IDMAC software reset." >> The above lines are from 'Transmission and reception with internal >> DMA' section of the data book. >> My suggestion here to add dw_mci_idmac_reset() call after this above >> change. >> >> What is the controller version used in your case? > > it just compatible with dw mmc controler but not the same one. it is > designed by rockchip. > Thats fine, I think every vendor (most of them) has a custom implementation of dw_mmc, but they do have VERID register to check the dw_mmc version. The reason why I asked is, I have seen inconsistency in card enumeration on few controller version, and this patch alone does not help, and adding a call to dw_mci_idmac_reset() after DMA reset is needed. And this is what is recommended in the synopsys's data book also. Do you see any issue/side effect after adding dw_mci_idmac_reset()? >> > /* Select IDMAC interface */ >> > temp = mci_readl(host, CTRL); >> > temp |= SDMMC_CTRL_USE_IDMAC; >> > -- >> > 1.8.3.2 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> > the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> >> -- >> Regards, >> Alim >> >> -- Regards, Alim ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC 2014-10-09 22:19 ` Alim Akhtar @ 2014-10-10 0:36 ` Doug Anderson 2014-10-14 16:51 ` Doug Anderson 0 siblings, 1 reply; 8+ messages in thread From: Doug Anderson @ 2014-10-10 0:36 UTC (permalink / raw) To: Alim Akhtar Cc: Eddie Cai(蔡枫), Ulf Hansson, linux-mmc, Heiko Stuebner, Sonny Rao, Seungwon Jeon, linux-kernel, Addy Ke, Jaehoon Chung, linux-arm-kernel Alim, On Thu, Oct 9, 2014 at 3:19 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote: > Thats fine, I think every vendor (most of them) has a custom > implementation of dw_mmc, but they do have VERID register to check the > dw_mmc version. > The reason why I asked is, I have seen inconsistency in card > enumeration on few controller version, and this patch alone does not > help, and adding a call to dw_mci_idmac_reset() after DMA reset is > needed. And this is what is recommended in the synopsys's data book > also. > Do you see any issue/side effect after adding dw_mci_idmac_reset()? A quick test shows no problem with adding this to Sonny's patch: diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 66dc8fe..588b5b8 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -481,6 +481,7 @@ static void dw_mci_idmac_start_dma(struct dw_mci *host, unsigned int sg_len) /* Make sure to reset DMA in case we did PIO before this */ dw_mci_ctrl_reset(host, SDMMC_CTRL_DMA_RESET); + dw_mci_idmac_reset(host); /* Select IDMAC interface */ temp = mci_readl(host, CTRL); I'll start reboot tests now to see how it behaves... I think Sonny is out of the office for a few days so we might need to wait for a spin, but I'll run with that change in the meantime and see how it behaves for me. Thanks! -Doug ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC 2014-10-10 0:36 ` Doug Anderson @ 2014-10-14 16:51 ` Doug Anderson 2014-10-14 19:58 ` Alim Akhtar 0 siblings, 1 reply; 8+ messages in thread From: Doug Anderson @ 2014-10-14 16:51 UTC (permalink / raw) To: Alim Akhtar Cc: Eddie Cai(蔡枫), Ulf Hansson, linux-mmc, Heiko Stuebner, Sonny Rao, Seungwon Jeon, linux-kernel, Addy Ke, Jaehoon Chung, linux-arm-kernel Hi, On Thu, Oct 9, 2014 at 5:36 PM, Doug Anderson <dianders@chromium.org> wrote: > Alim, > > On Thu, Oct 9, 2014 at 3:19 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote: >> Thats fine, I think every vendor (most of them) has a custom >> implementation of dw_mmc, but they do have VERID register to check the >> dw_mmc version. >> The reason why I asked is, I have seen inconsistency in card >> enumeration on few controller version, and this patch alone does not >> help, and adding a call to dw_mci_idmac_reset() after DMA reset is >> needed. And this is what is recommended in the synopsys's data book >> also. >> Do you see any issue/side effect after adding dw_mci_idmac_reset()? > > A quick test shows no problem with adding this to Sonny's patch: > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 66dc8fe..588b5b8 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -481,6 +481,7 @@ static void dw_mci_idmac_start_dma(struct dw_mci > *host, unsigned int sg_len) > > /* Make sure to reset DMA in case we did PIO before this */ > dw_mci_ctrl_reset(host, SDMMC_CTRL_DMA_RESET); > + dw_mci_idmac_reset(host); > > /* Select IDMAC interface */ > temp = mci_readl(host, CTRL); > > I'll start reboot tests now to see how it behaves... I think Sonny is > out of the office for a few days so we might need to wait for a spin, > but I'll run with that change in the meantime and see how it behaves > for me. > > Thanks! Just FYI that I've been running with Alim's proposed change for several days and it seems solid. I think Sonny may be able to spin his patch this week. :) -Doug ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC 2014-10-14 16:51 ` Doug Anderson @ 2014-10-14 19:58 ` Alim Akhtar 0 siblings, 0 replies; 8+ messages in thread From: Alim Akhtar @ 2014-10-14 19:58 UTC (permalink / raw) To: Doug Anderson Cc: Eddie Cai(蔡枫), Ulf Hansson, linux-mmc, Heiko Stuebner, Sonny Rao, Seungwon Jeon, linux-kernel, Addy Ke, Jaehoon Chung, linux-arm-kernel Hi Doug, On Tue, Oct 14, 2014 at 10:21 PM, Doug Anderson <dianders@chromium.org> wrote: > Hi, > > On Thu, Oct 9, 2014 at 5:36 PM, Doug Anderson <dianders@chromium.org> wrote: >> Alim, >> >> On Thu, Oct 9, 2014 at 3:19 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote: >>> Thats fine, I think every vendor (most of them) has a custom >>> implementation of dw_mmc, but they do have VERID register to check the >>> dw_mmc version. >>> The reason why I asked is, I have seen inconsistency in card >>> enumeration on few controller version, and this patch alone does not >>> help, and adding a call to dw_mci_idmac_reset() after DMA reset is >>> needed. And this is what is recommended in the synopsys's data book >>> also. >>> Do you see any issue/side effect after adding dw_mci_idmac_reset()? >> >> A quick test shows no problem with adding this to Sonny's patch: >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 66dc8fe..588b5b8 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -481,6 +481,7 @@ static void dw_mci_idmac_start_dma(struct dw_mci >> *host, unsigned int sg_len) >> >> /* Make sure to reset DMA in case we did PIO before this */ >> dw_mci_ctrl_reset(host, SDMMC_CTRL_DMA_RESET); >> + dw_mci_idmac_reset(host); >> >> /* Select IDMAC interface */ >> temp = mci_readl(host, CTRL); >> >> I'll start reboot tests now to see how it behaves... I think Sonny is >> out of the office for a few days so we might need to wait for a spin, >> but I'll run with that change in the meantime and see how it behaves >> for me. >> >> Thanks! > > Just FYI that I've been running with Alim's proposed change for > several days and it seems solid. I think Sonny may be able to spin > his patch this week. :) > Sounds great. Thanks for testing. > -Doug -- Regards, Alim ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-10-14 19:58 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-10-06 17:53 [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC Sonny Rao 2014-10-06 18:11 ` Doug Anderson 2014-10-07 23:59 ` Jaehoon Chung 2014-10-08 11:28 ` Alim Akhtar [not found] ` <CAO3aYcqi0g=eJta33s5oM-tAAmAhe86VvHd43p5RJ7qMPZzfrg@mail.gmail.com> 2014-10-09 22:19 ` Alim Akhtar 2014-10-10 0:36 ` Doug Anderson 2014-10-14 16:51 ` Doug Anderson 2014-10-14 19:58 ` Alim Akhtar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).