From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, broonie@kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org,
marek.vasut@gmail.com, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v6 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Mon, 21 Jan 2019 21:14:33 +0300 [thread overview]
Message-ID: <5440645d-6b52-ad72-1c98-2d140f1cd15d@cogentembedded.com> (raw)
In-Reply-To: <OFE50FED81.5C117A38-ON48258389.0012FCE2-48258389.00139BD2@mxic.com.tw>
Hello!
On 01/21/2019 06:34 AM, masonccyang@mxic.com.tw wrote:
>> > +#define RPC_SMENR 0x0030 // R/W
>> > +#define RPC_SMENR_CDB(o) (((o) & 0x2) << 30)
>> > +#define RPC_SMENR_OCDB(o) (((o) & 0x2) << 28)
>> > +#define RPC_SMENR_ADB(o) (((o) & 0x2) << 24)
>> > +#define RPC_SMENR_OPDB(o) (((o) & 0x2) << 20)
>> > +#define RPC_SMENR_SPIDB(o) (((o) & 0x2) << 16)
>>
>> Ugh, s/0x2/0x3/! :-/
>>
>> [...]
>> > +#define RPC_SMDRENR 0x0064 // R/W
>> > +#define RPC_SMDRENR_HYPE (0x5 << 12)
>>
>> s/0x5/0x7/, and this is a field, not value.
>>
>
> okay, both 0x2 and 0x5 are just make sure these registers was
> writing a correct value rather than a prohibited value.
> anyway, I will patch them.
TIA.
>> [...]
>> > +static int rpc_spi_probe(struct platform_device *pdev)
>> > +{
>> > + struct spi_controller *ctlr;
>> > + struct resource *res;
>> > + struct rpc_spi *rpc;
>> > + const struct regmap_config *regmap_config;
>> > + struct device_node *rpc_if;
>> > + int ret;
>> > +
>> > + rpc_if = of_find_compatible_node(pdev->dev.of_node, NULL,
>> > + "jedec,spi-nor");
>>
>> I doubt that this is a correct function to check for the child node's
>> "compatible" prop...
You need of_get_next_child() or of_get_next_available_child().
>>
>> [...]
>> > + regmap_config = &rpc_spi_regmap_config;
>>
>> Doesn't look like this variable is needed...
>
> why ?
Why not just use &rpc_spi_regmap_config below?
>> > + rpc->regmap = devm_regmap_init_mmio(&pdev->dev, rpc->base,
>> > + regmap_config);
[...]
> Mason
MBR, Sergei
next prev parent reply other threads:[~2019-01-21 18:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 5:54 [PATCH v6 0/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI driver Mason Yang
2019-01-18 5:54 ` [PATCH v6 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-01-18 8:25 ` Geert Uytterhoeven
2019-01-18 19:43 ` Sergei Shtylyov
[not found] ` <OFE50FED81.5C117A38-ON48258389.0012FCE2-48258389.00139BD2@mxic.com.tw>
2019-01-21 18:14 ` Sergei Shtylyov [this message]
2019-01-18 5:54 ` [PATCH v6 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-01-18 6:16 ` Marek Vasut
[not found] ` <OF914E6438.79205FE6-ON48258386.002973E8-48258386.002A41F0@mxic.com.tw>
2019-01-18 7:46 ` Marek Vasut
2019-01-18 8:23 ` Sergei Shtylyov
2019-01-18 8:03 ` Geert Uytterhoeven
2019-01-18 8:08 ` Marek Vasut
2019-01-18 8:10 ` Geert Uytterhoeven
2019-01-18 8:12 ` Marek Vasut
[not found] ` <OFBD5366C8.433ADACB-ON48258386.00336667-48258386.00340E20@mxic.com.tw>
2019-01-18 10:39 ` Geert Uytterhoeven
2019-01-18 8:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5440645d-6b52-ad72-1c98-2d140f1cd15d@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).