From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: Mark Brown <broonie@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Boris Brezillon <bbrezillon@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
juliensu@mxic.com.tw, Simon Horman <horms@verge.net.au>,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH v6 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Fri, 18 Jan 2019 09:25:26 +0100 [thread overview]
Message-ID: <CAMuHMdW21JEz+pZbU5bb2Jcn8xpopsZ5LbbYhh2iGZFqtWCeQg@mail.gmail.com> (raw)
In-Reply-To: <1547790855-22120-2-git-send-email-masonccyang@mxic.com.tw>
Hi Mason,
On Fri, Jan 18, 2019 at 6:55 AM Mason Yang <masonccyang@mxic.com.tw> wrote:
> Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for the update!
> --- /dev/null
> +++ b/drivers/spi/spi-renesas-rpc.c
> @@ -0,0 +1,800 @@
> +static int rpc_spi_xfer_message(struct rpc_spi *rpc,
> + struct spi_transfer *t)
As "t" is not an arbitrary transfer, but the last transfer containing the
actual data, I'd call it "last", or "data_xfer".
> +{
> + int ret;
> +
> + ret = rpc_spi_set_freq(rpc, t->speed_hz);
> + if (ret)
> + return ret;
> +
> + ret = rpc_spi_io_xfer(rpc,
> + rpc->xfer_dir == SPI_MEM_DATA_OUT ?
> + t->tx_buf : NULL,
> + rpc->xfer_dir == SPI_MEM_DATA_IN ?
> + t->rx_buf : NULL);
> +
> + return ret;
> +}
> +
> +static int rpc_spi_transfer_one_message(struct spi_controller *ctlr,
> + struct spi_message *msg)
> +{
> + struct rpc_spi *rpc = spi_controller_get_devdata(ctlr);
> + struct spi_transfer *t;
Likewise.
> + int ret;
> +
> + rpc_spi_transfer_setup(rpc, msg);
> +
> + t = list_last_entry(&msg->transfers, struct spi_transfer,
> + transfer_list);
> +
> + ret = rpc_spi_xfer_message(rpc, t);
As this function is small, perhaps just inline it here?
IMHO that makes the flow clearer.
> + if (ret)
> + goto out;
> +
> + msg->status = 0;
> + msg->actual_length = rpc->totalxferlen;
> +out:
> + spi_finalize_current_message(ctlr);
> + return 0;
> +}
The rest looks good to me, thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-01-18 8:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 5:54 [PATCH v6 0/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI driver Mason Yang
2019-01-18 5:54 ` [PATCH v6 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-01-18 8:25 ` Geert Uytterhoeven [this message]
2019-01-18 19:43 ` Sergei Shtylyov
[not found] ` <OFE50FED81.5C117A38-ON48258389.0012FCE2-48258389.00139BD2@mxic.com.tw>
2019-01-21 18:14 ` Sergei Shtylyov
2019-01-18 5:54 ` [PATCH v6 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-01-18 6:16 ` Marek Vasut
[not found] ` <OF914E6438.79205FE6-ON48258386.002973E8-48258386.002A41F0@mxic.com.tw>
2019-01-18 7:46 ` Marek Vasut
2019-01-18 8:23 ` Sergei Shtylyov
2019-01-18 8:03 ` Geert Uytterhoeven
2019-01-18 8:08 ` Marek Vasut
2019-01-18 8:10 ` Geert Uytterhoeven
2019-01-18 8:12 ` Marek Vasut
[not found] ` <OFBD5366C8.433ADACB-ON48258386.00336667-48258386.00340E20@mxic.com.tw>
2019-01-18 10:39 ` Geert Uytterhoeven
2019-01-18 8:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW21JEz+pZbU5bb2Jcn8xpopsZ5LbbYhh2iGZFqtWCeQg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).