* [PATCH] iio: Fix IIO_EVENT_CODE_EXTRACT_DIR bit mask
@ 2014-11-11 14:07 Cristina Ciocan
2014-11-15 16:04 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Cristina Ciocan @ 2014-11-11 14:07 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: lars, linux-kernel, Cristina Ciocan
The direction field is set on 7 bits, thus we need to AND it with 0111 111 mask
in order to retrieve it, that is 0x7F, not 0xCF as it is now.
Fixes: ade7ef7ba (staging:iio: Differential channel handling)
Signed-off-by: Cristina Ciocan <cristina.ciocan@intel.com>
---
include/linux/iio/events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/events.h b/include/linux/iio/events.h
index 8bbd7bc..03fa332 100644
--- a/include/linux/iio/events.h
+++ b/include/linux/iio/events.h
@@ -72,7 +72,7 @@ struct iio_event_data {
#define IIO_EVENT_CODE_EXTRACT_TYPE(mask) ((mask >> 56) & 0xFF)
-#define IIO_EVENT_CODE_EXTRACT_DIR(mask) ((mask >> 48) & 0xCF)
+#define IIO_EVENT_CODE_EXTRACT_DIR(mask) ((mask >> 48) & 0x7F)
#define IIO_EVENT_CODE_EXTRACT_CHAN_TYPE(mask) ((mask >> 32) & 0xFF)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: Fix IIO_EVENT_CODE_EXTRACT_DIR bit mask
2014-11-11 14:07 [PATCH] iio: Fix IIO_EVENT_CODE_EXTRACT_DIR bit mask Cristina Ciocan
@ 2014-11-15 16:04 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2014-11-15 16:04 UTC (permalink / raw)
To: Cristina Ciocan, linux-iio; +Cc: lars, linux-kernel
On 11/11/14 14:07, Cristina Ciocan wrote:
> The direction field is set on 7 bits, thus we need to AND it with 0111 111 mask
> in order to retrieve it, that is 0x7F, not 0xCF as it is now.
>
> Fixes: ade7ef7ba (staging:iio: Differential channel handling)
> Signed-off-by: Cristina Ciocan <cristina.ciocan@intel.com>
Applied to the fixes togreg branch of iio,git.
Thanks,
Jonathan
> ---
> include/linux/iio/events.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/events.h b/include/linux/iio/events.h
> index 8bbd7bc..03fa332 100644
> --- a/include/linux/iio/events.h
> +++ b/include/linux/iio/events.h
> @@ -72,7 +72,7 @@ struct iio_event_data {
>
> #define IIO_EVENT_CODE_EXTRACT_TYPE(mask) ((mask >> 56) & 0xFF)
>
> -#define IIO_EVENT_CODE_EXTRACT_DIR(mask) ((mask >> 48) & 0xCF)
> +#define IIO_EVENT_CODE_EXTRACT_DIR(mask) ((mask >> 48) & 0x7F)
>
> #define IIO_EVENT_CODE_EXTRACT_CHAN_TYPE(mask) ((mask >> 32) & 0xFF)
>
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-15 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-11 14:07 [PATCH] iio: Fix IIO_EVENT_CODE_EXTRACT_DIR bit mask Cristina Ciocan
2014-11-15 16:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).